aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/cpufreq/sa1100-cpufreq.c
diff options
context:
space:
mode:
authorViresh Kumar <viresh.kumar@linaro.org>2013-08-14 10:08:24 -0400
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2013-10-30 19:11:08 -0400
commitd4019f0a92ab802f385cc9c8ad3ab7b5449712cb (patch)
treeebd06695585e457ae1bf219653452b111e7508db /drivers/cpufreq/sa1100-cpufreq.c
parent7dbf694db6ac7c759599316d50d7050efcbd512a (diff)
cpufreq: move freq change notifications to cpufreq core
Most of the drivers do following in their ->target_index() routines: struct cpufreq_freqs freqs; freqs.old = old freq... freqs.new = new freq... cpufreq_notify_transition(policy, &freqs, CPUFREQ_PRECHANGE); /* Change rate here */ cpufreq_notify_transition(policy, &freqs, CPUFREQ_POSTCHANGE); This is replicated over all cpufreq drivers today and there doesn't exists a good enough reason why this shouldn't be moved to cpufreq core instead. There are few special cases though, like exynos5440, which doesn't do everything on the call to ->target_index() routine and call some kind of bottom halves for doing this work, work/tasklet/etc.. They may continue doing notification from their own code as flag: CPUFREQ_ASYNC_NOTIFICATION is already set for them. All drivers are also modified in this patch to avoid breaking 'git bisect', as double notification would happen otherwise. Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no> Acked-by: Jesper Nilsson <jesper.nilsson@axis.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Acked-by: Russell King <linux@arm.linux.org.uk> Acked-by: Stephen Warren <swarren@nvidia.com> Tested-by: Andrew Lunn <andrew@lunn.ch> Tested-by: Nicolas Pitre <nicolas.pitre@linaro.org> Reviewed-by: Lan Tianyu <tianyu.lan@intel.com> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/cpufreq/sa1100-cpufreq.c')
-rw-r--r--drivers/cpufreq/sa1100-cpufreq.c17
1 files changed, 6 insertions, 11 deletions
diff --git a/drivers/cpufreq/sa1100-cpufreq.c b/drivers/cpufreq/sa1100-cpufreq.c
index b0da1fe40b1d..623da742f8e7 100644
--- a/drivers/cpufreq/sa1100-cpufreq.c
+++ b/drivers/cpufreq/sa1100-cpufreq.c
@@ -180,22 +180,17 @@ static void sa1100_update_dram_timings(int current_speed, int new_speed)
180static int sa1100_target(struct cpufreq_policy *policy, unsigned int ppcr) 180static int sa1100_target(struct cpufreq_policy *policy, unsigned int ppcr)
181{ 181{
182 unsigned int cur = sa11x0_getspeed(0); 182 unsigned int cur = sa11x0_getspeed(0);
183 struct cpufreq_freqs freqs; 183 unsigned int new_freq;
184 184
185 freqs.old = cur; 185 new_freq = sa11x0_freq_table[ppcr].frequency;
186 freqs.new = sa11x0_freq_table[ppcr].frequency;
187 186
188 cpufreq_notify_transition(policy, &freqs, CPUFREQ_PRECHANGE); 187 if (new_freq > cur)
189 188 sa1100_update_dram_timings(cur, new_freq);
190 if (freqs.new > cur)
191 sa1100_update_dram_timings(cur, freqs.new);
192 189
193 PPCR = ppcr; 190 PPCR = ppcr;
194 191
195 if (freqs.new < cur) 192 if (new_freq < cur)
196 sa1100_update_dram_timings(cur, freqs.new); 193 sa1100_update_dram_timings(cur, new_freq);
197
198 cpufreq_notify_transition(policy, &freqs, CPUFREQ_POSTCHANGE);
199 194
200 return 0; 195 return 0;
201} 196}