diff options
author | Haojian Zhuang <haojian.zhuang@gmail.com> | 2012-12-03 03:14:37 -0500 |
---|---|---|
committer | Mike Turquette <mturquette@linaro.org> | 2013-01-11 21:43:27 -0500 |
commit | bab53301c3846ae9a5e1142dca2976f434f70481 (patch) | |
tree | 2d872a2a8fc40d6f4975ee153f8d76f227d7813a /drivers/clk/clk-fixed-factor.c | |
parent | 4895084c87ab0973308021d755596798160b682a (diff) |
clk: fixed-factor: round_rate should use do_div
clk->rate = parent->rate / div * mult
The formula is OK. But it may overflow while we do operate with
unsigned long. So use do_div instead.
Signed-off-by: Haojian Zhuang <haojian.zhuang@gmail.com>
Signed-off-by: Mike Turquette <mturquette@linaro.org>
[mturquette@linaro.org: improved $SUBJECT]
Diffstat (limited to 'drivers/clk/clk-fixed-factor.c')
-rw-r--r-- | drivers/clk/clk-fixed-factor.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-factor.c index a4899855c0f6..1ef271e47594 100644 --- a/drivers/clk/clk-fixed-factor.c +++ b/drivers/clk/clk-fixed-factor.c | |||
@@ -28,8 +28,11 @@ static unsigned long clk_factor_recalc_rate(struct clk_hw *hw, | |||
28 | unsigned long parent_rate) | 28 | unsigned long parent_rate) |
29 | { | 29 | { |
30 | struct clk_fixed_factor *fix = to_clk_fixed_factor(hw); | 30 | struct clk_fixed_factor *fix = to_clk_fixed_factor(hw); |
31 | unsigned long long int rate; | ||
31 | 32 | ||
32 | return parent_rate * fix->mult / fix->div; | 33 | rate = (unsigned long long int)parent_rate * fix->mult; |
34 | do_div(rate, fix->div); | ||
35 | return (unsigned long)rate; | ||
33 | } | 36 | } |
34 | 37 | ||
35 | static long clk_factor_round_rate(struct clk_hw *hw, unsigned long rate, | 38 | static long clk_factor_round_rate(struct clk_hw *hw, unsigned long rate, |