diff options
author | Julia Lawall <julia@diku.dk> | 2011-06-08 08:59:38 -0400 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2011-06-29 19:44:01 -0400 |
commit | 6ba1a31ef146f25a457968c00c8c10bbe1a3ccfe (patch) | |
tree | b562defd5be29f7bae4874fcd759e285a7a86e55 /drivers/char | |
parent | 8af00860c913d5e814f3c10232a0f42e2a964b99 (diff) |
hwrng: omap - add missing clk_put
Convert a return to a jump to an existing label that calls clk_put.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
expression e1,e2;
statement S;
@@
e1 = clk_get@p1(...);
... when != e1 = e2
when != clk_put(e1)
when any
if (...) { ... when != clk_put(e1)
when != if (...) { ... clk_put(e1) ... }
* return@p3 ...;
} else S
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Matt Mackall <mpm@selenic.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/char')
-rw-r--r-- | drivers/char/hw_random/omap-rng.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/char/hw_random/omap-rng.c b/drivers/char/hw_random/omap-rng.c index 2cc755a64302..b757fac3cd1f 100644 --- a/drivers/char/hw_random/omap-rng.c +++ b/drivers/char/hw_random/omap-rng.c | |||
@@ -113,8 +113,10 @@ static int __devinit omap_rng_probe(struct platform_device *pdev) | |||
113 | 113 | ||
114 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); | 114 | res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
115 | 115 | ||
116 | if (!res) | 116 | if (!res) { |
117 | return -ENOENT; | 117 | ret = -ENOENT; |
118 | goto err_region; | ||
119 | } | ||
118 | 120 | ||
119 | if (!request_mem_region(res->start, resource_size(res), pdev->name)) { | 121 | if (!request_mem_region(res->start, resource_size(res), pdev->name)) { |
120 | ret = -EBUSY; | 122 | ret = -EBUSY; |