diff options
author | Corey Minyard <cminyard@mvista.com> | 2014-11-06 21:48:02 -0500 |
---|---|---|
committer | Corey Minyard <cminyard@mvista.com> | 2014-12-11 16:04:08 -0500 |
commit | 65be754453a3625487670b086b1f9a662f28c610 (patch) | |
tree | ba9bc71b550cc63c41712e34c1831f737ef5e5bf /drivers/char | |
parent | 968bf7cc47bff66966149c14ad6c7024d67534aa (diff) |
ipmi: rename waiting_msgs to waiting_rcv_msgs
To avoid confusion with the coming transmit message queue.
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Diffstat (limited to 'drivers/char')
-rw-r--r-- | drivers/char/ipmi/ipmi_msghandler.c | 31 |
1 files changed, 16 insertions, 15 deletions
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c index dac563709cd5..31de905b0a0e 100644 --- a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c | |||
@@ -377,8 +377,8 @@ struct ipmi_smi { | |||
377 | * periodic timer interrupt. The tasklet is for handling received | 377 | * periodic timer interrupt. The tasklet is for handling received |
378 | * messages directly from the handler. | 378 | * messages directly from the handler. |
379 | */ | 379 | */ |
380 | spinlock_t waiting_msgs_lock; | 380 | spinlock_t waiting_rcv_msgs_lock; |
381 | struct list_head waiting_msgs; | 381 | struct list_head waiting_rcv_msgs; |
382 | atomic_t watchdog_pretimeouts_to_deliver; | 382 | atomic_t watchdog_pretimeouts_to_deliver; |
383 | struct tasklet_struct recv_tasklet; | 383 | struct tasklet_struct recv_tasklet; |
384 | 384 | ||
@@ -529,7 +529,7 @@ static void clean_up_interface_data(ipmi_smi_t intf) | |||
529 | 529 | ||
530 | tasklet_kill(&intf->recv_tasklet); | 530 | tasklet_kill(&intf->recv_tasklet); |
531 | 531 | ||
532 | free_smi_msg_list(&intf->waiting_msgs); | 532 | free_smi_msg_list(&intf->waiting_rcv_msgs); |
533 | free_recv_msg_list(&intf->waiting_events); | 533 | free_recv_msg_list(&intf->waiting_events); |
534 | 534 | ||
535 | /* | 535 | /* |
@@ -2798,8 +2798,8 @@ int ipmi_register_smi(struct ipmi_smi_handlers *handlers, | |||
2798 | #ifdef CONFIG_PROC_FS | 2798 | #ifdef CONFIG_PROC_FS |
2799 | mutex_init(&intf->proc_entry_lock); | 2799 | mutex_init(&intf->proc_entry_lock); |
2800 | #endif | 2800 | #endif |
2801 | spin_lock_init(&intf->waiting_msgs_lock); | 2801 | spin_lock_init(&intf->waiting_rcv_msgs_lock); |
2802 | INIT_LIST_HEAD(&intf->waiting_msgs); | 2802 | INIT_LIST_HEAD(&intf->waiting_rcv_msgs); |
2803 | tasklet_init(&intf->recv_tasklet, | 2803 | tasklet_init(&intf->recv_tasklet, |
2804 | smi_recv_tasklet, | 2804 | smi_recv_tasklet, |
2805 | (unsigned long) intf); | 2805 | (unsigned long) intf); |
@@ -3746,16 +3746,17 @@ static void handle_new_recv_msgs(ipmi_smi_t intf) | |||
3746 | 3746 | ||
3747 | /* See if any waiting messages need to be processed. */ | 3747 | /* See if any waiting messages need to be processed. */ |
3748 | if (!run_to_completion) | 3748 | if (!run_to_completion) |
3749 | spin_lock_irqsave(&intf->waiting_msgs_lock, flags); | 3749 | spin_lock_irqsave(&intf->waiting_rcv_msgs_lock, flags); |
3750 | while (!list_empty(&intf->waiting_msgs)) { | 3750 | while (!list_empty(&intf->waiting_rcv_msgs)) { |
3751 | smi_msg = list_entry(intf->waiting_msgs.next, | 3751 | smi_msg = list_entry(intf->waiting_rcv_msgs.next, |
3752 | struct ipmi_smi_msg, link); | 3752 | struct ipmi_smi_msg, link); |
3753 | list_del(&smi_msg->link); | 3753 | list_del(&smi_msg->link); |
3754 | if (!run_to_completion) | 3754 | if (!run_to_completion) |
3755 | spin_unlock_irqrestore(&intf->waiting_msgs_lock, flags); | 3755 | spin_unlock_irqrestore(&intf->waiting_rcv_msgs_lock, |
3756 | flags); | ||
3756 | rv = handle_one_recv_msg(intf, smi_msg); | 3757 | rv = handle_one_recv_msg(intf, smi_msg); |
3757 | if (!run_to_completion) | 3758 | if (!run_to_completion) |
3758 | spin_lock_irqsave(&intf->waiting_msgs_lock, flags); | 3759 | spin_lock_irqsave(&intf->waiting_rcv_msgs_lock, flags); |
3759 | if (rv == 0) { | 3760 | if (rv == 0) { |
3760 | /* Message handled */ | 3761 | /* Message handled */ |
3761 | ipmi_free_smi_msg(smi_msg); | 3762 | ipmi_free_smi_msg(smi_msg); |
@@ -3766,12 +3767,12 @@ static void handle_new_recv_msgs(ipmi_smi_t intf) | |||
3766 | * To preserve message order, quit if we | 3767 | * To preserve message order, quit if we |
3767 | * can't handle a message. | 3768 | * can't handle a message. |
3768 | */ | 3769 | */ |
3769 | list_add(&smi_msg->link, &intf->waiting_msgs); | 3770 | list_add(&smi_msg->link, &intf->waiting_rcv_msgs); |
3770 | break; | 3771 | break; |
3771 | } | 3772 | } |
3772 | } | 3773 | } |
3773 | if (!run_to_completion) | 3774 | if (!run_to_completion) |
3774 | spin_unlock_irqrestore(&intf->waiting_msgs_lock, flags); | 3775 | spin_unlock_irqrestore(&intf->waiting_rcv_msgs_lock, flags); |
3775 | 3776 | ||
3776 | /* | 3777 | /* |
3777 | * If the pretimout count is non-zero, decrement one from it and | 3778 | * If the pretimout count is non-zero, decrement one from it and |
@@ -3852,10 +3853,10 @@ void ipmi_smi_msg_received(ipmi_smi_t intf, | |||
3852 | */ | 3853 | */ |
3853 | run_to_completion = intf->run_to_completion; | 3854 | run_to_completion = intf->run_to_completion; |
3854 | if (!run_to_completion) | 3855 | if (!run_to_completion) |
3855 | spin_lock_irqsave(&intf->waiting_msgs_lock, flags); | 3856 | spin_lock_irqsave(&intf->waiting_rcv_msgs_lock, flags); |
3856 | list_add_tail(&msg->link, &intf->waiting_msgs); | 3857 | list_add_tail(&msg->link, &intf->waiting_rcv_msgs); |
3857 | if (!run_to_completion) | 3858 | if (!run_to_completion) |
3858 | spin_unlock_irqrestore(&intf->waiting_msgs_lock, flags); | 3859 | spin_unlock_irqrestore(&intf->waiting_rcv_msgs_lock, flags); |
3859 | 3860 | ||
3860 | tasklet_schedule(&intf->recv_tasklet); | 3861 | tasklet_schedule(&intf->recv_tasklet); |
3861 | out: | 3862 | out: |