aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/char
diff options
context:
space:
mode:
authorDominik Brodowski <linux@dominikbrodowski.net>2010-07-29 10:33:23 -0400
committerDominik Brodowski <linux@dominikbrodowski.net>2010-09-29 11:20:22 -0400
commit37979e1546a790c44adbc7f27a85569944480ebc (patch)
tree18499b4d2890409c1cbe49cc1af97b57f4a2c906 /drivers/char
parentfc301101034c06bf56a7f71bf682c48909e401a4 (diff)
pcmcia: simplify IntType
IntType was only set to INT_MEMORY (driver pcmciamtd) or INT_MEMORY_AND_IO (all other drivers). As this flags seems to relate to ioport access, make it conditional to the driver having requested IO port access. There are two drivers which do not request IO ports, but did set INT_MEMORY_AND_IO: ray_cs and b43. For those, we consistently only set INT_MEMORY in future. CC: netdev@vger.kernel.org CC: linux-wireless@vger.kernel.org CC: linux-ide@vger.kernel.org CC: linux-usb@vger.kernel.org CC: laforge@gnumonks.org CC: linux-mtd@lists.infradead.org CC: alsa-devel@alsa-project.org CC: linux-serial@vger.kernel.org CC: Jiri Kosina <jkosina@suse.cz> CC: linux-scsi@vger.kernel.org Acked-by: Gustavo F. Padovan <padovan@profusion.mobi> (for drivers/bluetooth) Tested-by: Wolfram Sang <w.sang@pengutronix.de> Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
Diffstat (limited to 'drivers/char')
-rw-r--r--drivers/char/pcmcia/cm4000_cs.c3
-rw-r--r--drivers/char/pcmcia/cm4040_cs.c3
-rw-r--r--drivers/char/pcmcia/ipwireless/main.c1
-rw-r--r--drivers/char/pcmcia/synclink_cs.c2
4 files changed, 0 insertions, 9 deletions
diff --git a/drivers/char/pcmcia/cm4000_cs.c b/drivers/char/pcmcia/cm4000_cs.c
index ec73d9f6d9ed..d2accd64b3f5 100644
--- a/drivers/char/pcmcia/cm4000_cs.c
+++ b/drivers/char/pcmcia/cm4000_cs.c
@@ -1767,8 +1767,6 @@ static int cm4000_config(struct pcmcia_device * link, int devno)
1767 if (pcmcia_loop_config(link, cm4000_config_check, NULL)) 1767 if (pcmcia_loop_config(link, cm4000_config_check, NULL))
1768 goto cs_release; 1768 goto cs_release;
1769 1769
1770 link->conf.IntType = 00000002;
1771
1772 if (pcmcia_request_configuration(link, &link->conf)) 1770 if (pcmcia_request_configuration(link, &link->conf))
1773 goto cs_release; 1771 goto cs_release;
1774 1772
@@ -1829,7 +1827,6 @@ static int cm4000_probe(struct pcmcia_device *link)
1829 1827
1830 dev->p_dev = link; 1828 dev->p_dev = link;
1831 link->priv = dev; 1829 link->priv = dev;
1832 link->conf.IntType = INT_MEMORY_AND_IO;
1833 dev_table[i] = link; 1830 dev_table[i] = link;
1834 1831
1835 init_waitqueue_head(&dev->devq); 1832 init_waitqueue_head(&dev->devq);
diff --git a/drivers/char/pcmcia/cm4040_cs.c b/drivers/char/pcmcia/cm4040_cs.c
index 815cde1d0570..a32eba0afdfc 100644
--- a/drivers/char/pcmcia/cm4040_cs.c
+++ b/drivers/char/pcmcia/cm4040_cs.c
@@ -547,8 +547,6 @@ static int reader_config(struct pcmcia_device *link, int devno)
547 if (pcmcia_loop_config(link, cm4040_config_check, NULL)) 547 if (pcmcia_loop_config(link, cm4040_config_check, NULL))
548 goto cs_release; 548 goto cs_release;
549 549
550 link->conf.IntType = 00000002;
551
552 fail_rc = pcmcia_request_configuration(link, &link->conf); 550 fail_rc = pcmcia_request_configuration(link, &link->conf);
553 if (fail_rc != 0) { 551 if (fail_rc != 0) {
554 dev_printk(KERN_INFO, &link->dev, 552 dev_printk(KERN_INFO, &link->dev,
@@ -599,7 +597,6 @@ static int reader_probe(struct pcmcia_device *link)
599 link->priv = dev; 597 link->priv = dev;
600 dev->p_dev = link; 598 dev->p_dev = link;
601 599
602 link->conf.IntType = INT_MEMORY_AND_IO;
603 dev_table[i] = link; 600 dev_table[i] = link;
604 601
605 init_waitqueue_head(&dev->devq); 602 init_waitqueue_head(&dev->devq);
diff --git a/drivers/char/pcmcia/ipwireless/main.c b/drivers/char/pcmcia/ipwireless/main.c
index 8d2b86aab715..0f0be4df7b7c 100644
--- a/drivers/char/pcmcia/ipwireless/main.c
+++ b/drivers/char/pcmcia/ipwireless/main.c
@@ -173,7 +173,6 @@ static int config_ipwireless(struct ipw_dev *ipw)
173 return ret; 173 return ret;
174 174
175 link->conf.Attributes = CONF_ENABLE_IRQ; 175 link->conf.Attributes = CONF_ENABLE_IRQ;
176 link->conf.IntType = INT_MEMORY_AND_IO;
177 176
178 INIT_WORK(&ipw->work_reboot, signalled_reboot_work); 177 INIT_WORK(&ipw->work_reboot, signalled_reboot_work);
179 178
diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c
index 9ecd6bef5d3b..ba7ccf5701ed 100644
--- a/drivers/char/pcmcia/synclink_cs.c
+++ b/drivers/char/pcmcia/synclink_cs.c
@@ -551,7 +551,6 @@ static int mgslpc_probe(struct pcmcia_device *link)
551 /* Initialize the struct pcmcia_device structure */ 551 /* Initialize the struct pcmcia_device structure */
552 552
553 link->conf.Attributes = 0; 553 link->conf.Attributes = 0;
554 link->conf.IntType = INT_MEMORY_AND_IO;
555 554
556 ret = mgslpc_config(link); 555 ret = mgslpc_config(link);
557 if (ret) 556 if (ret)
@@ -595,7 +594,6 @@ static int mgslpc_config(struct pcmcia_device *link)
595 goto failed; 594 goto failed;
596 595
597 link->conf.Attributes = CONF_ENABLE_IRQ; 596 link->conf.Attributes = CONF_ENABLE_IRQ;
598 link->conf.IntType = INT_MEMORY_AND_IO;
599 link->conf.ConfigIndex = 8; 597 link->conf.ConfigIndex = 8;
600 link->conf.Present = PRESENT_OPTION; 598 link->conf.Present = PRESENT_OPTION;
601 599