drivers: use non-racy method for proc entries creation

Use proc_create()/proc_create_data() to make sure that ->proc_fops and ->data
be setup before gluing PDE to main tree.

Signed-off-by: Denis V. Lunev <den@openvz.org>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Dmitry Torokhov <dtor@mail.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

1 files changed, 2 insertions, 4 deletions

diff --git a/drivers/char/i8k.c b/drivers/char/i8k.c
index 8609b8236c67..f49037b744f9 100644
--- a/drivers/char/i8k.c
+++ b/drivers/char/i8k.c
@@ -82,6 +82,7 @@ static int i8k_ioctl(struct inode *, struct file *, unsigned int,
                      unsigned long);
 
 static const struct file_operations i8k_fops = {
+        .owner          = THIS_MODULE,
         .open           = i8k_open_fs,
         .read           = seq_read,
         .llseek         = seq_lseek,
@@ -554,13 +555,10 @@ static int __init i8k_init(void)
                 return -ENODEV;
 
         /* Register the proc entry */
-        proc_i8k = create_proc_entry("i8k", 0, NULL);
+        proc_i8k = proc_create("i8k", 0, NULL, &i8k_fops);
         if (!proc_i8k)
                 return -ENOENT;
 
-        proc_i8k->proc_fops = &i8k_fops;
-        proc_i8k->owner = THIS_MODULE;
-
         printk(KERN_INFO
                "Dell laptop SMM driver v%s Massimo Dal Zotto (dz@debian.org)\n",
                I8K_VERSION);