diff options
author | Boaz Harrosh <bharrosh@panasas.com> | 2007-06-20 07:53:23 -0400 |
---|---|---|
committer | Jens Axboe <jens.axboe@oracle.com> | 2007-07-10 02:03:34 -0400 |
commit | e654bc4393e85e326993256d80b9710a4d6411ff (patch) | |
tree | bf30413fd62f778e4c9abd8bc92e7a399ac37e53 /drivers/cdrom/cm206.c | |
parent | 9cff3b383dad193b0762c27278a16237e10b53dc (diff) |
[PATCH] fix request->cmd == INT cases
- I have unearthed very old bugs in stale drivers that still
used request->cmd as a READ|WRITE int
- This patch is maybe a proof that these drivers have not been
used for a long time. Should they be removed completely?
Drivers that currently do not work for sure:
drivers/acorn/block/fd1772.c | 2 +-
drivers/acorn/block/mfmhd.c | 8 ++++----
drivers/cdrom/aztcd.c | 2 +-
drivers/cdrom/cm206.c | 2 +-
drivers/cdrom/gscd.c | 2 +-
drivers/cdrom/mcdx.c | 2 +-
drivers/cdrom/optcd.c | 2 +-
drivers/cdrom/sjcd.c | 2 +-
Drivers with cosmetic fixes only:
b/drivers/block/amiflop.c
b/drivers/block/nbd.c
b/drivers/ide/legacy/hd.c
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Diffstat (limited to 'drivers/cdrom/cm206.c')
-rw-r--r-- | drivers/cdrom/cm206.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/cdrom/cm206.c b/drivers/cdrom/cm206.c index 230131163240..2f8fe3b6bbd0 100644 --- a/drivers/cdrom/cm206.c +++ b/drivers/cdrom/cm206.c | |||
@@ -851,7 +851,7 @@ static void do_cm206_request(request_queue_t * q) | |||
851 | if (!req) | 851 | if (!req) |
852 | return; | 852 | return; |
853 | 853 | ||
854 | if (req->cmd != READ) { | 854 | if (rq_data_dir(req) != READ) { |
855 | debug(("Non-read command %d on cdrom\n", req->cmd)); | 855 | debug(("Non-read command %d on cdrom\n", req->cmd)); |
856 | end_request(req, 0); | 856 | end_request(req, 0); |
857 | continue; | 857 | continue; |