diff options
| author | Roger Pau Monne <roger.pau@citrix.com> | 2014-02-04 05:26:15 -0500 |
|---|---|---|
| committer | Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> | 2014-02-07 13:03:53 -0500 |
| commit | 80bfa2f6e2e81049fc6cd3bfaeedcb64db3a9ba6 (patch) | |
| tree | 8f0ac299cbc57192b2cf23de645799fc1b879b4c /drivers/block | |
| parent | c05f3e3c85df1d89673e00cee7ece5ae4eb4c6ec (diff) | |
xen-blkif: drop struct blkif_request_segment_aligned
This was wrongly introduced in commit 402b27f9, the only difference
between blkif_request_segment_aligned and blkif_request_segment is
that the former has a named padding, while both share the same
memory layout.
Also correct a few minor glitches in the description, including for it
to no longer assume PAGE_SIZE == 4096.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
[Description fix by Jan Beulich]
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reported-by: Jan Beulich <jbeulich@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: David Vrabel <david.vrabel@citrix.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Tested-by: Matt Rushton <mrushton@amazon.com>
Cc: Matt Wilson <msw@amazon.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Diffstat (limited to 'drivers/block')
| -rw-r--r-- | drivers/block/xen-blkback/blkback.c | 2 | ||||
| -rw-r--r-- | drivers/block/xen-blkback/common.h | 2 | ||||
| -rw-r--r-- | drivers/block/xen-blkfront.c | 6 |
3 files changed, 5 insertions, 5 deletions
diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c index 394fa2eabf87..e612627ae981 100644 --- a/drivers/block/xen-blkback/blkback.c +++ b/drivers/block/xen-blkback/blkback.c | |||
| @@ -847,7 +847,7 @@ static int xen_blkbk_parse_indirect(struct blkif_request *req, | |||
| 847 | struct grant_page **pages = pending_req->indirect_pages; | 847 | struct grant_page **pages = pending_req->indirect_pages; |
| 848 | struct xen_blkif *blkif = pending_req->blkif; | 848 | struct xen_blkif *blkif = pending_req->blkif; |
| 849 | int indirect_grefs, rc, n, nseg, i; | 849 | int indirect_grefs, rc, n, nseg, i; |
| 850 | struct blkif_request_segment_aligned *segments = NULL; | 850 | struct blkif_request_segment *segments = NULL; |
| 851 | 851 | ||
| 852 | nseg = pending_req->nr_pages; | 852 | nseg = pending_req->nr_pages; |
| 853 | indirect_grefs = INDIRECT_PAGES(nseg); | 853 | indirect_grefs = INDIRECT_PAGES(nseg); |
diff --git a/drivers/block/xen-blkback/common.h b/drivers/block/xen-blkback/common.h index e40326a7f707..9eb34e24b4fe 100644 --- a/drivers/block/xen-blkback/common.h +++ b/drivers/block/xen-blkback/common.h | |||
| @@ -57,7 +57,7 @@ | |||
| 57 | #define MAX_INDIRECT_SEGMENTS 256 | 57 | #define MAX_INDIRECT_SEGMENTS 256 |
| 58 | 58 | ||
| 59 | #define SEGS_PER_INDIRECT_FRAME \ | 59 | #define SEGS_PER_INDIRECT_FRAME \ |
| 60 | (PAGE_SIZE/sizeof(struct blkif_request_segment_aligned)) | 60 | (PAGE_SIZE/sizeof(struct blkif_request_segment)) |
| 61 | #define MAX_INDIRECT_PAGES \ | 61 | #define MAX_INDIRECT_PAGES \ |
| 62 | ((MAX_INDIRECT_SEGMENTS + SEGS_PER_INDIRECT_FRAME - 1)/SEGS_PER_INDIRECT_FRAME) | 62 | ((MAX_INDIRECT_SEGMENTS + SEGS_PER_INDIRECT_FRAME - 1)/SEGS_PER_INDIRECT_FRAME) |
| 63 | #define INDIRECT_PAGES(_segs) \ | 63 | #define INDIRECT_PAGES(_segs) \ |
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index c4a4c9006288..7d09dfc9735c 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c | |||
| @@ -162,7 +162,7 @@ static DEFINE_SPINLOCK(minor_lock); | |||
| 162 | #define DEV_NAME "xvd" /* name in /dev */ | 162 | #define DEV_NAME "xvd" /* name in /dev */ |
| 163 | 163 | ||
| 164 | #define SEGS_PER_INDIRECT_FRAME \ | 164 | #define SEGS_PER_INDIRECT_FRAME \ |
| 165 | (PAGE_SIZE/sizeof(struct blkif_request_segment_aligned)) | 165 | (PAGE_SIZE/sizeof(struct blkif_request_segment)) |
| 166 | #define INDIRECT_GREFS(_segs) \ | 166 | #define INDIRECT_GREFS(_segs) \ |
| 167 | ((_segs + SEGS_PER_INDIRECT_FRAME - 1)/SEGS_PER_INDIRECT_FRAME) | 167 | ((_segs + SEGS_PER_INDIRECT_FRAME - 1)/SEGS_PER_INDIRECT_FRAME) |
| 168 | 168 | ||
| @@ -393,7 +393,7 @@ static int blkif_queue_request(struct request *req) | |||
| 393 | unsigned long id; | 393 | unsigned long id; |
| 394 | unsigned int fsect, lsect; | 394 | unsigned int fsect, lsect; |
| 395 | int i, ref, n; | 395 | int i, ref, n; |
| 396 | struct blkif_request_segment_aligned *segments = NULL; | 396 | struct blkif_request_segment *segments = NULL; |
| 397 | 397 | ||
| 398 | /* | 398 | /* |
| 399 | * Used to store if we are able to queue the request by just using | 399 | * Used to store if we are able to queue the request by just using |
| @@ -550,7 +550,7 @@ static int blkif_queue_request(struct request *req) | |||
| 550 | } else { | 550 | } else { |
| 551 | n = i % SEGS_PER_INDIRECT_FRAME; | 551 | n = i % SEGS_PER_INDIRECT_FRAME; |
| 552 | segments[n] = | 552 | segments[n] = |
| 553 | (struct blkif_request_segment_aligned) { | 553 | (struct blkif_request_segment) { |
| 554 | .gref = ref, | 554 | .gref = ref, |
| 555 | .first_sect = fsect, | 555 | .first_sect = fsect, |
| 556 | .last_sect = lsect }; | 556 | .last_sect = lsect }; |
