diff options
author | Joe Perches <joe@perches.com> | 2014-08-08 17:24:12 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-08-08 18:57:28 -0400 |
commit | a5bbf6160c2b5ebce1533bf989c7cd0086beeabf (patch) | |
tree | e5cd27f2ed429404c5a394734c221cb06c37e5aa /drivers/block/skd_main.c | |
parent | 6f2a011afc324260d8e5e2aa480a58c34283c581 (diff) |
block: use pci_zalloc_consistent
Remove the now unnecessary memset too.
Signed-off-by: Joe Perches <joe@perches.com>
Mike Miller <mike.miller@hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/block/skd_main.c')
-rw-r--r-- | drivers/block/skd_main.c | 25 |
1 files changed, 9 insertions, 16 deletions
diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c index 608532d3f8c9..f0a089df85cc 100644 --- a/drivers/block/skd_main.c +++ b/drivers/block/skd_main.c | |||
@@ -4112,16 +4112,14 @@ static int skd_cons_skcomp(struct skd_device *skdev) | |||
4112 | skdev->name, __func__, __LINE__, | 4112 | skdev->name, __func__, __LINE__, |
4113 | nbytes, SKD_N_COMPLETION_ENTRY); | 4113 | nbytes, SKD_N_COMPLETION_ENTRY); |
4114 | 4114 | ||
4115 | skcomp = pci_alloc_consistent(skdev->pdev, nbytes, | 4115 | skcomp = pci_zalloc_consistent(skdev->pdev, nbytes, |
4116 | &skdev->cq_dma_address); | 4116 | &skdev->cq_dma_address); |
4117 | 4117 | ||
4118 | if (skcomp == NULL) { | 4118 | if (skcomp == NULL) { |
4119 | rc = -ENOMEM; | 4119 | rc = -ENOMEM; |
4120 | goto err_out; | 4120 | goto err_out; |
4121 | } | 4121 | } |
4122 | 4122 | ||
4123 | memset(skcomp, 0, nbytes); | ||
4124 | |||
4125 | skdev->skcomp_table = skcomp; | 4123 | skdev->skcomp_table = skcomp; |
4126 | skdev->skerr_table = (struct fit_comp_error_info *)((char *)skcomp + | 4124 | skdev->skerr_table = (struct fit_comp_error_info *)((char *)skcomp + |
4127 | sizeof(*skcomp) * | 4125 | sizeof(*skcomp) * |
@@ -4304,15 +4302,14 @@ static int skd_cons_skspcl(struct skd_device *skdev) | |||
4304 | 4302 | ||
4305 | nbytes = SKD_N_SPECIAL_FITMSG_BYTES; | 4303 | nbytes = SKD_N_SPECIAL_FITMSG_BYTES; |
4306 | 4304 | ||
4307 | skspcl->msg_buf = pci_alloc_consistent(skdev->pdev, nbytes, | 4305 | skspcl->msg_buf = |
4308 | &skspcl->mb_dma_address); | 4306 | pci_zalloc_consistent(skdev->pdev, nbytes, |
4307 | &skspcl->mb_dma_address); | ||
4309 | if (skspcl->msg_buf == NULL) { | 4308 | if (skspcl->msg_buf == NULL) { |
4310 | rc = -ENOMEM; | 4309 | rc = -ENOMEM; |
4311 | goto err_out; | 4310 | goto err_out; |
4312 | } | 4311 | } |
4313 | 4312 | ||
4314 | memset(skspcl->msg_buf, 0, nbytes); | ||
4315 | |||
4316 | skspcl->req.sg = kzalloc(sizeof(struct scatterlist) * | 4313 | skspcl->req.sg = kzalloc(sizeof(struct scatterlist) * |
4317 | SKD_N_SG_PER_SPECIAL, GFP_KERNEL); | 4314 | SKD_N_SG_PER_SPECIAL, GFP_KERNEL); |
4318 | if (skspcl->req.sg == NULL) { | 4315 | if (skspcl->req.sg == NULL) { |
@@ -4353,25 +4350,21 @@ static int skd_cons_sksb(struct skd_device *skdev) | |||
4353 | 4350 | ||
4354 | nbytes = SKD_N_INTERNAL_BYTES; | 4351 | nbytes = SKD_N_INTERNAL_BYTES; |
4355 | 4352 | ||
4356 | skspcl->data_buf = pci_alloc_consistent(skdev->pdev, nbytes, | 4353 | skspcl->data_buf = pci_zalloc_consistent(skdev->pdev, nbytes, |
4357 | &skspcl->db_dma_address); | 4354 | &skspcl->db_dma_address); |
4358 | if (skspcl->data_buf == NULL) { | 4355 | if (skspcl->data_buf == NULL) { |
4359 | rc = -ENOMEM; | 4356 | rc = -ENOMEM; |
4360 | goto err_out; | 4357 | goto err_out; |
4361 | } | 4358 | } |
4362 | 4359 | ||
4363 | memset(skspcl->data_buf, 0, nbytes); | ||
4364 | |||
4365 | nbytes = SKD_N_SPECIAL_FITMSG_BYTES; | 4360 | nbytes = SKD_N_SPECIAL_FITMSG_BYTES; |
4366 | skspcl->msg_buf = pci_alloc_consistent(skdev->pdev, nbytes, | 4361 | skspcl->msg_buf = pci_zalloc_consistent(skdev->pdev, nbytes, |
4367 | &skspcl->mb_dma_address); | 4362 | &skspcl->mb_dma_address); |
4368 | if (skspcl->msg_buf == NULL) { | 4363 | if (skspcl->msg_buf == NULL) { |
4369 | rc = -ENOMEM; | 4364 | rc = -ENOMEM; |
4370 | goto err_out; | 4365 | goto err_out; |
4371 | } | 4366 | } |
4372 | 4367 | ||
4373 | memset(skspcl->msg_buf, 0, nbytes); | ||
4374 | |||
4375 | skspcl->req.sksg_list = skd_cons_sg_list(skdev, 1, | 4368 | skspcl->req.sksg_list = skd_cons_sg_list(skdev, 1, |
4376 | &skspcl->req.sksg_dma_address); | 4369 | &skspcl->req.sksg_dma_address); |
4377 | if (skspcl->req.sksg_list == NULL) { | 4370 | if (skspcl->req.sksg_list == NULL) { |