diff options
| author | Roel Kluin <roel.kluin@gmail.com> | 2010-03-11 17:09:47 -0500 |
|---|---|---|
| committer | Jens Axboe <jens.axboe@oracle.com> | 2010-03-12 04:03:42 -0500 |
| commit | c12ec0a2d94001003dfb929ce14c287fca0522b0 (patch) | |
| tree | fd901e7114ddc7e1c7905ad768b982b6ff17ef66 /drivers/block/paride | |
| parent | 39ad2bbb5900d1bc9ae8f06cebb4cb2529d9e42e (diff) | |
paride: fix off-by-one test
With `while (j++ < PX_SPIN)' j reaches PX_SPIN + 1 after the loop. This
is probably unlikely to produce a problem.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Diffstat (limited to 'drivers/block/paride')
| -rw-r--r-- | drivers/block/paride/pcd.c | 4 | ||||
| -rw-r--r-- | drivers/block/paride/pf.c | 4 | ||||
| -rw-r--r-- | drivers/block/paride/pt.c | 4 |
3 files changed, 6 insertions, 6 deletions
diff --git a/drivers/block/paride/pcd.c b/drivers/block/paride/pcd.c index 8866ca369d5e..71acf4e53356 100644 --- a/drivers/block/paride/pcd.c +++ b/drivers/block/paride/pcd.c | |||
| @@ -341,11 +341,11 @@ static int pcd_wait(struct pcd_unit *cd, int go, int stop, char *fun, char *msg) | |||
| 341 | && (j++ < PCD_SPIN)) | 341 | && (j++ < PCD_SPIN)) |
| 342 | udelay(PCD_DELAY); | 342 | udelay(PCD_DELAY); |
| 343 | 343 | ||
| 344 | if ((r & (IDE_ERR & stop)) || (j >= PCD_SPIN)) { | 344 | if ((r & (IDE_ERR & stop)) || (j > PCD_SPIN)) { |
| 345 | s = read_reg(cd, 7); | 345 | s = read_reg(cd, 7); |
| 346 | e = read_reg(cd, 1); | 346 | e = read_reg(cd, 1); |
| 347 | p = read_reg(cd, 2); | 347 | p = read_reg(cd, 2); |
| 348 | if (j >= PCD_SPIN) | 348 | if (j > PCD_SPIN) |
| 349 | e |= 0x100; | 349 | e |= 0x100; |
| 350 | if (fun) | 350 | if (fun) |
| 351 | printk("%s: %s %s: alt=0x%x stat=0x%x err=0x%x" | 351 | printk("%s: %s %s: alt=0x%x stat=0x%x err=0x%x" |
diff --git a/drivers/block/paride/pf.c b/drivers/block/paride/pf.c index ddb4f9abd480..c059aab3006b 100644 --- a/drivers/block/paride/pf.c +++ b/drivers/block/paride/pf.c | |||
| @@ -391,11 +391,11 @@ static int pf_wait(struct pf_unit *pf, int go, int stop, char *fun, char *msg) | |||
| 391 | && (j++ < PF_SPIN)) | 391 | && (j++ < PF_SPIN)) |
| 392 | udelay(PF_SPIN_DEL); | 392 | udelay(PF_SPIN_DEL); |
| 393 | 393 | ||
| 394 | if ((r & (STAT_ERR & stop)) || (j >= PF_SPIN)) { | 394 | if ((r & (STAT_ERR & stop)) || (j > PF_SPIN)) { |
| 395 | s = read_reg(pf, 7); | 395 | s = read_reg(pf, 7); |
| 396 | e = read_reg(pf, 1); | 396 | e = read_reg(pf, 1); |
| 397 | p = read_reg(pf, 2); | 397 | p = read_reg(pf, 2); |
| 398 | if (j >= PF_SPIN) | 398 | if (j > PF_SPIN) |
| 399 | e |= 0x100; | 399 | e |= 0x100; |
| 400 | if (fun) | 400 | if (fun) |
| 401 | printk("%s: %s %s: alt=0x%x stat=0x%x err=0x%x" | 401 | printk("%s: %s %s: alt=0x%x stat=0x%x err=0x%x" |
diff --git a/drivers/block/paride/pt.c b/drivers/block/paride/pt.c index 1e4006e18f03..bc5825fdeaab 100644 --- a/drivers/block/paride/pt.c +++ b/drivers/block/paride/pt.c | |||
| @@ -274,11 +274,11 @@ static int pt_wait(struct pt_unit *tape, int go, int stop, char *fun, char *msg) | |||
| 274 | && (j++ < PT_SPIN)) | 274 | && (j++ < PT_SPIN)) |
| 275 | udelay(PT_SPIN_DEL); | 275 | udelay(PT_SPIN_DEL); |
| 276 | 276 | ||
| 277 | if ((r & (STAT_ERR & stop)) || (j >= PT_SPIN)) { | 277 | if ((r & (STAT_ERR & stop)) || (j > PT_SPIN)) { |
| 278 | s = read_reg(pi, 7); | 278 | s = read_reg(pi, 7); |
| 279 | e = read_reg(pi, 1); | 279 | e = read_reg(pi, 1); |
| 280 | p = read_reg(pi, 2); | 280 | p = read_reg(pi, 2); |
| 281 | if (j >= PT_SPIN) | 281 | if (j > PT_SPIN) |
| 282 | e |= 0x100; | 282 | e |= 0x100; |
| 283 | if (fun) | 283 | if (fun) |
| 284 | printk("%s: %s %s: alt=0x%x stat=0x%x err=0x%x" | 284 | printk("%s: %s %s: alt=0x%x stat=0x%x err=0x%x" |
