diff options
| author | Rusty Russell <rusty@rustcorp.com.au> | 2012-01-12 18:02:20 -0500 |
|---|---|---|
| committer | Rusty Russell <rusty@rustcorp.com.au> | 2012-01-12 18:02:20 -0500 |
| commit | 90ab5ee94171b3e28de6bb42ee30b527014e0be7 (patch) | |
| tree | fcf89889f6e881f2b231d3d20287c08174ce4b54 /drivers/block/paride | |
| parent | 476bc0015bf09dad39d36a8b19f76f0c181d1ec9 (diff) | |
module_param: make bool parameters really bool (drivers & misc)
module_param(bool) used to counter-intuitively take an int. In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.
It's time to remove the int/unsigned int option. For this version
it'll simply give a warning, but it'll break next kernel version.
Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'drivers/block/paride')
| -rw-r--r-- | drivers/block/paride/bpck6.c | 5 | ||||
| -rw-r--r-- | drivers/block/paride/pd.c | 3 | ||||
| -rw-r--r-- | drivers/block/paride/pf.c | 4 | ||||
| -rw-r--r-- | drivers/block/paride/pg.c | 3 | ||||
| -rw-r--r-- | drivers/block/paride/pt.c | 4 |
5 files changed, 12 insertions, 7 deletions
diff --git a/drivers/block/paride/bpck6.c b/drivers/block/paride/bpck6.c index ad124525ac23..ec64e7f5d1ce 100644 --- a/drivers/block/paride/bpck6.c +++ b/drivers/block/paride/bpck6.c | |||
| @@ -20,9 +20,6 @@ | |||
| 20 | */ | 20 | */ |
| 21 | 21 | ||
| 22 | 22 | ||
| 23 | /* PARAMETERS */ | ||
| 24 | static int verbose; /* set this to 1 to see debugging messages and whatnot */ | ||
| 25 | |||
| 26 | #define BACKPACK_VERSION "2.0.2" | 23 | #define BACKPACK_VERSION "2.0.2" |
| 27 | 24 | ||
| 28 | #include <linux/module.h> | 25 | #include <linux/module.h> |
| @@ -36,6 +33,8 @@ static int verbose; /* set this to 1 to see debugging messages and whatnot */ | |||
| 36 | #include "ppc6lnx.c" | 33 | #include "ppc6lnx.c" |
| 37 | #include "paride.h" | 34 | #include "paride.h" |
| 38 | 35 | ||
| 36 | /* PARAMETERS */ | ||
| 37 | static bool verbose; /* set this to 1 to see debugging messages and whatnot */ | ||
| 39 | 38 | ||
| 40 | 39 | ||
| 41 | #define PPCSTRUCT(pi) ((Interface *)(pi->private)) | 40 | #define PPCSTRUCT(pi) ((Interface *)(pi->private)) |
diff --git a/drivers/block/paride/pd.c b/drivers/block/paride/pd.c index 869e7676d46f..831e3ac156e6 100644 --- a/drivers/block/paride/pd.c +++ b/drivers/block/paride/pd.c | |||
| @@ -124,8 +124,9 @@ | |||
| 124 | by default. | 124 | by default. |
| 125 | 125 | ||
| 126 | */ | 126 | */ |
| 127 | #include <linux/types.h> | ||
| 127 | 128 | ||
| 128 | static int verbose = 0; | 129 | static bool verbose = 0; |
| 129 | static int major = PD_MAJOR; | 130 | static int major = PD_MAJOR; |
| 130 | static char *name = PD_NAME; | 131 | static char *name = PD_NAME; |
| 131 | static int cluster = 64; | 132 | static int cluster = 64; |
diff --git a/drivers/block/paride/pf.c b/drivers/block/paride/pf.c index f21b520ef419..ec8f9ed6326e 100644 --- a/drivers/block/paride/pf.c +++ b/drivers/block/paride/pf.c | |||
| @@ -118,13 +118,15 @@ | |||
| 118 | #define PF_NAME "pf" | 118 | #define PF_NAME "pf" |
| 119 | #define PF_UNITS 4 | 119 | #define PF_UNITS 4 |
| 120 | 120 | ||
| 121 | #include <linux/types.h> | ||
| 122 | |||
| 121 | /* Here are things one can override from the insmod command. | 123 | /* Here are things one can override from the insmod command. |
| 122 | Most are autoprobed by paride unless set here. Verbose is off | 124 | Most are autoprobed by paride unless set here. Verbose is off |
| 123 | by default. | 125 | by default. |
| 124 | 126 | ||
| 125 | */ | 127 | */ |
| 126 | 128 | ||
| 127 | static int verbose = 0; | 129 | static bool verbose = 0; |
| 128 | static int major = PF_MAJOR; | 130 | static int major = PF_MAJOR; |
| 129 | static char *name = PF_NAME; | 131 | static char *name = PF_NAME; |
| 130 | static int cluster = 64; | 132 | static int cluster = 64; |
diff --git a/drivers/block/paride/pg.c b/drivers/block/paride/pg.c index a79fb4f7ff62..4a27b1de5fcb 100644 --- a/drivers/block/paride/pg.c +++ b/drivers/block/paride/pg.c | |||
| @@ -130,13 +130,14 @@ | |||
| 130 | #define PI_PG 4 | 130 | #define PI_PG 4 |
| 131 | #endif | 131 | #endif |
| 132 | 132 | ||
| 133 | #include <linux/types.h> | ||
| 133 | /* Here are things one can override from the insmod command. | 134 | /* Here are things one can override from the insmod command. |
| 134 | Most are autoprobed by paride unless set here. Verbose is 0 | 135 | Most are autoprobed by paride unless set here. Verbose is 0 |
| 135 | by default. | 136 | by default. |
| 136 | 137 | ||
| 137 | */ | 138 | */ |
| 138 | 139 | ||
| 139 | static int verbose = 0; | 140 | static bool verbose = 0; |
| 140 | static int major = PG_MAJOR; | 141 | static int major = PG_MAJOR; |
| 141 | static char *name = PG_NAME; | 142 | static char *name = PG_NAME; |
| 142 | static int disable = 0; | 143 | static int disable = 0; |
diff --git a/drivers/block/paride/pt.c b/drivers/block/paride/pt.c index 7179f79d7468..2596042eb987 100644 --- a/drivers/block/paride/pt.c +++ b/drivers/block/paride/pt.c | |||
| @@ -109,13 +109,15 @@ | |||
| 109 | #define PT_NAME "pt" | 109 | #define PT_NAME "pt" |
| 110 | #define PT_UNITS 4 | 110 | #define PT_UNITS 4 |
| 111 | 111 | ||
| 112 | #include <linux/types.h> | ||
| 113 | |||
| 112 | /* Here are things one can override from the insmod command. | 114 | /* Here are things one can override from the insmod command. |
| 113 | Most are autoprobed by paride unless set here. Verbose is on | 115 | Most are autoprobed by paride unless set here. Verbose is on |
| 114 | by default. | 116 | by default. |
| 115 | 117 | ||
| 116 | */ | 118 | */ |
| 117 | 119 | ||
| 118 | static int verbose = 0; | 120 | static bool verbose = 0; |
| 119 | static int major = PT_MAJOR; | 121 | static int major = PT_MAJOR; |
| 120 | static char *name = PT_NAME; | 122 | static char *name = PT_NAME; |
| 121 | static int disable = 0; | 123 | static int disable = 0; |
