diff options
author | Philipp Reisner <philipp.reisner@linbit.com> | 2012-08-28 10:48:03 -0400 |
---|---|---|
committer | Philipp Reisner <philipp.reisner@linbit.com> | 2012-11-09 08:11:08 -0500 |
commit | 19fffd7b0303e8843aa2decfd43fa57c9d511409 (patch) | |
tree | 19ac111fafeec46eac2b0e8cee4f41f4327a1129 /drivers/block/drbd/drbd_nl.c | |
parent | d76440181d0e05826f228189b74b4dbf64b68981 (diff) |
drbd: Call drbd_md_sync() explicitly after a state change on the connection
Without this, the meta-data gets updates after 5 seconds by the
md_sync_timer. Better to do it immeditaly after a state change.
If the asender detects a network failure, it may take a bit until
the worker processes the according after-conn-state-change work item.
The worker might be blocked in sending something, i.e. it
takes until it gets into its timeout. That is 6 seconds by
default which is longer than the 5 seconds of the md_sync_timer.
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Diffstat (limited to 'drivers/block/drbd/drbd_nl.c')
-rw-r--r-- | drivers/block/drbd/drbd_nl.c | 16 |
1 files changed, 0 insertions, 16 deletions
diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c index 363034a77e88..476491ffdabc 100644 --- a/drivers/block/drbd/drbd_nl.c +++ b/drivers/block/drbd/drbd_nl.c | |||
@@ -363,22 +363,6 @@ int drbd_khelper(struct drbd_conf *mdev, char *cmd) | |||
363 | return ret; | 363 | return ret; |
364 | } | 364 | } |
365 | 365 | ||
366 | static void conn_md_sync(struct drbd_tconn *tconn) | ||
367 | { | ||
368 | struct drbd_conf *mdev; | ||
369 | int vnr; | ||
370 | |||
371 | rcu_read_lock(); | ||
372 | idr_for_each_entry(&tconn->volumes, mdev, vnr) { | ||
373 | kref_get(&mdev->kref); | ||
374 | rcu_read_unlock(); | ||
375 | drbd_md_sync(mdev); | ||
376 | kref_put(&mdev->kref, &drbd_minor_destroy); | ||
377 | rcu_read_lock(); | ||
378 | } | ||
379 | rcu_read_unlock(); | ||
380 | } | ||
381 | |||
382 | int conn_khelper(struct drbd_tconn *tconn, char *cmd) | 366 | int conn_khelper(struct drbd_tconn *tconn, char *cmd) |
383 | { | 367 | { |
384 | char *envp[] = { "HOME=/", | 368 | char *envp[] = { "HOME=/", |