driver core: bus_type: add drv_groups

attribute groups are much more flexible than just a list of attributes,
due to their support for visibility of the attributes, and binary
attributes. Add drv_groups to struct bus_type which should be used
instead of drv_attrs.

drv_attrs will be removed from the structure soon.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

3 files changed, 14 insertions, 4 deletions

diff --git a/drivers/base/base.h b/drivers/base/base.h
index fccf954f82fd..2cbc6774f4cd 100644
--- a/drivers/base/base.h
+++ b/drivers/base/base.h
@@ -119,6 +119,11 @@ static inline int driver_match_device(struct device_driver *drv,
         return drv->bus->match ? drv->bus->match(dev, drv) : 1;
 }
 
+extern int driver_add_groups(struct device_driver *drv,
+                             const struct attribute_group **groups);
+extern void driver_remove_groups(struct device_driver *drv,
+                                 const struct attribute_group **groups);
+
 extern int device_add_groups(struct device *dev,
                              const struct attribute_group **groups);
 extern void device_remove_groups(struct device *dev,
diff --git a/drivers/base/bus.c b/drivers/base/bus.c
index 7b2dc5ba7d79..de5ce22df306 100644
--- a/drivers/base/bus.c
+++ b/drivers/base/bus.c
@@ -725,6 +725,10 @@ int bus_add_driver(struct device_driver *drv)
                 printk(KERN_ERR "%s: driver_add_attrs(%s) failed\n",
                         __func__, drv->name);
         }
+        error = driver_add_groups(drv, bus->drv_groups);
+        if (error)
+                printk(KERN_ERR "%s: driver_create_groups(%s) failed\n",
+                        __func__, drv->name);
 
         if (!drv->suppress_bind_attrs) {
                 error = add_bind_files(drv);
@@ -762,6 +766,7 @@ void bus_remove_driver(struct device_driver *drv)
         if (!drv->suppress_bind_attrs)
                 remove_bind_files(drv);
         driver_remove_attrs(drv->bus, drv);
+        driver_remove_groups(drv, drv->bus->drv_groups);
         driver_remove_file(drv, &driver_attr_uevent);
         klist_remove(&drv->p->knode_bus);
         pr_debug("bus: '%s': remove driver %s\n", drv->bus->name, drv->name);
diff --git a/drivers/base/driver.c b/drivers/base/driver.c
index 974e301a1ef0..89db726ebb98 100644
--- a/drivers/base/driver.c
+++ b/drivers/base/driver.c
@@ -123,8 +123,8 @@ void driver_remove_file(struct device_driver *drv,
 }
 EXPORT_SYMBOL_GPL(driver_remove_file);
 
-static int driver_add_groups(struct device_driver *drv,
-                             const struct attribute_group **groups)
+int driver_add_groups(struct device_driver *drv,
+                      const struct attribute_group **groups)
 {
         int error = 0;
         int i;
@@ -143,8 +143,8 @@ static int driver_add_groups(struct device_driver *drv,
         return error;
 }
 
-static void driver_remove_groups(struct device_driver *drv,
-                                 const struct attribute_group **groups)
+void driver_remove_groups(struct device_driver *drv,
+                          const struct attribute_group **groups)
 {
         int i;