regmap: Fix memory leak in regcache_init error path

Make sure all allocated memory gets freed again in case initializing the cache
failed.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

1 files changed, 10 insertions, 1 deletions

diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c
index 79446262812c..27fae58ff4cb 100644
--- a/drivers/base/regmap/regcache.c
+++ b/drivers/base/regmap/regcache.c
@@ -144,9 +144,18 @@ int regcache_init(struct regmap *map)
         if (map->cache_ops->init) {
                 dev_dbg(map->dev, "Initializing %s cache\n",
                         map->cache_ops->name);
-                return map->cache_ops->init(map);
+                ret = map->cache_ops->init(map);
+                if (ret)
+                        goto err_free;
         }
         return 0;
+
+err_free:
+        kfree(map->reg_defaults);
+        if (map->cache_free)
+                kfree(map->reg_defaults_raw);
+
+        return ret;
 }
 
 void regcache_exit(struct regmap *map)