aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/base
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2010-06-26 21:02:34 -0400
committerDavid S. Miller <davem@davemloft.net>2010-07-04 13:40:17 -0400
commit99bcf217183e02ebae46373896fba7f12d588001 (patch)
tree03210a8c57e33b2b5073f80f9a7f818c84f4c83a /drivers/base
parent7db6f5fb65a82af03229eef104dc9899c5eecf33 (diff)
device.h drivers/base/core.c Convert dev_<level> logging macros to functions
Reduces an x86 defconfig text and data ~55k, .6% smaller. $ size vmlinux* text data bss dec hex filename 7205273 716016 1366288 9287577 8db799 vmlinux 7258890 719768 1366288 9344946 8e97b2 vmlinux.master Uses %pV and struct va_format Format arguments are verified before printk The dev_info macro is converted to _dev_info because there are existing uses of variables named dev_info in the kernel tree like drivers/net/pcmcia/pcnet_cs.c A dev_info macro is created to call _dev_info Signed-off-by: Joe Perches <joe@perches.com> Acked-by: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/base')
-rw-r--r--drivers/base/core.c64
1 files changed, 64 insertions, 0 deletions
diff --git a/drivers/base/core.c b/drivers/base/core.c
index 9630fbdf4e6c..38bbbd029306 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -1819,3 +1819,67 @@ void device_shutdown(void)
1819 spin_unlock(&devices_kset->list_lock); 1819 spin_unlock(&devices_kset->list_lock);
1820 async_synchronize_full(); 1820 async_synchronize_full();
1821} 1821}
1822
1823/*
1824 * Device logging functions
1825 */
1826
1827#ifdef CONFIG_PRINTK
1828
1829static int __dev_printk(const char *level, const struct device *dev,
1830 struct va_format *vaf)
1831{
1832 if (!dev)
1833 return printk("%s(NULL device *): %pV", level, vaf);
1834
1835 return printk("%s%s %s: %pV",
1836 level, dev_driver_string(dev), dev_name(dev), vaf);
1837}
1838
1839int dev_printk(const char *level, const struct device *dev,
1840 const char *fmt, ...)
1841{
1842 struct va_format vaf;
1843 va_list args;
1844 int r;
1845
1846 va_start(args, fmt);
1847
1848 vaf.fmt = fmt;
1849 vaf.va = &args;
1850
1851 r = __dev_printk(level, dev, &vaf);
1852 va_end(args);
1853
1854 return r;
1855}
1856EXPORT_SYMBOL(dev_printk);
1857
1858#define define_dev_printk_level(func, kern_level) \
1859int func(const struct device *dev, const char *fmt, ...) \
1860{ \
1861 struct va_format vaf; \
1862 va_list args; \
1863 int r; \
1864 \
1865 va_start(args, fmt); \
1866 \
1867 vaf.fmt = fmt; \
1868 vaf.va = &args; \
1869 \
1870 r = __dev_printk(kern_level, dev, &vaf); \
1871 va_end(args); \
1872 \
1873 return r; \
1874} \
1875EXPORT_SYMBOL(func);
1876
1877define_dev_printk_level(dev_emerg, KERN_EMERG);
1878define_dev_printk_level(dev_alert, KERN_ALERT);
1879define_dev_printk_level(dev_crit, KERN_CRIT);
1880define_dev_printk_level(dev_err, KERN_ERR);
1881define_dev_printk_level(dev_warn, KERN_WARNING);
1882define_dev_printk_level(dev_notice, KERN_NOTICE);
1883define_dev_printk_level(_dev_info, KERN_INFO);
1884
1885#endif