aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/base/platform.c
diff options
context:
space:
mode:
authorJosh Cartwright <joshc@codeaurora.org>2014-02-13 23:00:43 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-02-14 17:06:16 -0500
commit9383f4c6b66256c039c65ddc141f0caeeae51847 (patch)
tree1ee2921eb241f744ea73a13918aa0050541631f4 /drivers/base/platform.c
parenta8fa94e0f2ab665f9aa665195618178b61ed8304 (diff)
ACPI / platform: drop redundant ACPI_HANDLE check
The acpi_dev_pm_attach/_detach functions perform their own checks to ensure the device has an ACPI companion. It is not necessary for the caller to do so. This mirrors what other busses with ACPI dev PM support do (i2c, spi, sdio). Cc: Len Brown <lenb@kernel.org> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Josh Cartwright <joshc@codeaurora.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/base/platform.c')
-rw-r--r--drivers/base/platform.c11
1 files changed, 4 insertions, 7 deletions
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index bc78848dd59a..e714709704e4 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -481,11 +481,10 @@ static int platform_drv_probe(struct device *_dev)
481 struct platform_device *dev = to_platform_device(_dev); 481 struct platform_device *dev = to_platform_device(_dev);
482 int ret; 482 int ret;
483 483
484 if (ACPI_HANDLE(_dev)) 484 acpi_dev_pm_attach(_dev, true);
485 acpi_dev_pm_attach(_dev, true);
486 485
487 ret = drv->probe(dev); 486 ret = drv->probe(dev);
488 if (ret && ACPI_HANDLE(_dev)) 487 if (ret)
489 acpi_dev_pm_detach(_dev, true); 488 acpi_dev_pm_detach(_dev, true);
490 489
491 if (drv->prevent_deferred_probe && ret == -EPROBE_DEFER) { 490 if (drv->prevent_deferred_probe && ret == -EPROBE_DEFER) {
@@ -508,8 +507,7 @@ static int platform_drv_remove(struct device *_dev)
508 int ret; 507 int ret;
509 508
510 ret = drv->remove(dev); 509 ret = drv->remove(dev);
511 if (ACPI_HANDLE(_dev)) 510 acpi_dev_pm_detach(_dev, true);
512 acpi_dev_pm_detach(_dev, true);
513 511
514 return ret; 512 return ret;
515} 513}
@@ -520,8 +518,7 @@ static void platform_drv_shutdown(struct device *_dev)
520 struct platform_device *dev = to_platform_device(_dev); 518 struct platform_device *dev = to_platform_device(_dev);
521 519
522 drv->shutdown(dev); 520 drv->shutdown(dev);
523 if (ACPI_HANDLE(_dev)) 521 acpi_dev_pm_detach(_dev, true);
524 acpi_dev_pm_detach(_dev, true);
525} 522}
526 523
527/** 524/**