aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/ata
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2009-07-11 03:49:48 -0400
committerJeff Garzik <jgarzik@redhat.com>2009-07-14 22:42:51 -0400
commit1e1f421a8137824127a41303a30493356b5da638 (patch)
treee112d0f728f33ba9376af26c703472b97a53f60b /drivers/ata
parentd0cb43b35d64877b2944bd37719708be5d7bbf99 (diff)
drivers/ata: Move a dereference below a NULL test
If the NULL test is necessary, then the dereference should be moved below the NULL test. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @@ type T; expression E; identifier i,fld; statement S; @@ - T i = E->fld; + T i; ... when != E when != i if (E == NULL) S + i = E->fld; // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/ata')
-rw-r--r--drivers/ata/pata_at91.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c
index 4b27617be26d..8561a9f195c1 100644
--- a/drivers/ata/pata_at91.c
+++ b/drivers/ata/pata_at91.c
@@ -312,11 +312,12 @@ err_ide_ioremap:
312static int __devexit pata_at91_remove(struct platform_device *pdev) 312static int __devexit pata_at91_remove(struct platform_device *pdev)
313{ 313{
314 struct ata_host *host = dev_get_drvdata(&pdev->dev); 314 struct ata_host *host = dev_get_drvdata(&pdev->dev);
315 struct at91_ide_info *info = host->private_data; 315 struct at91_ide_info *info;
316 struct device *dev = &pdev->dev; 316 struct device *dev = &pdev->dev;
317 317
318 if (!host) 318 if (!host)
319 return 0; 319 return 0;
320 info = host->private_data;
320 321
321 ata_host_detach(host); 322 ata_host_detach(host);
322 323