libata: implement and use ata_port_desc() to report port configuration

Currently, port configuration reporting has the following problems.

* iomapped address is reported instead of raw address
* report contains irrelevant fields or lacks necessary fields for
  non-SFF controllers.
* host->irq/irq2 are there just for reporting and hacky.

This patch implements and uses ata_port_desc() and
ata_port_pbar_desc().  ata_port_desc() is almost identical to
ata_ehi_push_desc() except that it takes @ap instead of @ehi, has no
locking requirement, can only be used during host initialization and "
" is used as separator instead of ", ".  ata_port_pbar_desc() is a
helper to ease reporting of a PCI BAR or an offsetted address into it.

LLD pushes whatever description it wants using the above two
functions.  The accumulated description is printed on host
registration after "[S/P]ATA max MAX_XFERMODE ".

SFF init helpers and ata_host_activate() automatically add
descriptions for addresses and irq respectively, so only LLDs which
isn't standard SFF need to add custom descriptions.  In many cases,
such controllers need to report different things anyway.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

1 files changed, 12 insertions, 7 deletions

diff --git a/drivers/ata/sata_sx4.c b/drivers/ata/sata_sx4.c
index b425061dbe8c..9f9f7b30654a 100644
--- a/drivers/ata/sata_sx4.c
+++ b/drivers/ata/sata_sx4.c
@@ -1381,9 +1381,8 @@ static int pdc_sata_init_one (struct pci_dev *pdev, const struct pci_device_id *
         const struct ata_port_info *ppi[] =
                 { &pdc_port_info[ent->driver_data], NULL };
         struct ata_host *host;
-        void __iomem *base;
         struct pdc_host_priv *hpriv;
-        int rc;
+        int i, rc;
 
         if (!printed_version++)
                 dev_printk(KERN_DEBUG, &pdev->dev, "version " DRV_VERSION "\n");
@@ -1409,11 +1408,17 @@ static int pdc_sata_init_one (struct pci_dev *pdev, const struct pci_device_id *
                 return rc;
         host->iomap = pcim_iomap_table(pdev);
 
-        base = host->iomap[PDC_MMIO_BAR] + PDC_CHIP0_OFS;
-        pdc_sata_setup_port(&host->ports[0]->ioaddr, base + 0x200);
-        pdc_sata_setup_port(&host->ports[1]->ioaddr, base + 0x280);
-        pdc_sata_setup_port(&host->ports[2]->ioaddr, base + 0x300);
-        pdc_sata_setup_port(&host->ports[3]->ioaddr, base + 0x380);
+        for (i = 0; i < 4; i++) {
+                struct ata_port *ap = host->ports[i];
+                void __iomem *base = host->iomap[PDC_MMIO_BAR] + PDC_CHIP0_OFS;
+                unsigned int offset = 0x200 + i * 0x80;
+
+                pdc_sata_setup_port(&ap->ioaddr, base + offset);
+
+                ata_port_pbar_desc(ap, PDC_MMIO_BAR, -1, "mmio");
+                ata_port_pbar_desc(ap, PDC_DIMM_BAR, -1, "dimm");
+                ata_port_pbar_desc(ap, PDC_MMIO_BAR, offset, "port");
+        }
 
         /* configure and activate */
         rc = pci_set_dma_mask(pdev, ATA_DMA_MASK);