aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/ata/pata_qdi.c
diff options
context:
space:
mode:
authorTejun Heo <htejun@gmail.com>2008-03-24 23:22:47 -0400
committerJeff Garzik <jgarzik@redhat.com>2008-04-17 15:44:16 -0400
commit358f9a77a668660729e705fde9c3cf69f013aa98 (patch)
treea249660fdd9f252925eff9eaac3ed7836c839f91 /drivers/ata/pata_qdi.c
parentc1bc899f5805771926c9198e2ab4d77122c356a1 (diff)
libata: implement and use ata_noop_irq_clear()
->irq_clear() is used to clear IRQ bit of a SFF controller and isn't useful for drivers which don't use libata SFF HSM implementation. However, it's a required callback and many drivers implement their own noop version as placeholder. This patch implements ata_noop_irq_clear and use it to replace those custom placeholders. Also, SFF drivers which don't support BMDMA don't need to use ata_bmdma_irq_clear(). It becomes noop if BMDMA address isn't initialized. Convert them to use ata_noop_irq_clear(). Signed-off-by: Tejun Heo <htejun@gmail.com>
Diffstat (limited to 'drivers/ata/pata_qdi.c')
-rw-r--r--drivers/ata/pata_qdi.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/ata/pata_qdi.c b/drivers/ata/pata_qdi.c
index 9f308ed76cc8..60238d5748a7 100644
--- a/drivers/ata/pata_qdi.c
+++ b/drivers/ata/pata_qdi.c
@@ -191,7 +191,7 @@ static struct ata_port_operations qdi6500_port_ops = {
191 191
192 .data_xfer = qdi_data_xfer, 192 .data_xfer = qdi_data_xfer,
193 193
194 .irq_clear = ata_bmdma_irq_clear, 194 .irq_clear = ata_noop_irq_clear,
195 .irq_on = ata_irq_on, 195 .irq_on = ata_irq_on,
196 196
197 .port_start = ata_sff_port_start, 197 .port_start = ata_sff_port_start,
@@ -217,7 +217,7 @@ static struct ata_port_operations qdi6580_port_ops = {
217 217
218 .data_xfer = qdi_data_xfer, 218 .data_xfer = qdi_data_xfer,
219 219
220 .irq_clear = ata_bmdma_irq_clear, 220 .irq_clear = ata_noop_irq_clear,
221 .irq_on = ata_irq_on, 221 .irq_on = ata_irq_on,
222 222
223 .port_start = ata_sff_port_start, 223 .port_start = ata_sff_port_start,