diff options
author | Zhao Yakui <yakui.zhao@intel.com> | 2008-06-24 06:01:09 -0400 |
---|---|---|
committer | Andi Kleen <andi@basil.nowhere.org> | 2008-07-16 17:27:05 -0400 |
commit | da5e09a1b3e5a9fc0b15a3feb64e921ccc55ba74 (patch) | |
tree | 382a75c1180e458df826ef4efbc191f3f71275c1 /drivers/acpi | |
parent | c1e3b377ad48febba6f91b8ae42c44ee4d4ab45e (diff) |
ACPI : Create "idle=nomwait" bootparam
"idle=nomwait" disables the use of the MWAIT
instruction from both C1 (C1_FFH) and deeper (C2C3_FFH)
C-states.
When MWAIT is unavailable, the BIOS and OS generally
negotiate to use the HALT instruction for C1,
and use IO accesses for deeper C-states.
This option is useful for power and performance
comparisons, and also to work around BIOS bugs
where broken MWAIT support is advertised.
http://bugzilla.kernel.org/show_bug.cgi?id=10807
http://bugzilla.kernel.org/show_bug.cgi?id=10914
Signed-off-by: Zhao Yakui <yakui.zhao@intel.com>
Signed-off-by: Li Shaohua <shaohua.li@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Diffstat (limited to 'drivers/acpi')
-rw-r--r-- | drivers/acpi/processor_core.c | 13 | ||||
-rw-r--r-- | drivers/acpi/processor_idle.c | 6 |
2 files changed, 18 insertions, 1 deletions
diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c index 9a803f85ccfe..4e1bb89fd6c3 100644 --- a/drivers/acpi/processor_core.c +++ b/drivers/acpi/processor_core.c | |||
@@ -265,7 +265,20 @@ static int acpi_processor_set_pdc(struct acpi_processor *pr) | |||
265 | 265 | ||
266 | if (!pdc_in) | 266 | if (!pdc_in) |
267 | return status; | 267 | return status; |
268 | if (idle_nomwait) { | ||
269 | /* | ||
270 | * If mwait is disabled for CPU C-states, the C2C3_FFH access | ||
271 | * mode will be disabled in the parameter of _PDC object. | ||
272 | * Of course C1_FFH access mode will also be disabled. | ||
273 | */ | ||
274 | union acpi_object *obj; | ||
275 | u32 *buffer = NULL; | ||
268 | 276 | ||
277 | obj = pdc_in->pointer; | ||
278 | buffer = (u32 *)(obj->buffer.pointer); | ||
279 | buffer[2] &= ~(ACPI_PDC_C_C2C3_FFH | ACPI_PDC_C_C1_FFH); | ||
280 | |||
281 | } | ||
269 | status = acpi_evaluate_object(pr->handle, "_PDC", pdc_in, NULL); | 282 | status = acpi_evaluate_object(pr->handle, "_PDC", pdc_in, NULL); |
270 | 283 | ||
271 | if (ACPI_FAILURE(status)) | 284 | if (ACPI_FAILURE(status)) |
diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c index c75c7ace8c13..d592dbb1d12a 100644 --- a/drivers/acpi/processor_idle.c +++ b/drivers/acpi/processor_idle.c | |||
@@ -957,13 +957,17 @@ static int acpi_processor_get_power_info_cst(struct acpi_processor *pr) | |||
957 | } else { | 957 | } else { |
958 | continue; | 958 | continue; |
959 | } | 959 | } |
960 | if (cx.type == ACPI_STATE_C1 && idle_halt) { | 960 | if (cx.type == ACPI_STATE_C1 && |
961 | (idle_halt || idle_nomwait)) { | ||
961 | /* | 962 | /* |
962 | * In most cases the C1 space_id obtained from | 963 | * In most cases the C1 space_id obtained from |
963 | * _CST object is FIXED_HARDWARE access mode. | 964 | * _CST object is FIXED_HARDWARE access mode. |
964 | * But when the option of idle=halt is added, | 965 | * But when the option of idle=halt is added, |
965 | * the entry_method type should be changed from | 966 | * the entry_method type should be changed from |
966 | * CSTATE_FFH to CSTATE_HALT. | 967 | * CSTATE_FFH to CSTATE_HALT. |
968 | * When the option of idle=nomwait is added, | ||
969 | * the C1 entry_method type should be | ||
970 | * CSTATE_HALT. | ||
967 | */ | 971 | */ |
968 | cx.entry_method = ACPI_CSTATE_HALT; | 972 | cx.entry_method = ACPI_CSTATE_HALT; |
969 | snprintf(cx.desc, ACPI_CX_DESC_LEN, "ACPI HLT"); | 973 | snprintf(cx.desc, ACPI_CX_DESC_LEN, "ACPI HLT"); |