[ACPI] ACPICA 20060210

Removed a couple of extraneous ACPI_ERROR messages that
appeared during normal execution. These became apparent
after the conversion from ACPI_DEBUG_PRINT.

Fixed a problem where the CreateField operator could hang
if the BitIndex or NumBits parameter referred to a named
object. From Valery Podrezov.
http://bugzilla.kernel.org/show_bug.cgi?id=5359

Fixed a problem where a DeRefOf operation on a buffer
object incorrectly failed with an exception. This also
fixes a couple of related RefOf and DeRefOf issues.
From Valery Podrezov.
http://bugzilla.kernel.org/show_bug.cgi?id=5360
http://bugzilla.kernel.org/show_bug.cgi?id=5387
http://bugzilla.kernel.org/show_bug.cgi?id=5392

Fixed a problem where the AE_BUFFER_LIMIT exception was
returned instead of AE_STRING_LIMIT on an out-of-bounds
Index() operation. From Valery Podrezov.
http://bugzilla.kernel.org/show_bug.cgi?id=5480

Implemented a memory cleanup at the end of the execution
of each iteration of an AML While() loop, preventing the
accumulation of outstanding objects. From Valery Podrezov.
http://bugzilla.kernel.org/show_bug.cgi?id=5427

Eliminated a chunk of duplicate code in the object
resolution code. From Valery Podrezov.
http://bugzilla.kernel.org/show_bug.cgi?id=5336

Fixed several warnings during the 64-bit code generation.

Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>

9 files changed, 37 insertions, 0 deletions

diff --git a/drivers/acpi/parser/psargs.c b/drivers/acpi/parser/psargs.c
index de573be52718..1c5934fe1853 100644
--- a/drivers/acpi/parser/psargs.c
+++ b/drivers/acpi/parser/psargs.c
@@ -275,6 +275,7 @@ acpi_ps_get_next_namepath(struct acpi_walk_state *walk_state,
          */
         if (ACPI_SUCCESS(status) &&
             possible_method_call && (node->type == ACPI_TYPE_METHOD)) {
+
                 /* This name is actually a control method invocation */
 
                 method_desc = acpi_ns_get_attached_object(node);
@@ -319,6 +320,7 @@ acpi_ps_get_next_namepath(struct acpi_walk_state *walk_state,
          * some not_found cases are allowed
          */
         if (status == AE_NOT_FOUND) {
+
                 /* 1) not_found is ok during load pass 1/2 (allow forward references) */
 
                 if ((walk_state->parse_flags & ACPI_PARSE_MODE_MASK) !=
@@ -354,6 +356,7 @@ acpi_ps_get_next_namepath(struct acpi_walk_state *walk_state,
 
                 if ((walk_state->parse_flags & ACPI_PARSE_MODE_MASK) ==
                     ACPI_PARSE_EXECUTE) {
+
                         /* Report a control method execution error */
 
                         status = acpi_ds_method_error(status, walk_state);
@@ -620,6 +623,7 @@ acpi_ps_get_next_arg(struct acpi_walk_state *walk_state,
         case ARGP_FIELDLIST:
 
                 if (parser_state->aml < parser_state->pkg_end) {
+
                         /* Non-empty list */
 
                         while (parser_state->aml < parser_state->pkg_end) {
@@ -645,6 +649,7 @@ acpi_ps_get_next_arg(struct acpi_walk_state *walk_state,
         case ARGP_BYTELIST:
 
                 if (parser_state->aml < parser_state->pkg_end) {
+
                         /* Non-empty list */
 
                         arg = acpi_ps_alloc_op(AML_INT_BYTELIST_OP);
@@ -673,6 +678,7 @@ acpi_ps_get_next_arg(struct acpi_walk_state *walk_state,
                 if (subop == 0 ||
                     acpi_ps_is_leading_char(subop) ||
                     acpi_ps_is_prefix_char(subop)) {
+
                         /* null_name or name_string */
 
                         arg = acpi_ps_alloc_op(AML_INT_NAMEPATH_OP);
@@ -703,6 +709,7 @@ acpi_ps_get_next_arg(struct acpi_walk_state *walk_state,
         case ARGP_OBJLIST:
 
                 if (parser_state->aml < parser_state->pkg_end) {
+
                         /* Non-empty list of variable arguments, nothing returned */
 
                         walk_state->arg_count = ACPI_VAR_ARGS;
diff --git a/drivers/acpi/parser/psloop.c b/drivers/acpi/parser/psloop.c
index 00b072e15d19..42062d5abc9e 100644
--- a/drivers/acpi/parser/psloop.c
+++ b/drivers/acpi/parser/psloop.c
@@ -95,6 +95,7 @@ acpi_status acpi_ps_parse_loop(struct acpi_walk_state *walk_state)
 #if (!defined (ACPI_NO_METHOD_EXECUTION) && !defined (ACPI_CONSTANT_EVAL_ONLY))
 
         if (walk_state->walk_type & ACPI_WALK_METHOD_RESTART) {
+
                 /* We are restarting a preempted control method */
 
                 if (acpi_ps_has_completed_scope(parser_state)) {
@@ -143,6 +144,7 @@ acpi_status acpi_ps_parse_loop(struct acpi_walk_state *walk_state)
                         ACPI_DEBUG_PRINT((ACPI_DB_PARSE,
                                           "Popped scope, Op=%p\n", op));
                 } else if (walk_state->prev_op) {
+
                         /* We were in the middle of an op */
 
                         op = walk_state->prev_op;
@@ -156,6 +158,7 @@ acpi_status acpi_ps_parse_loop(struct acpi_walk_state *walk_state)
         while ((parser_state->aml < parser_state->aml_end) || (op)) {
                 aml_op_start = parser_state->aml;
                 if (!op) {
+
                         /* Get the next opcode from the AML stream */
 
                         walk_state->aml_offset =
@@ -213,6 +216,7 @@ acpi_status acpi_ps_parse_loop(struct acpi_walk_state *walk_state)
                         /* Create Op structure and append to parent's argument list */
 
                         if (walk_state->op_info->flags & AML_NAMED) {
+
                                 /* Allocate a new pre_op if necessary */
 
                                 if (!pre_op) {
@@ -388,6 +392,7 @@ acpi_status acpi_ps_parse_loop(struct acpi_walk_state *walk_state)
                 /* Are there any arguments that must be processed? */
 
                 if (walk_state->arg_types) {
+
                         /* Get arguments */
 
                         switch (op->common.aml_opcode) {
@@ -853,6 +858,7 @@ acpi_status acpi_ps_parse_loop(struct acpi_walk_state *walk_state)
                                 }
 
                                 else if (ACPI_FAILURE(status)) {
+
                                         /* First error is most important */
 
                                         (void)
diff --git a/drivers/acpi/parser/psopcode.c b/drivers/acpi/parser/psopcode.c
index 11d6351ab8b2..9eb8d0663886 100644
--- a/drivers/acpi/parser/psopcode.c
+++ b/drivers/acpi/parser/psopcode.c
@@ -731,6 +731,7 @@ const struct acpi_opcode_info *acpi_ps_get_opcode_info(u16 opcode)
          * Detect normal 8-bit opcode or extended 16-bit opcode
          */
         if (!(opcode & 0xFF00)) {
+
                 /* Simple (8-bit) opcode: 0-255, can't index beyond table  */
 
                 return (&acpi_gbl_aml_op_info
@@ -739,6 +740,7 @@ const struct acpi_opcode_info *acpi_ps_get_opcode_info(u16 opcode)
 
         if (((opcode & 0xFF00) == AML_EXTENDED_OPCODE) &&
             (((u8) opcode) <= MAX_EXTENDED_OPCODE)) {
+
                 /* Valid extended (16-bit) opcode */
 
                 return (&acpi_gbl_aml_op_info
diff --git a/drivers/acpi/parser/psparse.c b/drivers/acpi/parser/psparse.c
index a9f3229f4106..83d8916bc1af 100644
--- a/drivers/acpi/parser/psparse.c
+++ b/drivers/acpi/parser/psparse.c
@@ -106,6 +106,7 @@ u16 acpi_ps_peek_opcode(struct acpi_parse_state * parser_state)
         opcode = (u16) ACPI_GET8(aml);
 
         if (opcode == AML_EXTENDED_OP_PREFIX) {
+
                 /* Extended opcode, get the second opcode byte */
 
                 aml++;
@@ -158,6 +159,7 @@ acpi_ps_complete_this_op(struct acpi_walk_state * walk_state,
         if (op->common.parent) {
                 prev = op->common.parent->common.value.arg;
                 if (!prev) {
+
                         /* Nothing more to do */
 
                         goto cleanup;
@@ -245,6 +247,7 @@ acpi_ps_complete_this_op(struct acpi_walk_state * walk_state,
                 /* We must unlink this op from the parent tree */
 
                 if (prev == op) {
+
                         /* This op is the first in the list */
 
                         if (replacement_op) {
@@ -265,6 +268,7 @@ acpi_ps_complete_this_op(struct acpi_walk_state * walk_state,
 
                 else
                         while (prev) {
+
                                 /* Traverse all siblings in the parent's argument list */
 
                                 next = prev->common.next;
@@ -510,6 +514,7 @@ acpi_status acpi_ps_parse_aml(struct acpi_walk_state *walk_state)
                 } else if (status == AE_CTRL_TERMINATE) {
                         status = AE_OK;
                 } else if ((status != AE_OK) && (walk_state->method_desc)) {
+
                         /* Either the method parse or actual execution failed */
 
                         ACPI_ERROR_METHOD("Method parse/execution failed",
@@ -551,6 +556,7 @@ acpi_status acpi_ps_parse_aml(struct acpi_walk_state *walk_state)
                 if (((walk_state->parse_flags & ACPI_PARSE_MODE_MASK) ==
                      ACPI_PARSE_EXECUTE) || (ACPI_FAILURE(status))) {
                         if (walk_state->method_desc) {
+
                                 /* Decrement the thread count on the method parse tree */
 
                                 if (walk_state->method_desc->method.
@@ -633,12 +639,14 @@ acpi_status acpi_ps_parse_aml(struct acpi_walk_state *walk_state)
                         }
                 } else {
                         if (previous_walk_state->return_desc) {
+
                                 /* Caller doesn't want it, must delete it */
 
                                 acpi_ut_remove_reference(previous_walk_state->
                                                          return_desc);
                         }
                         if (previous_walk_state->implicit_return_obj) {
+
                                 /* Caller doesn't want it, must delete it */
 
                                 acpi_ut_remove_reference(previous_walk_state->
diff --git a/drivers/acpi/parser/psscope.c b/drivers/acpi/parser/psscope.c
index bc6047caccd9..edb7c9ba6ec2 100644
--- a/drivers/acpi/parser/psscope.c
+++ b/drivers/acpi/parser/psscope.c
@@ -165,6 +165,7 @@ acpi_ps_push_scope(struct acpi_parse_state *parser_state,
         acpi_ut_push_generic_state(&parser_state->scope, scope);
 
         if (arg_count == ACPI_VAR_ARGS) {
+
                 /* Multiple arguments */
 
                 scope->parse_scope.arg_end = parser_state->pkg_end;
diff --git a/drivers/acpi/parser/pstree.c b/drivers/acpi/parser/pstree.c
index dd6f16726fc4..6aa0012643ce 100644
--- a/drivers/acpi/parser/pstree.c
+++ b/drivers/acpi/parser/pstree.c
@@ -77,6 +77,7 @@ union acpi_parse_object *acpi_ps_get_arg(union acpi_parse_object *op, u32 argn)
 
         op_info = acpi_ps_get_opcode_info(op->common.aml_opcode);
         if (op_info->class == AML_CLASS_UNKNOWN) {
+
                 /* Invalid opcode or ASCII character */
 
                 return (NULL);
@@ -85,6 +86,7 @@ union acpi_parse_object *acpi_ps_get_arg(union acpi_parse_object *op, u32 argn)
         /* Check if this opcode requires argument sub-objects */
 
         if (!(op_info->flags & AML_HAS_ARGS)) {
+
                 /* Has no linked argument objects */
 
                 return (NULL);
@@ -130,6 +132,7 @@ acpi_ps_append_arg(union acpi_parse_object *op, union acpi_parse_object *arg)
 
         op_info = acpi_ps_get_opcode_info(op->common.aml_opcode);
         if (op_info->class == AML_CLASS_UNKNOWN) {
+
                 /* Invalid opcode */
 
                 ACPI_ERROR((AE_INFO, "Invalid AML Opcode: 0x%2.2X",
@@ -140,6 +143,7 @@ acpi_ps_append_arg(union acpi_parse_object *op, union acpi_parse_object *arg)
         /* Check if this opcode requires argument sub-objects */
 
         if (!(op_info->flags & AML_HAS_ARGS)) {
+
                 /* Has no linked argument objects */
 
                 return;
@@ -148,6 +152,7 @@ acpi_ps_append_arg(union acpi_parse_object *op, union acpi_parse_object *arg)
         /* Append the argument to the linked argument list */
 
         if (op->common.value.arg) {
+
                 /* Append to existing argument list */
 
                 prev_arg = op->common.value.arg;
@@ -222,12 +227,14 @@ union acpi_parse_object *acpi_ps_get_depth_next(union acpi_parse_object *origin,
                 }
 
                 if (arg == origin) {
+
                         /* Reached parent of origin, end search */
 
                         return (NULL);
                 }
 
                 if (parent->common.next) {
+
                         /* Found sibling of parent */
 
                         return (parent->common.next);
diff --git a/drivers/acpi/parser/psutils.c b/drivers/acpi/parser/psutils.c
index 3e07cb9cb748..a4c33a4bfe35 100644
--- a/drivers/acpi/parser/psutils.c
+++ b/drivers/acpi/parser/psutils.c
@@ -135,6 +135,7 @@ union acpi_parse_object *acpi_ps_alloc_op(u16 opcode)
         /* Allocate the minimum required size object */
 
         if (flags == ACPI_PARSEOP_GENERIC) {
+
                 /* The generic op (default) is by far the most common (16 to 1) */
 
                 op = acpi_os_acquire_object(acpi_gbl_ps_node_cache);
diff --git a/drivers/acpi/parser/pswalk.c b/drivers/acpi/parser/pswalk.c
index 06f05bfd7612..3d08b8c6db41 100644
--- a/drivers/acpi/parser/pswalk.c
+++ b/drivers/acpi/parser/pswalk.c
@@ -69,13 +69,16 @@ void acpi_ps_delete_parse_tree(union acpi_parse_object *subtree_root)
         /* Visit all nodes in the subtree */
 
         while (op) {
+
                 /* Check if we are not ascending */
 
                 if (op != parent) {
+
                         /* Look for an argument or child of the current op */
 
                         next = acpi_ps_get_arg(op, 0);
                         if (next) {
+
                                 /* Still going downward in tree (Op is not completed yet) */
 
                                 op = next;
diff --git a/drivers/acpi/parser/psxface.c b/drivers/acpi/parser/psxface.c
index 2dd48cbb7c02..e09a820ee294 100644
--- a/drivers/acpi/parser/psxface.c
+++ b/drivers/acpi/parser/psxface.c
@@ -317,9 +317,11 @@ acpi_ps_update_parameter_list(struct acpi_parameter_info *info, u16 action)
         acpi_native_uint i;
 
         if ((info->parameter_type == ACPI_PARAM_ARGS) && (info->parameters)) {
+
                 /* Update reference count for each parameter */
 
                 for (i = 0; info->parameters[i]; i++) {
+
                         /* Ignore errors, just do them all */
 
                         (void)acpi_ut_update_object_reference(info->