diff options
author | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2013-08-06 19:22:51 -0400 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2013-08-07 17:41:48 -0400 |
commit | 38e88839eff8a3d2e8d3bcc2ad833fe51cca0496 (patch) | |
tree | d23e77a0a1d12a5d7367f7770591a472c26ed5a8 /drivers/acpi/glue.c | |
parent | 3e3327837c180781960188563b4e4d5c004c2b29 (diff) |
ACPI: Clean up error code path in acpi_unbind_one()
The error code path in acpi_unbind_one() is unnecessarily complicated
(in particular, the err label is not really necessary) and the error
message printed by it is inaccurate (there's nothing called
'acpi_handle' in that function), so clean up those things.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Toshi Kani <toshi.kani@hp.com>
Acked-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Diffstat (limited to 'drivers/acpi/glue.c')
-rw-r--r-- | drivers/acpi/glue.c | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c index 570628e1def3..dcba319ac3f1 100644 --- a/drivers/acpi/glue.c +++ b/drivers/acpi/glue.c | |||
@@ -284,8 +284,10 @@ int acpi_unbind_one(struct device *dev) | |||
284 | return 0; | 284 | return 0; |
285 | 285 | ||
286 | status = acpi_bus_get_device(ACPI_HANDLE(dev), &acpi_dev); | 286 | status = acpi_bus_get_device(ACPI_HANDLE(dev), &acpi_dev); |
287 | if (ACPI_FAILURE(status)) | 287 | if (ACPI_FAILURE(status)) { |
288 | goto err; | 288 | dev_err(dev, "Oops, ACPI handle corrupt in %s()\n", __func__); |
289 | return -EINVAL; | ||
290 | } | ||
289 | 291 | ||
290 | mutex_lock(&acpi_dev->physical_node_lock); | 292 | mutex_lock(&acpi_dev->physical_node_lock); |
291 | 293 | ||
@@ -307,12 +309,7 @@ int acpi_unbind_one(struct device *dev) | |||
307 | } | 309 | } |
308 | 310 | ||
309 | mutex_unlock(&acpi_dev->physical_node_lock); | 311 | mutex_unlock(&acpi_dev->physical_node_lock); |
310 | |||
311 | return 0; | 312 | return 0; |
312 | |||
313 | err: | ||
314 | dev_err(dev, "Oops, 'acpi_handle' corrupt\n"); | ||
315 | return -EINVAL; | ||
316 | } | 313 | } |
317 | EXPORT_SYMBOL_GPL(acpi_unbind_one); | 314 | EXPORT_SYMBOL_GPL(acpi_unbind_one); |
318 | 315 | ||