diff options
author | Lv Zheng <lv.zheng@intel.com> | 2015-04-12 23:48:37 -0400 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2015-04-14 08:51:51 -0400 |
commit | 6d3fd3cc33d50e4c0d0c0bd172de02caaec3127c (patch) | |
tree | 57f88706cfb875aa3cbae68862879513d51fe3c1 /drivers/acpi/acpica | |
parent | ea2849255f13b63de90483ffa7781b8b65cc7765 (diff) |
ACPICA: Utilities: Cleanup to enforce ACPI_PHYSADDR_TO_PTR()/ACPI_PTR_TO_PHYSADDR().
ACPICA commit 154f6d074dd38d6ebc0467ad454454e6c5c9ecdf
There are code pieces converting pointers using "(acpi_physical_address) x"
or "ACPI_CAST_PTR (t, x)" formats, this patch cleans up them.
Known issues:
1. Cleanup of "(ACPI_PHYSICAL_ADDRRESS) x" for a table field
For the conversions around the table fields, it is better to fix it with
alignment also fixed. So this patch doesn't modify such code. There
should be no functional problem by leaving them unchanged.
Link: https://github.com/acpica/acpica/commit/154f6d07
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/acpi/acpica')
-rw-r--r-- | drivers/acpi/acpica/dsopcode.c | 3 | ||||
-rw-r--r-- | drivers/acpi/acpica/tbdata.c | 9 | ||||
-rw-r--r-- | drivers/acpi/acpica/tbinstal.c | 10 |
3 files changed, 11 insertions, 11 deletions
diff --git a/drivers/acpi/acpica/dsopcode.c b/drivers/acpi/acpica/dsopcode.c index 77244182ff02..398e2084c35c 100644 --- a/drivers/acpi/acpica/dsopcode.c +++ b/drivers/acpi/acpica/dsopcode.c | |||
@@ -539,8 +539,7 @@ acpi_ds_eval_table_region_operands(struct acpi_walk_state *walk_state, | |||
539 | return_ACPI_STATUS(AE_NOT_EXIST); | 539 | return_ACPI_STATUS(AE_NOT_EXIST); |
540 | } | 540 | } |
541 | 541 | ||
542 | obj_desc->region.address = | 542 | obj_desc->region.address = ACPI_PTR_TO_PHYSADDR(table); |
543 | (acpi_physical_address) ACPI_TO_INTEGER(table); | ||
544 | obj_desc->region.length = table->length; | 543 | obj_desc->region.length = table->length; |
545 | 544 | ||
546 | ACPI_DEBUG_PRINT((ACPI_DB_EXEC, "RgnObj %p Addr %8.8X%8.8X Len %X\n", | 545 | ACPI_DEBUG_PRINT((ACPI_DB_EXEC, "RgnObj %p Addr %8.8X%8.8X Len %X\n", |
diff --git a/drivers/acpi/acpica/tbdata.c b/drivers/acpi/acpica/tbdata.c index 6a144957aadd..03834496d55b 100644 --- a/drivers/acpi/acpica/tbdata.c +++ b/drivers/acpi/acpica/tbdata.c | |||
@@ -113,9 +113,9 @@ acpi_tb_acquire_table(struct acpi_table_desc *table_desc, | |||
113 | case ACPI_TABLE_ORIGIN_INTERNAL_VIRTUAL: | 113 | case ACPI_TABLE_ORIGIN_INTERNAL_VIRTUAL: |
114 | case ACPI_TABLE_ORIGIN_EXTERNAL_VIRTUAL: | 114 | case ACPI_TABLE_ORIGIN_EXTERNAL_VIRTUAL: |
115 | 115 | ||
116 | table = | 116 | table = ACPI_CAST_PTR(struct acpi_table_header, |
117 | ACPI_CAST_PTR(struct acpi_table_header, | 117 | ACPI_PHYSADDR_TO_PTR(table_desc-> |
118 | table_desc->address); | 118 | address)); |
119 | break; | 119 | break; |
120 | 120 | ||
121 | default: | 121 | default: |
@@ -214,7 +214,8 @@ acpi_tb_acquire_temp_table(struct acpi_table_desc *table_desc, | |||
214 | case ACPI_TABLE_ORIGIN_INTERNAL_VIRTUAL: | 214 | case ACPI_TABLE_ORIGIN_INTERNAL_VIRTUAL: |
215 | case ACPI_TABLE_ORIGIN_EXTERNAL_VIRTUAL: | 215 | case ACPI_TABLE_ORIGIN_EXTERNAL_VIRTUAL: |
216 | 216 | ||
217 | table_header = ACPI_CAST_PTR(struct acpi_table_header, address); | 217 | table_header = ACPI_CAST_PTR(struct acpi_table_header, |
218 | ACPI_PHYSADDR_TO_PTR(address)); | ||
218 | if (!table_header) { | 219 | if (!table_header) { |
219 | return (AE_NO_MEMORY); | 220 | return (AE_NO_MEMORY); |
220 | } | 221 | } |
diff --git a/drivers/acpi/acpica/tbinstal.c b/drivers/acpi/acpica/tbinstal.c index 9bad45e63a45..201332a63140 100644 --- a/drivers/acpi/acpica/tbinstal.c +++ b/drivers/acpi/acpica/tbinstal.c | |||
@@ -188,7 +188,7 @@ acpi_tb_install_fixed_table(acpi_physical_address address, | |||
188 | ACPI_TABLE_ORIGIN_INTERNAL_PHYSICAL); | 188 | ACPI_TABLE_ORIGIN_INTERNAL_PHYSICAL); |
189 | if (ACPI_FAILURE(status)) { | 189 | if (ACPI_FAILURE(status)) { |
190 | ACPI_ERROR((AE_INFO, "Could not acquire table length at %p", | 190 | ACPI_ERROR((AE_INFO, "Could not acquire table length at %p", |
191 | ACPI_CAST_PTR(void, address))); | 191 | ACPI_PHYSADDR_TO_PTR(address))); |
192 | return_ACPI_STATUS(status); | 192 | return_ACPI_STATUS(status); |
193 | } | 193 | } |
194 | 194 | ||
@@ -247,7 +247,7 @@ acpi_tb_install_standard_table(acpi_physical_address address, | |||
247 | status = acpi_tb_acquire_temp_table(&new_table_desc, address, flags); | 247 | status = acpi_tb_acquire_temp_table(&new_table_desc, address, flags); |
248 | if (ACPI_FAILURE(status)) { | 248 | if (ACPI_FAILURE(status)) { |
249 | ACPI_ERROR((AE_INFO, "Could not acquire table length at %p", | 249 | ACPI_ERROR((AE_INFO, "Could not acquire table length at %p", |
250 | ACPI_CAST_PTR(void, address))); | 250 | ACPI_PHYSADDR_TO_PTR(address))); |
251 | return_ACPI_STATUS(status); | 251 | return_ACPI_STATUS(status); |
252 | } | 252 | } |
253 | 253 | ||
@@ -259,8 +259,8 @@ acpi_tb_install_standard_table(acpi_physical_address address, | |||
259 | acpi_gbl_disable_ssdt_table_install && | 259 | acpi_gbl_disable_ssdt_table_install && |
260 | ACPI_COMPARE_NAME(&new_table_desc.signature, ACPI_SIG_SSDT)) { | 260 | ACPI_COMPARE_NAME(&new_table_desc.signature, ACPI_SIG_SSDT)) { |
261 | ACPI_INFO((AE_INFO, "Ignoring installation of %4.4s at %p", | 261 | ACPI_INFO((AE_INFO, "Ignoring installation of %4.4s at %p", |
262 | new_table_desc.signature.ascii, ACPI_CAST_PTR(void, | 262 | new_table_desc.signature.ascii, |
263 | address))); | 263 | ACPI_PHYSADDR_TO_PTR(address))); |
264 | goto release_and_exit; | 264 | goto release_and_exit; |
265 | } | 265 | } |
266 | 266 | ||
@@ -517,7 +517,7 @@ void acpi_tb_uninstall_table(struct acpi_table_desc *table_desc) | |||
517 | 517 | ||
518 | if ((table_desc->flags & ACPI_TABLE_ORIGIN_MASK) == | 518 | if ((table_desc->flags & ACPI_TABLE_ORIGIN_MASK) == |
519 | ACPI_TABLE_ORIGIN_INTERNAL_VIRTUAL) { | 519 | ACPI_TABLE_ORIGIN_INTERNAL_VIRTUAL) { |
520 | ACPI_FREE(ACPI_CAST_PTR(void, table_desc->address)); | 520 | ACPI_FREE(ACPI_PHYSADDR_TO_PTR(table_desc->address)); |
521 | } | 521 | } |
522 | 522 | ||
523 | table_desc->address = ACPI_PTR_TO_PHYSADDR(NULL); | 523 | table_desc->address = ACPI_PTR_TO_PHYSADDR(NULL); |