ACPICA: Add post-order callback to acpi_walk_namespace

The existing interface only has a pre-order callback. This change
adds an additional parameter for a post-order callback which will
be more useful for bus scans. ACPICA BZ 779.

Also update the external calls to acpi_walk_namespace.

http://www.acpica.org/bugzilla/show_bug.cgi?id=779

Signed-off-by: Lin Ming <ming.m.lin@intel.com>
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>

9 files changed, 155 insertions, 111 deletions

diff --git a/drivers/acpi/acpica/acnamesp.h b/drivers/acpi/acpica/acnamesp.h
index 09a2764c734b..168e60893a2a 100644
--- a/drivers/acpi/acpica/acnamesp.h
+++ b/drivers/acpi/acpica/acnamesp.h
@@ -104,7 +104,8 @@ acpi_ns_walk_namespace(acpi_object_type type,
                        acpi_handle start_object,
                        u32 max_depth,
                        u32 flags,
-                       acpi_walk_callback user_function,
+                       acpi_walk_callback pre_order_visit,
+                       acpi_walk_callback post_order_visit,
                        void *context, void **return_value);
 
 struct acpi_namespace_node *acpi_ns_get_next_node(struct acpi_namespace_node
diff --git a/drivers/acpi/acpica/dsinit.c b/drivers/acpi/acpica/dsinit.c
index 3aae13f30c5e..f23fa0be6fc2 100644
--- a/drivers/acpi/acpica/dsinit.c
+++ b/drivers/acpi/acpica/dsinit.c
@@ -192,7 +192,7 @@ acpi_ds_initialize_objects(u32 table_index,
         status =
             acpi_ns_walk_namespace(ACPI_TYPE_ANY, start_node, ACPI_UINT32_MAX,
                                    ACPI_NS_WALK_UNLOCK, acpi_ds_init_one_object,
-                                   &info, NULL);
+                                   NULL, &info, NULL);
         if (ACPI_FAILURE(status)) {
                 ACPI_EXCEPTION((AE_INFO, status, "During WalkNamespace"));
         }
diff --git a/drivers/acpi/acpica/evgpeblk.c b/drivers/acpi/acpica/evgpeblk.c
index a60aaa7635f3..247920900187 100644
--- a/drivers/acpi/acpica/evgpeblk.c
+++ b/drivers/acpi/acpica/evgpeblk.c
@@ -945,8 +945,8 @@ acpi_ev_create_gpe_block(struct acpi_namespace_node *gpe_device,
 
         status = acpi_ns_walk_namespace(ACPI_TYPE_METHOD, gpe_device,
                                         ACPI_UINT32_MAX, ACPI_NS_WALK_NO_UNLOCK,
-                                        acpi_ev_save_method_info, gpe_block,
-                                        NULL);
+                                        acpi_ev_save_method_info, NULL,
+                                        gpe_block, NULL);
 
         /* Return the new block */
 
@@ -1022,8 +1022,8 @@ acpi_ev_initialize_gpe_block(struct acpi_namespace_node *gpe_device,
                 status =
                     acpi_ns_walk_namespace(ACPI_TYPE_DEVICE, ACPI_ROOT_OBJECT,
                                            ACPI_UINT32_MAX, ACPI_NS_WALK_UNLOCK,
-                                           acpi_ev_match_prw_and_gpe, &gpe_info,
-                                           NULL);
+                                           acpi_ev_match_prw_and_gpe, NULL,
+                                           &gpe_info, NULL);
         }
 
         /*
diff --git a/drivers/acpi/acpica/evregion.c b/drivers/acpi/acpica/evregion.c
index c9fa040725d4..582b0af01e99 100644
--- a/drivers/acpi/acpica/evregion.c
+++ b/drivers/acpi/acpica/evregion.c
@@ -1025,8 +1025,8 @@ acpi_ev_install_space_handler(struct acpi_namespace_node * node,
          */
         status = acpi_ns_walk_namespace(ACPI_TYPE_ANY, node, ACPI_UINT32_MAX,
                                         ACPI_NS_WALK_UNLOCK,
-                                        acpi_ev_install_handler, handler_obj,
-                                        NULL);
+                                        acpi_ev_install_handler, NULL,
+                                        handler_obj, NULL);
 
       unlock_and_exit:
         return_ACPI_STATUS(status);
@@ -1062,7 +1062,7 @@ acpi_ev_execute_reg_methods(struct acpi_namespace_node *node,
          */
         status = acpi_ns_walk_namespace(ACPI_TYPE_ANY, node, ACPI_UINT32_MAX,
                                         ACPI_NS_WALK_UNLOCK, acpi_ev_reg_run,
-                                        &space_id, NULL);
+                                        NULL, &space_id, NULL);
 
         return_ACPI_STATUS(status);
 }
diff --git a/drivers/acpi/acpica/nsdump.c b/drivers/acpi/acpica/nsdump.c
index 2bad613db73a..2deb986861ca 100644
--- a/drivers/acpi/acpica/nsdump.c
+++ b/drivers/acpi/acpica/nsdump.c
@@ -634,8 +634,8 @@ acpi_ns_dump_objects(acpi_object_type type,
         (void)acpi_ns_walk_namespace(type, start_handle, max_depth,
                                      ACPI_NS_WALK_NO_UNLOCK |
                                      ACPI_NS_WALK_TEMP_NODES,
-                                     acpi_ns_dump_one_object, (void *)&info,
-                                     NULL);
+                                     acpi_ns_dump_one_object, NULL,
+                                     (void *)&info, NULL);
 }
 #endif                          /* ACPI_FUTURE_USAGE */
 
diff --git a/drivers/acpi/acpica/nsdumpdv.c b/drivers/acpi/acpica/nsdumpdv.c
index 0fe87f1aef16..36be7f0e97ec 100644
--- a/drivers/acpi/acpica/nsdumpdv.c
+++ b/drivers/acpi/acpica/nsdumpdv.c
@@ -131,7 +131,8 @@ void acpi_ns_dump_root_devices(void)
 
         status = acpi_ns_walk_namespace(ACPI_TYPE_DEVICE, sys_bus_handle,
                                         ACPI_UINT32_MAX, ACPI_NS_WALK_NO_UNLOCK,
-                                        acpi_ns_dump_one_device, NULL, NULL);
+                                        acpi_ns_dump_one_device, NULL, NULL,
+                                        NULL);
 }
 
 #endif
diff --git a/drivers/acpi/acpica/nsinit.c b/drivers/acpi/acpica/nsinit.c
index 1d5b360eb25b..4f8abac231d2 100644
--- a/drivers/acpi/acpica/nsinit.c
+++ b/drivers/acpi/acpica/nsinit.c
@@ -96,7 +96,7 @@ acpi_status acpi_ns_initialize_objects(void)
         /* Walk entire namespace from the supplied root */
 
         status = acpi_walk_namespace(ACPI_TYPE_ANY, ACPI_ROOT_OBJECT,
-                                     ACPI_UINT32_MAX, acpi_ns_init_one_object,
+                                     ACPI_UINT32_MAX, acpi_ns_init_one_object, NULL,
                                      &info, NULL);
         if (ACPI_FAILURE(status)) {
                 ACPI_EXCEPTION((AE_INFO, status, "During WalkNamespace"));
@@ -156,7 +156,8 @@ acpi_status acpi_ns_initialize_devices(void)
 
         status = acpi_ns_walk_namespace(ACPI_TYPE_ANY, ACPI_ROOT_OBJECT,
                                         ACPI_UINT32_MAX, FALSE,
-                                        acpi_ns_find_ini_methods, &info, NULL);
+                                        acpi_ns_find_ini_methods, NULL, &info,
+                                        NULL);
         if (ACPI_FAILURE(status)) {
                 goto error_exit;
         }
@@ -189,7 +190,8 @@ acpi_status acpi_ns_initialize_devices(void)
 
         status = acpi_ns_walk_namespace(ACPI_TYPE_ANY, ACPI_ROOT_OBJECT,
                                         ACPI_UINT32_MAX, FALSE,
-                                        acpi_ns_init_one_device, &info, NULL);
+                                        acpi_ns_init_one_device, NULL, &info,
+                                        NULL);
 
         ACPI_FREE(info.evaluate_info);
         if (ACPI_FAILURE(status)) {
diff --git a/drivers/acpi/acpica/nswalk.c b/drivers/acpi/acpica/nswalk.c
index 35539df5c75d..d7e6b52b4482 100644
--- a/drivers/acpi/acpica/nswalk.c
+++ b/drivers/acpi/acpica/nswalk.c
@@ -165,24 +165,27 @@ struct acpi_namespace_node *acpi_ns_get_next_node_typed(acpi_object_type type,
  *              max_depth           - Depth to which search is to reach
  *              Flags               - Whether to unlock the NS before invoking
  *                                    the callback routine
- *              user_function       - Called when an object of "Type" is found
- *              Context             - Passed to user function
- *              return_value        - from the user_function if terminated early.
- *                                    Otherwise, returns NULL.
+ *              pre_order_visit     - Called during tree pre-order visit
+ *                                    when an object of "Type" is found
+ *              post_order_visit    - Called during tree post-order visit
+ *                                    when an object of "Type" is found
+ *              Context             - Passed to user function(s) above
+ *              return_value        - from the user_function if terminated
+ *                                    early. Otherwise, returns NULL.
  * RETURNS:     Status
  *
  * DESCRIPTION: Performs a modified depth-first walk of the namespace tree,
  *              starting (and ending) at the node specified by start_handle.
- *              The user_function is called whenever a node that matches
- *              the type parameter is found.  If the user function returns
+ *              The callback function is called whenever a node that matches
+ *              the type parameter is found. If the callback function returns
  *              a non-zero value, the search is terminated immediately and
  *              this value is returned to the caller.
  *
  *              The point of this procedure is to provide a generic namespace
  *              walk routine that can be called from multiple places to
- *              provide multiple services;  the User Function can be tailored
- *              to each task, whether it is a print function, a compare
- *              function, etc.
+ *              provide multiple services; the callback function(s) can be
+ *              tailored to each task, whether it is a print function,
+ *              a compare function, etc.
  *
  ******************************************************************************/
 
@@ -191,7 +194,8 @@ acpi_ns_walk_namespace(acpi_object_type type,
                        acpi_handle start_node,
                        u32 max_depth,
                        u32 flags,
-                       acpi_walk_callback user_function,
+                       acpi_walk_callback pre_order_visit,
+                       acpi_walk_callback post_order_visit,
                        void *context, void **return_value)
 {
         acpi_status status;
@@ -200,6 +204,7 @@ acpi_ns_walk_namespace(acpi_object_type type,
         struct acpi_namespace_node *parent_node;
         acpi_object_type child_type;
         u32 level;
+        u8 node_previously_visited = FALSE;
 
         ACPI_FUNCTION_TRACE(ns_walk_namespace);
 
@@ -212,7 +217,7 @@ acpi_ns_walk_namespace(acpi_object_type type,
         /* Null child means "get first node" */
 
         parent_node = start_node;
-        child_node = NULL;
+        child_node = acpi_ns_get_next_node(parent_node, NULL);
         child_type = ACPI_TYPE_ANY;
         level = 1;
 
@@ -221,102 +226,129 @@ acpi_ns_walk_namespace(acpi_object_type type,
          * started. When Level is zero, the loop is done because we have
          * bubbled up to (and passed) the original parent handle (start_entry)
          */
-        while (level > 0) {
+        while (level > 0 && child_node) {
+                status = AE_OK;
 
-                /* Get the next node in this scope.  Null if not found */
+                /* Found next child, get the type if we are not searching for ANY */
 
-                status = AE_OK;
-                child_node = acpi_ns_get_next_node(parent_node, child_node);
-                if (child_node) {
+                if (type != ACPI_TYPE_ANY) {
+                        child_type = child_node->type;
+                }
 
-                        /* Found next child, get the type if we are not searching for ANY */
+                /*
+                 * Ignore all temporary namespace nodes (created during control
+                 * method execution) unless told otherwise. These temporary nodes
+                 * can cause a race condition because they can be deleted during
+                 * the execution of the user function (if the namespace is
+                 * unlocked before invocation of the user function.) Only the
+                 * debugger namespace dump will examine the temporary nodes.
+                 */
+                if ((child_node->flags & ANOBJ_TEMPORARY) &&
+                    !(flags & ACPI_NS_WALK_TEMP_NODES)) {
+                        status = AE_CTRL_DEPTH;
+                }
 
-                        if (type != ACPI_TYPE_ANY) {
-                                child_type = child_node->type;
-                        }
+                /* Type must match requested type */
 
+                else if (child_type == type) {
                         /*
-                         * Ignore all temporary namespace nodes (created during control
-                         * method execution) unless told otherwise. These temporary nodes
-                         * can cause a race condition because they can be deleted during
-                         * the execution of the user function (if the namespace is
-                         * unlocked before invocation of the user function.) Only the
-                         * debugger namespace dump will examine the temporary nodes.
+                         * Found a matching node, invoke the user callback function.
+                         * Unlock the namespace if flag is set.
                          */
-                        if ((child_node->flags & ANOBJ_TEMPORARY) &&
-                            !(flags & ACPI_NS_WALK_TEMP_NODES)) {
-                                status = AE_CTRL_DEPTH;
+                        if (flags & ACPI_NS_WALK_UNLOCK) {
+                                mutex_status =
+                                    acpi_ut_release_mutex(ACPI_MTX_NAMESPACE);
+                                if (ACPI_FAILURE(mutex_status)) {
+                                        return_ACPI_STATUS(mutex_status);
+                                }
                         }
 
-                        /* Type must match requested type */
-
-                        else if (child_type == type) {
-                                /*
-                                 * Found a matching node, invoke the user callback function.
-                                 * Unlock the namespace if flag is set.
-                                 */
-                                if (flags & ACPI_NS_WALK_UNLOCK) {
-                                        mutex_status =
-                                            acpi_ut_release_mutex
-                                            (ACPI_MTX_NAMESPACE);
-                                        if (ACPI_FAILURE(mutex_status)) {
-                                                return_ACPI_STATUS
-                                                    (mutex_status);
-                                        }
+                        /*
+                         * Invoke the user function, either pre-order or post-order
+                         * or both.
+                         */
+                        if (!node_previously_visited) {
+                                if (pre_order_visit) {
+                                        status =
+                                            pre_order_visit(child_node, level,
+                                                            context,
+                                                            return_value);
                                 }
+                        } else {
+                                if (post_order_visit) {
+                                        status =
+                                            post_order_visit(child_node, level,
+                                                             context,
+                                                             return_value);
+                                }
+                        }
 
-                                status =
-                                    user_function(child_node, level, context,
-                                                  return_value);
-
-                                if (flags & ACPI_NS_WALK_UNLOCK) {
-                                        mutex_status =
-                                            acpi_ut_acquire_mutex
-                                            (ACPI_MTX_NAMESPACE);
-                                        if (ACPI_FAILURE(mutex_status)) {
-                                                return_ACPI_STATUS
-                                                    (mutex_status);
-                                        }
+                        if (flags & ACPI_NS_WALK_UNLOCK) {
+                                mutex_status =
+                                    acpi_ut_acquire_mutex(ACPI_MTX_NAMESPACE);
+                                if (ACPI_FAILURE(mutex_status)) {
+                                        return_ACPI_STATUS(mutex_status);
                                 }
+                        }
 
-                                switch (status) {
-                                case AE_OK:
-                                case AE_CTRL_DEPTH:
+                        switch (status) {
+                        case AE_OK:
+                        case AE_CTRL_DEPTH:
 
-                                        /* Just keep going */
-                                        break;
+                                /* Just keep going */
+                                break;
 
-                                case AE_CTRL_TERMINATE:
+                        case AE_CTRL_TERMINATE:
 
-                                        /* Exit now, with OK status */
+                                /* Exit now, with OK status */
 
-                                        return_ACPI_STATUS(AE_OK);
+                                return_ACPI_STATUS(AE_OK);
 
-                                default:
+                        default:
 
-                                        /* All others are valid exceptions */
+                                /* All others are valid exceptions */
 
-                                        return_ACPI_STATUS(status);
-                                }
+                                return_ACPI_STATUS(status);
+                        }
+                }
+
+                /*
+                 * Depth first search: Attempt to go down another level in the
+                 * namespace if we are allowed to.  Don't go any further if we have
+                 * reached the caller specified maximum depth or if the user
+                 * function has specified that the maximum depth has been reached.
+                 */
+                if (!node_previously_visited &&
+                    (level < max_depth) && (status != AE_CTRL_DEPTH)) {
+                        if (child_node->child) {
+
+                                /* There is at least one child of this node, visit it */
+
+                                level++;
+                                parent_node = child_node;
+                                child_node =
+                                    acpi_ns_get_next_node(parent_node, NULL);
+                                continue;
                         }
+                }
 
-                        /*
-                         * Depth first search: Attempt to go down another level in the
-                         * namespace if we are allowed to.  Don't go any further if we have
-                         * reached the caller specified maximum depth or if the user
-                         * function has specified that the maximum depth has been reached.
-                         */
-                        if ((level < max_depth) && (status != AE_CTRL_DEPTH)) {
-                                if (child_node->child) {
+                /* No more children, re-visit this node */
 
-                                        /* There is at least one child of this node, visit it */
+                if (!node_previously_visited) {
+                        node_previously_visited = TRUE;
+                        continue;
+                }
 
-                                        level++;
-                                        parent_node = child_node;
-                                        child_node = NULL;
-                                }
-                        }
-                } else {
+                /* No more children, visit peers */
+
+                child_node = acpi_ns_get_next_node(parent_node, child_node);
+                if (child_node) {
+                        node_previously_visited = FALSE;
+                }
+
+                /* No peers, re-visit parent */
+
+                else {
                         /*
                          * No more children of this node (acpi_ns_get_next_node failed), go
                          * back upwards in the namespace tree to the node's parent.
@@ -324,6 +356,8 @@ acpi_ns_walk_namespace(acpi_object_type type,
                         level--;
                         child_node = parent_node;
                         parent_node = acpi_ns_get_parent_node(parent_node);
+
+                        node_previously_visited = TRUE;
                 }
         }
 
diff --git a/drivers/acpi/acpica/nsxfeval.c b/drivers/acpi/acpica/nsxfeval.c
index 4929dbdbc8f0..f2bd1da77001 100644
--- a/drivers/acpi/acpica/nsxfeval.c
+++ b/drivers/acpi/acpica/nsxfeval.c
@@ -433,8 +433,11 @@ static void acpi_ns_resolve_references(struct acpi_evaluate_info *info)
  * PARAMETERS:  Type                - acpi_object_type to search for
  *              start_object        - Handle in namespace where search begins
  *              max_depth           - Depth to which search is to reach
- *              user_function       - Called when an object of "Type" is found
- *              Context             - Passed to user function
+ *              pre_order_visit     - Called during tree pre-order visit
+ *                                    when an object of "Type" is found
+ *              post_order_visit    - Called during tree post-order visit
+ *                                    when an object of "Type" is found
+ *              Context             - Passed to user function(s) above
  *              return_value        - Location where return value of
  *                                    user_function is put if terminated early
  *
@@ -443,16 +446,16 @@ static void acpi_ns_resolve_references(struct acpi_evaluate_info *info)
  *
  * DESCRIPTION: Performs a modified depth-first walk of the namespace tree,
  *              starting (and ending) at the object specified by start_handle.
- *              The user_function is called whenever an object that matches
- *              the type parameter is found.  If the user function returns
+ *              The callback function is called whenever an object that matches
+ *              the type parameter is found. If the callback function returns
  *              a non-zero value, the search is terminated immediately and this
  *              value is returned to the caller.
  *
  *              The point of this procedure is to provide a generic namespace
  *              walk routine that can be called from multiple places to
- *              provide multiple services;  the User Function can be tailored
- *              to each task, whether it is a print function, a compare
- *              function, etc.
+ *              provide multiple services; the callback function(s) can be
+ *              tailored to each task, whether it is a print function,
+ *              a compare function, etc.
  *
  ******************************************************************************/
 
@@ -460,7 +463,8 @@ acpi_status
 acpi_walk_namespace(acpi_object_type type,
                     acpi_handle start_object,
                     u32 max_depth,
-                    acpi_walk_callback user_function,
+                    acpi_walk_callback pre_order_visit,
+                    acpi_walk_callback post_order_visit,
                     void *context, void **return_value)
 {
         acpi_status status;
@@ -469,7 +473,8 @@ acpi_walk_namespace(acpi_object_type type,
 
         /* Parameter validation */
 
-        if ((type > ACPI_TYPE_LOCAL_MAX) || (!max_depth) || (!user_function)) {
+        if ((type > ACPI_TYPE_LOCAL_MAX) ||
+            (!max_depth) || (!pre_order_visit && !post_order_visit)) {
                 return_ACPI_STATUS(AE_BAD_PARAMETER);
         }
 
@@ -501,8 +506,9 @@ acpi_walk_namespace(acpi_object_type type,
         }
 
         status = acpi_ns_walk_namespace(type, start_object, max_depth,
-                                        ACPI_NS_WALK_UNLOCK, user_function,
-                                        context, return_value);
+                                        ACPI_NS_WALK_UNLOCK, pre_order_visit,
+                                        post_order_visit, context,
+                                        return_value);
 
         (void)acpi_ut_release_mutex(ACPI_MTX_NAMESPACE);
 
@@ -681,8 +687,8 @@ acpi_get_devices(const char *HID,
 
         status = acpi_ns_walk_namespace(ACPI_TYPE_DEVICE, ACPI_ROOT_OBJECT,
                                         ACPI_UINT32_MAX, ACPI_NS_WALK_UNLOCK,
-                                        acpi_ns_get_device_callback, &info,
-                                        return_value);
+                                        acpi_ns_get_device_callback, NULL,
+                                        &info, return_value);
 
         (void)acpi_ut_release_mutex(ACPI_MTX_NAMESPACE);
         return_ACPI_STATUS(status);