diff options
author | Vivek Goyal <vgoyal@redhat.com> | 2012-10-03 16:57:00 -0400 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2013-01-09 11:05:09 -0500 |
commit | 1f23f12151ab508728dd5fca12180e2fce6c6949 (patch) | |
tree | ebd8f061f62d381d9f346f4d720f0a6288143eb6 /block/cfq-iosched.c | |
parent | 6d816ec7c83871da7c2472af7479d2438e641052 (diff) |
cfq-iosched: Get rid of unnecessary local variable
Use of local varibale "n" seems to be unnecessary. Remove it. This brings
it inline with function __cfq_group_st_add(), which is also doing the
similar operation of adding a group to a rb tree.
No functionality change here.
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Acked-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'block/cfq-iosched.c')
-rw-r--r-- | block/cfq-iosched.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c index e34e142b6dbb..5ad4cae1beb2 100644 --- a/block/cfq-iosched.c +++ b/block/cfq-iosched.c | |||
@@ -1658,8 +1658,6 @@ static void cfq_service_tree_add(struct cfq_data *cfqd, struct cfq_queue *cfqq, | |||
1658 | cfqq->service_tree = st; | 1658 | cfqq->service_tree = st; |
1659 | p = &st->rb.rb_node; | 1659 | p = &st->rb.rb_node; |
1660 | while (*p) { | 1660 | while (*p) { |
1661 | struct rb_node **n; | ||
1662 | |||
1663 | parent = *p; | 1661 | parent = *p; |
1664 | __cfqq = rb_entry(parent, struct cfq_queue, rb_node); | 1662 | __cfqq = rb_entry(parent, struct cfq_queue, rb_node); |
1665 | 1663 | ||
@@ -1667,13 +1665,11 @@ static void cfq_service_tree_add(struct cfq_data *cfqd, struct cfq_queue *cfqq, | |||
1667 | * sort by key, that represents service time. | 1665 | * sort by key, that represents service time. |
1668 | */ | 1666 | */ |
1669 | if (time_before(rb_key, __cfqq->rb_key)) | 1667 | if (time_before(rb_key, __cfqq->rb_key)) |
1670 | n = &(*p)->rb_left; | 1668 | p = &parent->rb_left; |
1671 | else { | 1669 | else { |
1672 | n = &(*p)->rb_right; | 1670 | p = &parent->rb_right; |
1673 | left = 0; | 1671 | left = 0; |
1674 | } | 1672 | } |
1675 | |||
1676 | p = n; | ||
1677 | } | 1673 | } |
1678 | 1674 | ||
1679 | if (left) | 1675 | if (left) |