aboutsummaryrefslogtreecommitdiffstats
path: root/block/blk-flush.c
diff options
context:
space:
mode:
authorMing Lei <ming.lei@canoical.com>2014-09-17 05:47:58 -0400
committerJens Axboe <axboe@fb.com>2014-09-22 14:00:07 -0400
commit2edd2c740b2918eb0a9a1fe1b69678b903769ec2 (patch)
tree36df228ed4b404fdf1b53b966ccc914ad5555df3 /block/blk-flush.c
parent0152fb6b57c4fae769ee75ea2ae670f4ff39fba9 (diff)
blk-mq: remove unnecessary blk_clear_rq_complete()
This patch removes two unnecessary blk_clear_rq_complete(), the REQ_ATOM_COMPLETE flag is cleared inside blk_mq_start_request(), so: - The blk_clear_rq_complete() in blk_flush_restore_request() needn't because the request will be freed later, and clearing it here may open a small race window with timeout. - The blk_clear_rq_complete() in blk_mq_requeue_request() isn't necessary too, even though REQ_ATOM_STARTED is cleared in __blk_mq_requeue_request(), in theory it still may cause a small race window with timeout since the two clear_bit() may be reordered. Signed-off-by: Ming Lei <ming.lei@canoical.com> Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'block/blk-flush.c')
-rw-r--r--block/blk-flush.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/block/blk-flush.c b/block/blk-flush.c
index 698e6926388c..c8e25768f2e1 100644
--- a/block/blk-flush.c
+++ b/block/blk-flush.c
@@ -126,8 +126,6 @@ static void blk_flush_restore_request(struct request *rq)
126 /* make @rq a normal request */ 126 /* make @rq a normal request */
127 rq->cmd_flags &= ~REQ_FLUSH_SEQ; 127 rq->cmd_flags &= ~REQ_FLUSH_SEQ;
128 rq->end_io = rq->flush.saved_end_io; 128 rq->end_io = rq->flush.saved_end_io;
129
130 blk_clear_rq_complete(rq);
131} 129}
132 130
133static bool blk_flush_queue_rq(struct request *rq, bool add_front) 131static bool blk_flush_queue_rq(struct request *rq, bool add_front)