aboutsummaryrefslogtreecommitdiffstats
path: root/arch
diff options
context:
space:
mode:
authorJean Delvare <jdelvare@suse.de>2012-10-02 10:42:36 -0400
committerMichal Marek <mmarek@suse.cz>2012-10-03 03:03:24 -0400
commitb1e0d8b70fa31821ebca3965f2ef8619d7c5e316 (patch)
tree4df17a3e10de030701ccf0868da1a94c1063b07d /arch
parentfe04ddf7c2910362f3817c8156e41cbd6c0ee35d (diff)
kbuild: Fix gcc -x syntax
The correct syntax for gcc -x is "gcc -x assembler", not "gcc -xassembler". Even though the latter happens to work, the former is what is documented in the manual page and thus what gcc wrappers such as icecream do expect. This isn't a cosmetic change. The missing space prevents icecream from recognizing compilation tasks it can't handle, leading to silent kernel miscompilations. Besides me, credits go to Michael Matz and Dirk Mueller for investigating the miscompilation issue and tracking it down to this incorrect -x parameter syntax. Signed-off-by: Jean Delvare <jdelvare@suse.de> Acked-by: Ingo Molnar <mingo@kernel.org> Cc: stable@vger.kernel.org Cc: Bernhard Walle <bernhard@bwalle.de> Cc: Michal Marek <mmarek@suse.cz> Cc: Ralf Baechle <ralf@linux-mips.org> Signed-off-by: Michal Marek <mmarek@suse.cz>
Diffstat (limited to 'arch')
-rw-r--r--arch/mips/Makefile2
-rw-r--r--arch/mips/kernel/Makefile2
-rw-r--r--arch/x86/Makefile2
3 files changed, 3 insertions, 3 deletions
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index 764e37a9dbb3..654b1ad39f05 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -225,7 +225,7 @@ KBUILD_CPPFLAGS += -DDATAOFFSET=$(if $(dataoffset-y),$(dataoffset-y),0)
225LDFLAGS += -m $(ld-emul) 225LDFLAGS += -m $(ld-emul)
226 226
227ifdef CONFIG_MIPS 227ifdef CONFIG_MIPS
228CHECKFLAGS += $(shell $(CC) $(KBUILD_CFLAGS) -dM -E -xc /dev/null | \ 228CHECKFLAGS += $(shell $(CC) $(KBUILD_CFLAGS) -dM -E -x c /dev/null | \
229 egrep -vw '__GNUC_(|MINOR_|PATCHLEVEL_)_' | \ 229 egrep -vw '__GNUC_(|MINOR_|PATCHLEVEL_)_' | \
230 sed -e "s/^\#define /-D'/" -e "s/ /'='/" -e "s/$$/'/") 230 sed -e "s/^\#define /-D'/" -e "s/ /'='/" -e "s/$$/'/")
231ifdef CONFIG_64BIT 231ifdef CONFIG_64BIT
diff --git a/arch/mips/kernel/Makefile b/arch/mips/kernel/Makefile
index fdaf65e1a99d..c6136cb4cd40 100644
--- a/arch/mips/kernel/Makefile
+++ b/arch/mips/kernel/Makefile
@@ -104,7 +104,7 @@ obj-$(CONFIG_MIPS_MACHINE) += mips_machine.o
104 104
105obj-$(CONFIG_OF) += prom.o 105obj-$(CONFIG_OF) += prom.o
106 106
107CFLAGS_cpu-bugs64.o = $(shell if $(CC) $(KBUILD_CFLAGS) -Wa,-mdaddi -c -o /dev/null -xc /dev/null >/dev/null 2>&1; then echo "-DHAVE_AS_SET_DADDI"; fi) 107CFLAGS_cpu-bugs64.o = $(shell if $(CC) $(KBUILD_CFLAGS) -Wa,-mdaddi -c -o /dev/null -x c /dev/null >/dev/null 2>&1; then echo "-DHAVE_AS_SET_DADDI"; fi)
108 108
109obj-$(CONFIG_HAVE_STD_PC_SERIAL_PORT) += 8250-platform.o 109obj-$(CONFIG_HAVE_STD_PC_SERIAL_PORT) += 8250-platform.o
110 110
diff --git a/arch/x86/Makefile b/arch/x86/Makefile
index b0c5276861ec..cb8ac935df82 100644
--- a/arch/x86/Makefile
+++ b/arch/x86/Makefile
@@ -88,7 +88,7 @@ endif
88ifdef CONFIG_X86_X32 88ifdef CONFIG_X86_X32
89 x32_ld_ok := $(call try-run,\ 89 x32_ld_ok := $(call try-run,\
90 /bin/echo -e '1: .quad 1b' | \ 90 /bin/echo -e '1: .quad 1b' | \
91 $(CC) $(KBUILD_AFLAGS) -c -xassembler -o "$$TMP" - && \ 91 $(CC) $(KBUILD_AFLAGS) -c -x assembler -o "$$TMP" - && \
92 $(OBJCOPY) -O elf32-x86-64 "$$TMP" "$$TMPO" && \ 92 $(OBJCOPY) -O elf32-x86-64 "$$TMP" "$$TMPO" && \
93 $(LD) -m elf32_x86_64 "$$TMPO" -o "$$TMP",y,n) 93 $(LD) -m elf32_x86_64 "$$TMPO" -o "$$TMP",y,n)
94 ifeq ($(x32_ld_ok),y) 94 ifeq ($(x32_ld_ok),y)