Merge branch 'pm-domains' into pm-for-linus

* pm-domains:
  PM / shmobile: Allow the A4R domain to be turned off at run time
  PM / input / touchscreen: Make st1232 use device PM QoS constraints
  PM / QoS: Introduce dev_pm_qos_add_ancestor_request()
  PM / shmobile: Remove the stay_on flag from SH7372's PM domains
  PM / shmobile: Don't include SH7372's INTCS in syscore suspend/resume
  PM / shmobile: Add support for the sh7372 A4S power domain / sleep mode
  ARM: S3C64XX: Implement basic power domain support
  PM / shmobile: Use common always on power domain governor
  PM / Domains: Provide an always on power domain governor
  PM / Domains: Fix default system suspend/resume operations
  PM / Domains: Make it possible to assign names to generic PM domains
  PM / Domains: fix compilation failure for CONFIG_PM_GENERIC_DOMAINS unset
  PM / Domains: Automatically update overoptimistic latency information
  PM / Domains: Add default power off governor function (v4)
  PM / Domains: Add device stop governor function (v4)
  PM / Domains: Rework system suspend callback routines (v2)
  PM / Domains: Introduce "save/restore state" device callbacks
  PM / Domains: Make it possible to use per-device domain callbacks

10 files changed, 400 insertions, 68 deletions

diff --git a/arch/arm/mach-s3c64xx/Kconfig b/arch/arm/mach-s3c64xx/Kconfig
index 5552e048c2be..381586c7b1b2 100644
--- a/arch/arm/mach-s3c64xx/Kconfig
+++ b/arch/arm/mach-s3c64xx/Kconfig
@@ -8,6 +8,7 @@ config PLAT_S3C64XX
         bool
         depends on ARCH_S3C64XX
         select SAMSUNG_WAKEMASK
+        select PM_GENERIC_DOMAINS
         default y
         help
           Base platform code for any Samsung S3C64XX device
diff --git a/arch/arm/mach-s3c64xx/mach-crag6410.c b/arch/arm/mach-s3c64xx/mach-crag6410.c
index d04b65448510..707b9b22f9fd 100644
--- a/arch/arm/mach-s3c64xx/mach-crag6410.c
+++ b/arch/arm/mach-s3c64xx/mach-crag6410.c
@@ -704,7 +704,7 @@ static void __init crag6410_machine_init(void)
 
         regulator_has_full_constraints();
 
-        s3c_pm_init();
+        s3c64xx_pm_init();
 }
 
 MACHINE_START(WLF_CRAGG_6410, "Wolfson Cragganmore 6410")
diff --git a/arch/arm/mach-s3c64xx/pm.c b/arch/arm/mach-s3c64xx/pm.c
index b375cd5c47cb..7d3e81b9dd06 100644
--- a/arch/arm/mach-s3c64xx/pm.c
+++ b/arch/arm/mach-s3c64xx/pm.c
@@ -17,10 +17,12 @@
 #include <linux/serial_core.h>
 #include <linux/io.h>
 #include <linux/gpio.h>
+#include <linux/pm_domain.h>
 
 #include <mach/map.h>
 #include <mach/irqs.h>
 
+#include <plat/devs.h>
 #include <plat/pm.h>
 #include <plat/wakeup-mask.h>
 
@@ -31,6 +33,148 @@
 #include <mach/regs-gpio-memport.h>
 #include <mach/regs-modem.h>
 
+struct s3c64xx_pm_domain {
+        char *const name;
+        u32 ena;
+        u32 pwr_stat;
+        struct generic_pm_domain pd;
+};
+
+static int s3c64xx_pd_off(struct generic_pm_domain *domain)
+{
+        struct s3c64xx_pm_domain *pd;
+        u32 val;
+
+        pd = container_of(domain, struct s3c64xx_pm_domain, pd);
+
+        val = __raw_readl(S3C64XX_NORMAL_CFG);
+        val &= ~(pd->ena);
+        __raw_writel(val, S3C64XX_NORMAL_CFG);
+
+        return 0;
+}
+
+static int s3c64xx_pd_on(struct generic_pm_domain *domain)
+{
+        struct s3c64xx_pm_domain *pd;
+        u32 val;
+        long retry = 1000000L;
+
+        pd = container_of(domain, struct s3c64xx_pm_domain, pd);
+
+        val = __raw_readl(S3C64XX_NORMAL_CFG);
+        val |= pd->ena;
+        __raw_writel(val, S3C64XX_NORMAL_CFG);
+
+        /* Not all domains provide power status readback */
+        if (pd->pwr_stat) {
+                do {
+                        cpu_relax();
+                        if (__raw_readl(S3C64XX_BLK_PWR_STAT) & pd->pwr_stat)
+                                break;
+                } while (retry--);
+
+                if (!retry) {
+                        pr_err("Failed to start domain %s\n", pd->name);
+                        return -EBUSY;
+                }
+        }
+
+        return 0;
+}
+
+static struct s3c64xx_pm_domain s3c64xx_pm_irom = {
+        .name = "IROM",
+        .ena = S3C64XX_NORMALCFG_IROM_ON,
+        .pd = {
+                .power_off = s3c64xx_pd_off,
+                .power_on = s3c64xx_pd_on,
+        },
+};
+
+static struct s3c64xx_pm_domain s3c64xx_pm_etm = {
+        .name = "ETM",
+        .ena = S3C64XX_NORMALCFG_DOMAIN_ETM_ON,
+        .pwr_stat = S3C64XX_BLKPWRSTAT_ETM,
+        .pd = {
+                .power_off = s3c64xx_pd_off,
+                .power_on = s3c64xx_pd_on,
+        },
+};
+
+static struct s3c64xx_pm_domain s3c64xx_pm_s = {
+        .name = "S",
+        .ena = S3C64XX_NORMALCFG_DOMAIN_S_ON,
+        .pwr_stat = S3C64XX_BLKPWRSTAT_S,
+        .pd = {
+                .power_off = s3c64xx_pd_off,
+                .power_on = s3c64xx_pd_on,
+        },
+};
+
+static struct s3c64xx_pm_domain s3c64xx_pm_f = {
+        .name = "F",
+        .ena = S3C64XX_NORMALCFG_DOMAIN_F_ON,
+        .pwr_stat = S3C64XX_BLKPWRSTAT_F,
+        .pd = {
+                .power_off = s3c64xx_pd_off,
+                .power_on = s3c64xx_pd_on,
+        },
+};
+
+static struct s3c64xx_pm_domain s3c64xx_pm_p = {
+        .name = "P",
+        .ena = S3C64XX_NORMALCFG_DOMAIN_P_ON,
+        .pwr_stat = S3C64XX_BLKPWRSTAT_P,
+        .pd = {
+                .power_off = s3c64xx_pd_off,
+                .power_on = s3c64xx_pd_on,
+        },
+};
+
+static struct s3c64xx_pm_domain s3c64xx_pm_i = {
+        .name = "I",
+        .ena = S3C64XX_NORMALCFG_DOMAIN_I_ON,
+        .pwr_stat = S3C64XX_BLKPWRSTAT_I,
+        .pd = {
+                .power_off = s3c64xx_pd_off,
+                .power_on = s3c64xx_pd_on,
+        },
+};
+
+static struct s3c64xx_pm_domain s3c64xx_pm_g = {
+        .name = "G",
+        .ena = S3C64XX_NORMALCFG_DOMAIN_G_ON,
+        .pd = {
+                .power_off = s3c64xx_pd_off,
+                .power_on = s3c64xx_pd_on,
+        },
+};
+
+static struct s3c64xx_pm_domain s3c64xx_pm_v = {
+        .name = "V",
+        .ena = S3C64XX_NORMALCFG_DOMAIN_V_ON,
+        .pwr_stat = S3C64XX_BLKPWRSTAT_V,
+        .pd = {
+                .power_off = s3c64xx_pd_off,
+                .power_on = s3c64xx_pd_on,
+        },
+};
+
+static struct s3c64xx_pm_domain *s3c64xx_always_on_pm_domains[] = {
+        &s3c64xx_pm_irom,
+};
+
+static struct s3c64xx_pm_domain *s3c64xx_pm_domains[] = {
+        &s3c64xx_pm_etm,
+        &s3c64xx_pm_g,
+        &s3c64xx_pm_v,
+        &s3c64xx_pm_i,
+        &s3c64xx_pm_p,
+        &s3c64xx_pm_s,
+        &s3c64xx_pm_f,
+};
+
 #ifdef CONFIG_S3C_PM_DEBUG_LED_SMDK
 void s3c_pm_debug_smdkled(u32 set, u32 clear)
 {
@@ -89,6 +233,8 @@ static struct sleep_save misc_save[] = {
 
         SAVE_ITEM(S3C64XX_SDMA_SEL),
         SAVE_ITEM(S3C64XX_MODEM_MIFPCON),
+
+        SAVE_ITEM(S3C64XX_NORMAL_CFG),
 };
 
 void s3c_pm_configure_extint(void)
@@ -179,7 +325,26 @@ static void s3c64xx_pm_prepare(void)
         __raw_writel(__raw_readl(S3C64XX_WAKEUP_STAT), S3C64XX_WAKEUP_STAT);
 }
 
-static int s3c64xx_pm_init(void)
+int __init s3c64xx_pm_init(void)
+{
+        int i;
+
+        s3c_pm_init();
+
+        for (i = 0; i < ARRAY_SIZE(s3c64xx_always_on_pm_domains); i++)
+                pm_genpd_init(&s3c64xx_always_on_pm_domains[i]->pd,
+                              &pm_domain_always_on_gov, false);
+
+        for (i = 0; i < ARRAY_SIZE(s3c64xx_pm_domains); i++)
+                pm_genpd_init(&s3c64xx_pm_domains[i]->pd, NULL, false);
+
+        if (dev_get_platdata(&s3c_device_fb.dev))
+                pm_genpd_add_device(&s3c64xx_pm_f.pd, &s3c_device_fb.dev);
+
+        return 0;
+}
+
+static __init int s3c64xx_pm_initcall(void)
 {
         pm_cpu_prep = s3c64xx_pm_prepare;
         pm_cpu_sleep = s3c64xx_cpu_suspend;
@@ -198,5 +363,12 @@ static int s3c64xx_pm_init(void)
 
         return 0;
 }
+arch_initcall(s3c64xx_pm_initcall);
+
+static __init int s3c64xx_pm_late_initcall(void)
+{
+        pm_genpd_poweroff_unused();
 
-arch_initcall(s3c64xx_pm_init);
+        return 0;
+}
+late_initcall(s3c64xx_pm_late_initcall);
diff --git a/arch/arm/mach-shmobile/include/mach/common.h b/arch/arm/mach-shmobile/include/mach/common.h
index 834bd6cd508f..4807623fb71c 100644
--- a/arch/arm/mach-shmobile/include/mach/common.h
+++ b/arch/arm/mach-shmobile/include/mach/common.h
@@ -35,8 +35,8 @@ extern void sh7372_add_standard_devices(void);
 extern void sh7372_clock_init(void);
 extern void sh7372_pinmux_init(void);
 extern void sh7372_pm_init(void);
-extern void sh7372_resume_core_standby_a3sm(void);
-extern int sh7372_do_idle_a3sm(unsigned long unused);
+extern void sh7372_resume_core_standby_sysc(void);
+extern int sh7372_do_idle_sysc(unsigned long sleep_mode);
 extern struct clk sh7372_extal1_clk;
 extern struct clk sh7372_extal2_clk;
 
diff --git a/arch/arm/mach-shmobile/include/mach/sh7372.h b/arch/arm/mach-shmobile/include/mach/sh7372.h
index 84532f9629b2..8254ab86f6cd 100644
--- a/arch/arm/mach-shmobile/include/mach/sh7372.h
+++ b/arch/arm/mach-shmobile/include/mach/sh7372.h
@@ -480,11 +480,10 @@ struct platform_device;
 struct sh7372_pm_domain {
         struct generic_pm_domain genpd;
         struct dev_power_governor *gov;
-        void (*suspend)(void);
+        int (*suspend)(void);
         void (*resume)(void);
         unsigned int bit_shift;
         bool no_debug;
-        bool stay_on;
 };
 
 static inline struct sh7372_pm_domain *to_sh7372_pd(struct generic_pm_domain *d)
@@ -499,6 +498,7 @@ extern struct sh7372_pm_domain sh7372_d4;
 extern struct sh7372_pm_domain sh7372_a4r;
 extern struct sh7372_pm_domain sh7372_a3rv;
 extern struct sh7372_pm_domain sh7372_a3ri;
+extern struct sh7372_pm_domain sh7372_a4s;
 extern struct sh7372_pm_domain sh7372_a3sp;
 extern struct sh7372_pm_domain sh7372_a3sg;
 
@@ -515,5 +515,7 @@ extern void sh7372_pm_add_subdomain(struct sh7372_pm_domain *sh7372_pd,
 
 extern void sh7372_intcs_suspend(void);
 extern void sh7372_intcs_resume(void);
+extern void sh7372_intca_suspend(void);
+extern void sh7372_intca_resume(void);
 
 #endif /* __ASM_SH7372_H__ */
diff --git a/arch/arm/mach-shmobile/intc-sh7372.c b/arch/arm/mach-shmobile/intc-sh7372.c
index 2d8856df80e2..89afcaba99a1 100644
--- a/arch/arm/mach-shmobile/intc-sh7372.c
+++ b/arch/arm/mach-shmobile/intc-sh7372.c
@@ -535,6 +535,7 @@ static struct resource intcs_resources[] __initdata = {
 static struct intc_desc intcs_desc __initdata = {
         .name = "sh7372-intcs",
         .force_enable = ENABLED_INTCS,
+        .skip_syscore_suspend = true,
         .resource = intcs_resources,
         .num_resources = ARRAY_SIZE(intcs_resources),
         .hw = INTC_HW_DESC(intcs_vectors, intcs_groups, intcs_mask_registers,
@@ -611,3 +612,52 @@ void sh7372_intcs_resume(void)
         for (k = 0x80; k <= 0x9c; k += 4)
                 __raw_writeb(ffd5[k], intcs_ffd5 + k);
 }
+
+static unsigned short e694[0x200];
+static unsigned short e695[0x200];
+
+void sh7372_intca_suspend(void)
+{
+        int k;
+
+        for (k = 0x00; k <= 0x38; k += 4)
+                e694[k] = __raw_readw(0xe6940000 + k);
+
+        for (k = 0x80; k <= 0xb4; k += 4)
+                e694[k] = __raw_readb(0xe6940000 + k);
+
+        for (k = 0x180; k <= 0x1b4; k += 4)
+                e694[k] = __raw_readb(0xe6940000 + k);
+
+        for (k = 0x00; k <= 0x50; k += 4)
+                e695[k] = __raw_readw(0xe6950000 + k);
+
+        for (k = 0x80; k <= 0xa8; k += 4)
+                e695[k] = __raw_readb(0xe6950000 + k);
+
+        for (k = 0x180; k <= 0x1a8; k += 4)
+                e695[k] = __raw_readb(0xe6950000 + k);
+}
+
+void sh7372_intca_resume(void)
+{
+        int k;
+
+        for (k = 0x00; k <= 0x38; k += 4)
+                __raw_writew(e694[k], 0xe6940000 + k);
+
+        for (k = 0x80; k <= 0xb4; k += 4)
+                __raw_writeb(e694[k], 0xe6940000 + k);
+
+        for (k = 0x180; k <= 0x1b4; k += 4)
+                __raw_writeb(e694[k], 0xe6940000 + k);
+
+        for (k = 0x00; k <= 0x50; k += 4)
+                __raw_writew(e695[k], 0xe6950000 + k);
+
+        for (k = 0x80; k <= 0xa8; k += 4)
+                __raw_writeb(e695[k], 0xe6950000 + k);
+
+        for (k = 0x180; k <= 0x1a8; k += 4)
+                __raw_writeb(e695[k], 0xe6950000 + k);
+}
diff --git a/arch/arm/mach-shmobile/pm-sh7372.c b/arch/arm/mach-shmobile/pm-sh7372.c
index 34bbcbfb1706..77b8fc12fc2f 100644
--- a/arch/arm/mach-shmobile/pm-sh7372.c
+++ b/arch/arm/mach-shmobile/pm-sh7372.c
@@ -82,11 +82,12 @@ static int pd_power_down(struct generic_pm_domain *genpd)
         struct sh7372_pm_domain *sh7372_pd = to_sh7372_pd(genpd);
         unsigned int mask = 1 << sh7372_pd->bit_shift;
 
-        if (sh7372_pd->suspend)
-                sh7372_pd->suspend();
+        if (sh7372_pd->suspend) {
+                int ret = sh7372_pd->suspend();
 
-        if (sh7372_pd->stay_on)
-                return 0;
+                if (ret)
+                        return ret;
+        }
 
         if (__raw_readl(PSTR) & mask) {
                 unsigned int retry_count;
@@ -101,8 +102,8 @@ static int pd_power_down(struct generic_pm_domain *genpd)
         }
 
         if (!sh7372_pd->no_debug)
-                pr_debug("sh7372 power domain down 0x%08x -> PSTR = 0x%08x\n",
-                         mask, __raw_readl(PSTR));
+                pr_debug("%s: Power off, 0x%08x -> PSTR = 0x%08x\n",
+                         genpd->name, mask, __raw_readl(PSTR));
 
         return 0;
 }
@@ -113,9 +114,6 @@ static int __pd_power_up(struct sh7372_pm_domain *sh7372_pd, bool do_resume)
         unsigned int retry_count;
         int ret = 0;
 
-        if (sh7372_pd->stay_on)
-                goto out;
-
         if (__raw_readl(PSTR) & mask)
                 goto out;
 
@@ -133,8 +131,8 @@ static int __pd_power_up(struct sh7372_pm_domain *sh7372_pd, bool do_resume)
                 ret = -EIO;
 
         if (!sh7372_pd->no_debug)
-                pr_debug("sh7372 power domain up 0x%08x -> PSTR = 0x%08x\n",
-                         mask, __raw_readl(PSTR));
+                pr_debug("%s: Power on, 0x%08x -> PSTR = 0x%08x\n",
+                         sh7372_pd->genpd.name, mask, __raw_readl(PSTR));
 
  out:
         if (ret == 0 && sh7372_pd->resume && do_resume)
@@ -148,35 +146,60 @@ static int pd_power_up(struct generic_pm_domain *genpd)
          return __pd_power_up(to_sh7372_pd(genpd), true);
 }
 
-static void sh7372_a4r_suspend(void)
+static int sh7372_a4r_suspend(void)
 {
         sh7372_intcs_suspend();
         __raw_writel(0x300fffff, WUPRMSK); /* avoid wakeup */
+        return 0;
 }
 
 static bool pd_active_wakeup(struct device *dev)
 {
-        return true;
+        bool (*active_wakeup)(struct device *dev);
+
+        active_wakeup = dev_gpd_data(dev)->ops.active_wakeup;
+        return active_wakeup ? active_wakeup(dev) : true;
 }
 
-static bool sh7372_power_down_forbidden(struct dev_pm_domain *domain)
+static int sh7372_stop_dev(struct device *dev)
 {
-        return false;
+        int (*stop)(struct device *dev);
+
+        stop = dev_gpd_data(dev)->ops.stop;
+        if (stop) {
+                int ret = stop(dev);
+                if (ret)
+                        return ret;
+        }
+        return pm_clk_suspend(dev);
 }
 
-struct dev_power_governor sh7372_always_on_gov = {
-        .power_down_ok = sh7372_power_down_forbidden,
-};
+static int sh7372_start_dev(struct device *dev)
+{
+        int (*start)(struct device *dev);
+        int ret;
+
+        ret = pm_clk_resume(dev);
+        if (ret)
+                return ret;
+
+        start = dev_gpd_data(dev)->ops.start;
+        if (start)
+                ret = start(dev);
+
+        return ret;
+}
 
 void sh7372_init_pm_domain(struct sh7372_pm_domain *sh7372_pd)
 {
         struct generic_pm_domain *genpd = &sh7372_pd->genpd;
+        struct dev_power_governor *gov = sh7372_pd->gov;
 
-        pm_genpd_init(genpd, sh7372_pd->gov, false);
-        genpd->stop_device = pm_clk_suspend;
-        genpd->start_device = pm_clk_resume;
+        pm_genpd_init(genpd, gov ? : &simple_qos_governor, false);
+        genpd->dev_ops.stop = sh7372_stop_dev;
+        genpd->dev_ops.start = sh7372_start_dev;
+        genpd->dev_ops.active_wakeup = pd_active_wakeup;
         genpd->dev_irq_safe = true;
-        genpd->active_wakeup = pd_active_wakeup;
         genpd->power_off = pd_power_down;
         genpd->power_on = pd_power_up;
         __pd_power_up(sh7372_pd, false);
@@ -199,48 +222,73 @@ void sh7372_pm_add_subdomain(struct sh7372_pm_domain *sh7372_pd,
 }
 
 struct sh7372_pm_domain sh7372_a4lc = {
+        .genpd.name = "A4LC",
         .bit_shift = 1,
 };
 
 struct sh7372_pm_domain sh7372_a4mp = {
+        .genpd.name = "A4MP",
         .bit_shift = 2,
 };
 
 struct sh7372_pm_domain sh7372_d4 = {
+        .genpd.name = "D4",
         .bit_shift = 3,
 };
 
 struct sh7372_pm_domain sh7372_a4r = {
+        .genpd.name = "A4R",
         .bit_shift = 5,
-        .gov = &sh7372_always_on_gov,
         .suspend = sh7372_a4r_suspend,
         .resume = sh7372_intcs_resume,
-        .stay_on = true,
 };
 
 struct sh7372_pm_domain sh7372_a3rv = {
+        .genpd.name = "A3RV",
         .bit_shift = 6,
 };
 
 struct sh7372_pm_domain sh7372_a3ri = {
+        .genpd.name = "A3RI",
         .bit_shift = 8,
 };
 
-struct sh7372_pm_domain sh7372_a3sp = {
-        .bit_shift = 11,
-        .gov = &sh7372_always_on_gov,
+static int sh7372_a4s_suspend(void)
+{
+        /*
+         * The A4S domain contains the CPU core and therefore it should
+         * only be turned off if the CPU is in use.
+         */
+        return -EBUSY;
+}
+
+struct sh7372_pm_domain sh7372_a4s = {
+        .genpd.name = "A4S",
+        .bit_shift = 10,
+        .gov = &pm_domain_always_on_gov,
         .no_debug = true,
+        .suspend = sh7372_a4s_suspend,
 };
 
-static void sh7372_a3sp_init(void)
+static int sh7372_a3sp_suspend(void)
 {
-        /* serial consoles make use of SCIF hardware located in A3SP,
+        /*
+         * Serial consoles make use of SCIF hardware located in A3SP,
          * keep such power domain on if "no_console_suspend" is set.
          */
-        sh7372_a3sp.stay_on = !console_suspend_enabled;
+        return console_suspend_enabled ? -EBUSY : 0;
 }
 
+struct sh7372_pm_domain sh7372_a3sp = {
+        .genpd.name = "A3SP",
+        .bit_shift = 11,
+        .gov = &pm_domain_always_on_gov,
+        .no_debug = true,
+        .suspend = sh7372_a3sp_suspend,
+};
+
 struct sh7372_pm_domain sh7372_a3sg = {
+        .genpd.name = "A3SG",
         .bit_shift = 13,
 };
 
@@ -257,11 +305,16 @@ static int sh7372_do_idle_core_standby(unsigned long unused)
         return 0;
 }
 
-static void sh7372_enter_core_standby(void)
+static void sh7372_set_reset_vector(unsigned long address)
 {
         /* set reset vector, translate 4k */
-        __raw_writel(__pa(sh7372_resume_core_standby_a3sm), SBAR);
+        __raw_writel(address, SBAR);
         __raw_writel(0, APARMBAREA);
+}
+
+static void sh7372_enter_core_standby(void)
+{
+        sh7372_set_reset_vector(__pa(sh7372_resume_core_standby_sysc));
 
         /* enter sleep mode with SYSTBCR to 0x10 */
         __raw_writel(0x10, SYSTBCR);
@@ -274,27 +327,22 @@ static void sh7372_enter_core_standby(void)
 #endif
 
 #ifdef CONFIG_SUSPEND
-static void sh7372_enter_a3sm_common(int pllc0_on)
+static void sh7372_enter_sysc(int pllc0_on, unsigned long sleep_mode)
 {
-        /* set reset vector, translate 4k */
-        __raw_writel(__pa(sh7372_resume_core_standby_a3sm), SBAR);
-        __raw_writel(0, APARMBAREA);
-
         if (pllc0_on)
                 __raw_writel(0, PLLC01STPCR);
         else
                 __raw_writel(1 << 28, PLLC01STPCR);
 
-        __raw_writel(0, PDNSEL); /* power-down A3SM only, not A4S */
         __raw_readl(WUPSFAC); /* read wakeup int. factor before sleep */
-        cpu_suspend(0, sh7372_do_idle_a3sm);
+        cpu_suspend(sleep_mode, sh7372_do_idle_sysc);
         __raw_readl(WUPSFAC); /* read wakeup int. factor after wakeup */
 
          /* disable reset vector translation */
         __raw_writel(0, SBAR);
 }
 
-static int sh7372_a3sm_valid(unsigned long *mskp, unsigned long *msk2p)
+static int sh7372_sysc_valid(unsigned long *mskp, unsigned long *msk2p)
 {
         unsigned long mstpsr0, mstpsr1, mstpsr2, mstpsr3, mstpsr4;
         unsigned long msk, msk2;
@@ -382,7 +430,7 @@ static void sh7372_icr_to_irqcr(unsigned long icr, u16 *irqcr1p, u16 *irqcr2p)
         *irqcr2p = irqcr2;
 }
 
-static void sh7372_setup_a3sm(unsigned long msk, unsigned long msk2)
+static void sh7372_setup_sysc(unsigned long msk, unsigned long msk2)
 {
         u16 irqcrx_low, irqcrx_high, irqcry_low, irqcry_high;
         unsigned long tmp;
@@ -415,6 +463,22 @@ static void sh7372_setup_a3sm(unsigned long msk, unsigned long msk2)
         __raw_writel((irqcrx_high << 16) | irqcrx_low, IRQCR3);
         __raw_writel((irqcry_high << 16) | irqcry_low, IRQCR4);
 }
+
+static void sh7372_enter_a3sm_common(int pllc0_on)
+{
+        sh7372_set_reset_vector(__pa(sh7372_resume_core_standby_sysc));
+        sh7372_enter_sysc(pllc0_on, 1 << 12);
+}
+
+static void sh7372_enter_a4s_common(int pllc0_on)
+{
+        sh7372_intca_suspend();
+        memcpy((void *)SMFRAM, sh7372_resume_core_standby_sysc, 0x100);
+        sh7372_set_reset_vector(SMFRAM);
+        sh7372_enter_sysc(pllc0_on, 1 << 10);
+        sh7372_intca_resume();
+}
+
 #endif
 
 #ifdef CONFIG_CPU_IDLE
@@ -448,14 +512,20 @@ static int sh7372_enter_suspend(suspend_state_t suspend_state)
         unsigned long msk, msk2;
 
         /* check active clocks to determine potential wakeup sources */
-        if (sh7372_a3sm_valid(&msk, &msk2)) {
-
+        if (sh7372_sysc_valid(&msk, &msk2)) {
                 /* convert INTC mask and sense to SYSC mask and sense */
-                sh7372_setup_a3sm(msk, msk2);
-
-                /* enter A3SM sleep with PLLC0 off */
-                pr_debug("entering A3SM\n");
-                sh7372_enter_a3sm_common(0);
+                sh7372_setup_sysc(msk, msk2);
+
+                if (!console_suspend_enabled &&
+                    sh7372_a4s.genpd.status == GPD_STATE_POWER_OFF) {
+                        /* enter A4S sleep with PLLC0 off */
+                        pr_debug("entering A4S\n");
+                        sh7372_enter_a4s_common(0);
+                } else {
+                        /* enter A3SM sleep with PLLC0 off */
+                        pr_debug("entering A3SM\n");
+                        sh7372_enter_a3sm_common(0);
+                }
         } else {
                 /* default to Core Standby that supports all wakeup sources */
                 pr_debug("entering Core Standby\n");
@@ -464,9 +534,37 @@ static int sh7372_enter_suspend(suspend_state_t suspend_state)
         return 0;
 }
 
+/**
+ * sh7372_pm_notifier_fn - SH7372 PM notifier routine.
+ * @notifier: Unused.
+ * @pm_event: Event being handled.
+ * @unused: Unused.
+ */
+static int sh7372_pm_notifier_fn(struct notifier_block *notifier,
+                                 unsigned long pm_event, void *unused)
+{
+        switch (pm_event) {
+        case PM_SUSPEND_PREPARE:
+                /*
+                 * This is necessary, because the A4R domain has to be "on"
+                 * when suspend_device_irqs() and resume_device_irqs() are
+                 * executed during system suspend and resume, respectively, so
+                 * that those functions don't crash while accessing the INTCS.
+                 */
+                pm_genpd_poweron(&sh7372_a4r.genpd);
+                break;
+        case PM_POST_SUSPEND:
+                pm_genpd_poweroff_unused();
+                break;
+        }
+
+        return NOTIFY_DONE;
+}
+
 static void sh7372_suspend_init(void)
 {
         shmobile_suspend_ops.enter = sh7372_enter_suspend;
+        pm_notifier(sh7372_pm_notifier_fn, 0);
 }
 #else
 static void sh7372_suspend_init(void) {}
@@ -482,8 +580,6 @@ void __init sh7372_pm_init(void)
         /* do not convert A3SM, A3SP, A3SG, A4R power down into A4S */
         __raw_writel(0, PDNSEL);
 
-        sh7372_a3sp_init();
-
         sh7372_suspend_init();
         sh7372_cpuidle_init();
 }
diff --git a/arch/arm/mach-shmobile/setup-sh7372.c b/arch/arm/mach-shmobile/setup-sh7372.c
index 2380389e6ac5..c197f9d29d04 100644
--- a/arch/arm/mach-shmobile/setup-sh7372.c
+++ b/arch/arm/mach-shmobile/setup-sh7372.c
@@ -994,12 +994,16 @@ void __init sh7372_add_standard_devices(void)
         sh7372_init_pm_domain(&sh7372_a4r);
         sh7372_init_pm_domain(&sh7372_a3rv);
         sh7372_init_pm_domain(&sh7372_a3ri);
-        sh7372_init_pm_domain(&sh7372_a3sg);
+        sh7372_init_pm_domain(&sh7372_a4s);
         sh7372_init_pm_domain(&sh7372_a3sp);
+        sh7372_init_pm_domain(&sh7372_a3sg);
 
         sh7372_pm_add_subdomain(&sh7372_a4lc, &sh7372_a3rv);
         sh7372_pm_add_subdomain(&sh7372_a4r, &sh7372_a4lc);
 
+        sh7372_pm_add_subdomain(&sh7372_a4s, &sh7372_a3sg);
+        sh7372_pm_add_subdomain(&sh7372_a4s, &sh7372_a3sp);
+
         platform_add_devices(sh7372_early_devices,
                             ARRAY_SIZE(sh7372_early_devices));
 
diff --git a/arch/arm/mach-shmobile/sleep-sh7372.S b/arch/arm/mach-shmobile/sleep-sh7372.S
index f3ab3c5810ea..1d564674451d 100644
--- a/arch/arm/mach-shmobile/sleep-sh7372.S
+++ b/arch/arm/mach-shmobile/sleep-sh7372.S
@@ -37,13 +37,18 @@
 #if defined(CONFIG_SUSPEND) || defined(CONFIG_CPU_IDLE)
         .align  12
         .text
-        .global sh7372_resume_core_standby_a3sm
-sh7372_resume_core_standby_a3sm:
+        .global sh7372_resume_core_standby_sysc
+sh7372_resume_core_standby_sysc:
         ldr     pc, 1f
 1:      .long   cpu_resume - PAGE_OFFSET + PLAT_PHYS_OFFSET
 
-        .global sh7372_do_idle_a3sm
-sh7372_do_idle_a3sm:
+#define SPDCR 0xe6180008
+
+        /* A3SM & A4S power down */
+        .global sh7372_do_idle_sysc
+sh7372_do_idle_sysc:
+        mov     r8, r0 /* sleep mode passed in r0 */
+
         /*
          * Clear the SCTLR.C bit to prevent further data cache
          * allocation. Clearing SCTLR.C would make all the data accesses
@@ -80,13 +85,9 @@ sh7372_do_idle_a3sm:
         dsb
         dmb
 
-#define SPDCR 0xe6180008
-#define A3SM (1 << 12)
-
-        /* A3SM power down */
+        /* SYSC power down */
         ldr     r0, =SPDCR
-        ldr     r1, =A3SM
-        str     r1, [r0]
+        str     r8, [r0]
 1:
         b      1b
 
diff --git a/arch/arm/plat-samsung/include/plat/pm.h b/arch/arm/plat-samsung/include/plat/pm.h
index dcf68709f9cf..a6bdee204f2a 100644
--- a/arch/arm/plat-samsung/include/plat/pm.h
+++ b/arch/arm/plat-samsung/include/plat/pm.h
@@ -22,6 +22,7 @@ struct sys_device;
 #ifdef CONFIG_PM
 
 extern __init int s3c_pm_init(void);
+extern __init int s3c64xx_pm_init(void);
 
 #else
 
@@ -29,6 +30,11 @@ static inline int s3c_pm_init(void)
 {
         return 0;
 }
+
+static inline int s3c64xx_pm_init(void)
+{
+        return 0;
+}
 #endif
 
 /* configuration for the IRQ mask over sleep */