aboutsummaryrefslogtreecommitdiffstats
path: root/arch
diff options
context:
space:
mode:
authorYinghai Lu <yhlu.kernel@gmail.com>2008-08-19 23:50:11 -0400
committerIngo Molnar <mingo@elte.hu>2008-10-16 10:52:33 -0400
commit2c6927a38f65b53b62f86158fba29a068c4e8b6a (patch)
tree4f23cf5689c8fbaed771219b4afd3f785d8048bc /arch
parent9059d8fa4a3a9153da53da890039f7f956cc9d19 (diff)
irq: replace loop with nr_irqs with for_each_irq_desc
There are a handful of loops that go from 0 to nr_irqs and use get_irq_desc() on them. These would allocate all the irq_desc entries, regardless of the need for them. Use the smarter for_each_irq_desc() iterator that will only iterate over the present ones. v2: make sure arch without GENERIC_HARDIRQS work too Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch')
-rw-r--r--arch/x86/kernel/io_apic_64.c6
-rw-r--r--arch/x86/kernel/irq_64.c5
-rw-r--r--arch/x86/kernel/irqinit_64.c17
3 files changed, 10 insertions, 18 deletions
diff --git a/arch/x86/kernel/io_apic_64.c b/arch/x86/kernel/io_apic_64.c
index 51ef7eb75f2e..708be9724daf 100644
--- a/arch/x86/kernel/io_apic_64.c
+++ b/arch/x86/kernel/io_apic_64.c
@@ -1871,10 +1871,10 @@ unmask:
1871 1871
1872static void ir_irq_migration(struct work_struct *work) 1872static void ir_irq_migration(struct work_struct *work)
1873{ 1873{
1874 int irq; 1874 unsigned int irq;
1875 struct irq_desc *desc;
1875 1876
1876 for (irq = 0; irq < nr_irqs; irq++) { 1877 for_each_irq_desc(irq, desc) {
1877 struct irq_desc *desc = irq_to_desc(irq);
1878 if (desc->status & IRQ_MOVE_PENDING) { 1878 if (desc->status & IRQ_MOVE_PENDING) {
1879 unsigned long flags; 1879 unsigned long flags;
1880 1880
diff --git a/arch/x86/kernel/irq_64.c b/arch/x86/kernel/irq_64.c
index 4a0a4eb44dcb..b3cf55e325f5 100644
--- a/arch/x86/kernel/irq_64.c
+++ b/arch/x86/kernel/irq_64.c
@@ -224,17 +224,16 @@ void fixup_irqs(cpumask_t map)
224{ 224{
225 unsigned int irq; 225 unsigned int irq;
226 static int warned; 226 static int warned;
227 struct irq_desc *desc;
227 228
228 for (irq = 0; irq < nr_irqs; irq++) { 229 for_each_irq_desc(irq, desc) {
229 cpumask_t mask; 230 cpumask_t mask;
230 int break_affinity = 0; 231 int break_affinity = 0;
231 int set_affinity = 1; 232 int set_affinity = 1;
232 struct irq_desc *desc;
233 233
234 if (irq == 2) 234 if (irq == 2)
235 continue; 235 continue;
236 236
237 desc = irq_to_desc(irq);
238 /* interrupt's are disabled at this point */ 237 /* interrupt's are disabled at this point */
239 spin_lock(&desc->lock); 238 spin_lock(&desc->lock);
240 239
diff --git a/arch/x86/kernel/irqinit_64.c b/arch/x86/kernel/irqinit_64.c
index 0744b49b4d12..cd9f42d028d9 100644
--- a/arch/x86/kernel/irqinit_64.c
+++ b/arch/x86/kernel/irqinit_64.c
@@ -142,25 +142,18 @@ void __init init_ISA_irqs(void)
142 init_bsp_APIC(); 142 init_bsp_APIC();
143 init_8259A(0); 143 init_8259A(0);
144 144
145 for (i = 0; i < nr_irqs; i++) { 145 for (i = 0; i < 16; i++) {
146 struct irq_desc *desc = irq_to_desc(i); 146 struct irq_desc *desc = irq_to_desc(i);
147 147
148 desc->status = IRQ_DISABLED; 148 desc->status = IRQ_DISABLED;
149 desc->action = NULL; 149 desc->action = NULL;
150 desc->depth = 1; 150 desc->depth = 1;
151 151
152 if (i < 16) { 152 /*
153 /* 153 * 16 old-style INTA-cycle interrupts:
154 * 16 old-style INTA-cycle interrupts: 154 */
155 */ 155 set_irq_chip_and_handler_name(i, &i8259A_chip,
156 set_irq_chip_and_handler_name(i, &i8259A_chip,
157 handle_level_irq, "XT"); 156 handle_level_irq, "XT");
158 } else {
159 /*
160 * 'high' PCI IRQs filled in on demand
161 */
162 desc->chip = &no_irq_chip;
163 }
164 } 157 }
165} 158}
166 159