diff options
author | Anton Blanchard <anton@samba.org> | 2012-04-17 15:16:48 -0400 |
---|---|---|
committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2012-04-30 01:37:27 -0400 |
commit | 14fb1fa6e266fb9c4622b210d2636a2004a47e2b (patch) | |
tree | 32d97ffebb00deb19b581d9bfdb3259ffc34ae07 /arch | |
parent | d23c6fb4ebf7d3563dd801c95b22ada4516e35ce (diff) |
powerpc: Use WARN instead of dump_stack when printing EEH error backtrace
When we get an EEH error we just print a backtrace with dump_stack
which is rather cryptic. We really should print something before
spewing out the backtrace.
Also switch from dump_stack to WARN so we get more information about
the fail - what modules were loaded, what process was running etc.
This was useful information when debugging a recent EEH subsystem bug.
The standard WARN output should also get picked up by monitoring
tools like kerneloops.
The register dump is of questionable value here but I figured it was
better to use something standard and not roll my own.
Signed-off-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Diffstat (limited to 'arch')
-rw-r--r-- | arch/powerpc/platforms/pseries/eeh.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/powerpc/platforms/pseries/eeh.c b/arch/powerpc/platforms/pseries/eeh.c index a75e37dc41aa..ecd394cf34e6 100644 --- a/arch/powerpc/platforms/pseries/eeh.c +++ b/arch/powerpc/platforms/pseries/eeh.c | |||
@@ -489,7 +489,7 @@ int eeh_dn_check_failure(struct device_node *dn, struct pci_dev *dev) | |||
489 | * a stack trace will help the device-driver authors figure | 489 | * a stack trace will help the device-driver authors figure |
490 | * out what happened. So print that out. | 490 | * out what happened. So print that out. |
491 | */ | 491 | */ |
492 | dump_stack(); | 492 | WARN(1, "EEH: failure detected\n"); |
493 | return 1; | 493 | return 1; |
494 | 494 | ||
495 | dn_unlock: | 495 | dn_unlock: |