aboutsummaryrefslogtreecommitdiffstats
path: root/arch/x86
diff options
context:
space:
mode:
authorYinghai Lu <yinghai@kernel.org>2010-10-09 01:44:02 -0400
committerThomas Gleixner <tglx@linutronix.de>2010-10-12 10:53:40 -0400
commitfe6dab4e79e82ec35879bfe1a8968b7d15ac0d91 (patch)
tree391512e410decb068577011942b2887d2ad77a5e /arch/x86
parentf981a3dc1941035a108da1276c448de6b10ddac9 (diff)
x86: Don't setup ioapic irq for sci twice
The sparseirq rework triggered a warning in the iommu code, which was caused by setting up ioapic for ACPI irq 9 twice. This function is solely to handle interrupts which are on a secondary ioapic and outside the legacy irq range. Replace the sparse irq_to_desc check with a non ifdeffed version. [ tglx: Moved it before the ioapic sparse conversion and simplified the inverse logic ] Signed-off-by: Yinghai Lu <yinghai@kernel.org> LKML-Reference: <4CB00122.3030301@kernel.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86')
-rw-r--r--arch/x86/kernel/apic/io_apic.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 06da8fe2647e..5aae718a7133 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -1565,11 +1565,11 @@ void setup_IO_APIC_irq_extra(u32 gsi)
1565 return; 1565 return;
1566 1566
1567 irq = pin_2_irq(idx, apic_id, pin); 1567 irq = pin_2_irq(idx, apic_id, pin);
1568#ifdef CONFIG_SPARSE_IRQ 1568
1569 desc = irq_to_desc(irq); 1569 /* Only handle the non legacy irqs on secondary ioapics */
1570 if (desc) 1570 if (apic_id == 0 || irq < NR_IRQS_LEGACY)
1571 return; 1571 return;
1572#endif 1572
1573 desc = irq_to_desc_alloc_node(irq, node); 1573 desc = irq_to_desc_alloc_node(irq, node);
1574 if (!desc) { 1574 if (!desc) {
1575 printk(KERN_INFO "can not get irq_desc for %d\n", irq); 1575 printk(KERN_INFO "can not get irq_desc for %d\n", irq);