diff options
author | Thomas Gleixner <tglx@linutronix.de> | 2008-01-30 07:30:15 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-01-30 07:30:15 -0500 |
commit | 3c6bb07ac1b4174318606a26f0de8ceb9f6d8133 (patch) | |
tree | 957316f296a4a3f90abd4a970b1babce8eb55f52 /arch/x86 | |
parent | 37e650c7c8a27de533d409b53c29f4135dcc7af6 (diff) |
x86: use u32 for safe_apic_wait_icr_idle()
Preperatory patch for merging apic headers.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86')
-rw-r--r-- | arch/x86/kernel/apic_64.c | 4 | ||||
-rw-r--r-- | arch/x86/kernel/smpboot_64.c | 11 |
2 files changed, 8 insertions, 7 deletions
diff --git a/arch/x86/kernel/apic_64.c b/arch/x86/kernel/apic_64.c index dfeda91fa80c..3de3764a862c 100644 --- a/arch/x86/kernel/apic_64.c +++ b/arch/x86/kernel/apic_64.c | |||
@@ -135,9 +135,9 @@ void apic_wait_icr_idle(void) | |||
135 | cpu_relax(); | 135 | cpu_relax(); |
136 | } | 136 | } |
137 | 137 | ||
138 | unsigned int safe_apic_wait_icr_idle(void) | 138 | u32 safe_apic_wait_icr_idle(void) |
139 | { | 139 | { |
140 | unsigned int send_status; | 140 | u32 send_status; |
141 | int timeout; | 141 | int timeout; |
142 | 142 | ||
143 | timeout = 0; | 143 | timeout = 0; |
diff --git a/arch/x86/kernel/smpboot_64.c b/arch/x86/kernel/smpboot_64.c index 8147b7d4db63..b36d32ff0b39 100644 --- a/arch/x86/kernel/smpboot_64.c +++ b/arch/x86/kernel/smpboot_64.c | |||
@@ -384,19 +384,20 @@ static void inquire_remote_apic(int apicid) | |||
384 | unsigned i, regs[] = { APIC_ID >> 4, APIC_LVR >> 4, APIC_SPIV >> 4 }; | 384 | unsigned i, regs[] = { APIC_ID >> 4, APIC_LVR >> 4, APIC_SPIV >> 4 }; |
385 | char *names[] = { "ID", "VERSION", "SPIV" }; | 385 | char *names[] = { "ID", "VERSION", "SPIV" }; |
386 | int timeout; | 386 | int timeout; |
387 | unsigned int status; | 387 | u32 status; |
388 | 388 | ||
389 | printk(KERN_INFO "Inquiring remote APIC #%d...\n", apicid); | 389 | printk(KERN_INFO "Inquiring remote APIC #%d...\n", apicid); |
390 | 390 | ||
391 | for (i = 0; i < ARRAY_SIZE(regs); i++) { | 391 | for (i = 0; i < ARRAY_SIZE(regs); i++) { |
392 | printk("... APIC #%d %s: ", apicid, names[i]); | 392 | printk(KERN_INFO "... APIC #%d %s: ", apicid, names[i]); |
393 | 393 | ||
394 | /* | 394 | /* |
395 | * Wait for idle. | 395 | * Wait for idle. |
396 | */ | 396 | */ |
397 | status = safe_apic_wait_icr_idle(); | 397 | status = safe_apic_wait_icr_idle(); |
398 | if (status) | 398 | if (status) |
399 | printk("a previous APIC delivery may have failed\n"); | 399 | printk(KERN_CONT |
400 | "a previous APIC delivery may have failed\n"); | ||
400 | 401 | ||
401 | apic_write(APIC_ICR2, SET_APIC_DEST_FIELD(apicid)); | 402 | apic_write(APIC_ICR2, SET_APIC_DEST_FIELD(apicid)); |
402 | apic_write(APIC_ICR, APIC_DM_REMRD | regs[i]); | 403 | apic_write(APIC_ICR, APIC_DM_REMRD | regs[i]); |
@@ -410,10 +411,10 @@ static void inquire_remote_apic(int apicid) | |||
410 | switch (status) { | 411 | switch (status) { |
411 | case APIC_ICR_RR_VALID: | 412 | case APIC_ICR_RR_VALID: |
412 | status = apic_read(APIC_RRR); | 413 | status = apic_read(APIC_RRR); |
413 | printk("%08x\n", status); | 414 | printk(KERN_CONT "%08x\n", status); |
414 | break; | 415 | break; |
415 | default: | 416 | default: |
416 | printk("failed\n"); | 417 | printk(KERN_CONT "failed\n"); |
417 | } | 418 | } |
418 | } | 419 | } |
419 | } | 420 | } |