diff options
author | Andrew Morton <akpm@linux-foundation.org> | 2014-11-01 16:18:26 -0400 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2014-11-01 16:18:33 -0400 |
commit | a92f101bc99d17b75021cf29f18cc57f39a37d1f (patch) | |
tree | 7c0476b9025c6288d5e8b229913661f03d016922 /arch/x86/vdso | |
parent | 1c0c1b93df4dad43b8050db005bb1c03bc7e09bf (diff) |
x86: vdso: Fix build with older gcc
gcc-4.4.4:
arch/x86/vdso/vma.c: In function 'vgetcpu_cpu_init':
arch/x86/vdso/vma.c:247: error: unknown field 'limit0' specified in initializer
arch/x86/vdso/vma.c:247: warning: missing braces around initializer
arch/x86/vdso/vma.c:247: warning: (near initialization for '(anonymous).<anonymous>')
arch/x86/vdso/vma.c:248: error: unknown field 'limit' specified in initializer
arch/x86/vdso/vma.c:248: warning: excess elements in struct initializer
arch/x86/vdso/vma.c:248: warning: (near initialization for '(anonymous)')
....
I couldn't find any way of tricking it into accepting an initializer
format :(
Reported-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Fixes: 258801563b ("x86/vdso: Change the PER_CPU segment to use struct desc_struct")
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'arch/x86/vdso')
-rw-r--r-- | arch/x86/vdso/vma.c | 18 |
1 files changed, 8 insertions, 10 deletions
diff --git a/arch/x86/vdso/vma.c b/arch/x86/vdso/vma.c index a280b11e2122..009495b9ab4b 100644 --- a/arch/x86/vdso/vma.c +++ b/arch/x86/vdso/vma.c | |||
@@ -230,7 +230,7 @@ __setup("vdso=", vdso_setup); | |||
230 | static void vgetcpu_cpu_init(void *arg) | 230 | static void vgetcpu_cpu_init(void *arg) |
231 | { | 231 | { |
232 | int cpu = smp_processor_id(); | 232 | int cpu = smp_processor_id(); |
233 | struct desc_struct d; | 233 | struct desc_struct d = { }; |
234 | unsigned long node = 0; | 234 | unsigned long node = 0; |
235 | #ifdef CONFIG_NUMA | 235 | #ifdef CONFIG_NUMA |
236 | node = cpu_to_node(cpu); | 236 | node = cpu_to_node(cpu); |
@@ -243,15 +243,13 @@ static void vgetcpu_cpu_init(void *arg) | |||
243 | * quickly in user space in vgetcpu. (12 bits for the CPU | 243 | * quickly in user space in vgetcpu. (12 bits for the CPU |
244 | * and 8 bits for the node) | 244 | * and 8 bits for the node) |
245 | */ | 245 | */ |
246 | d = (struct desc_struct) { | 246 | d.limit0 = cpu | ((node & 0xf) << 12); |
247 | .limit0 = cpu | ((node & 0xf) << 12), | 247 | d.limit = node >> 4; |
248 | .limit = node >> 4, | 248 | d.type = 5; /* RO data, expand down, accessed */ |
249 | .type = 5, /* RO data, expand down, accessed */ | 249 | d.dpl = 3; /* Visible to user code */ |
250 | .dpl = 3, /* Visible to user code */ | 250 | d.s = 1; /* Not a system segment */ |
251 | .s = 1, /* Not a system segment */ | 251 | d.p = 1; /* Present */ |
252 | .p = 1, /* Present */ | 252 | d.d = 1; /* 32-bit */ |
253 | .d = 1, /* 32-bit */ | ||
254 | }; | ||
255 | 253 | ||
256 | write_gdt_entry(get_cpu_gdt_table(cpu), GDT_ENTRY_PER_CPU, &d, DESCTYPE_S); | 254 | write_gdt_entry(get_cpu_gdt_table(cpu), GDT_ENTRY_PER_CPU, &d, DESCTYPE_S); |
257 | } | 255 | } |