aboutsummaryrefslogtreecommitdiffstats
path: root/arch/x86/kvm
diff options
context:
space:
mode:
authorXiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>2014-04-17 05:06:12 -0400
committerMarcelo Tosatti <mtosatti@redhat.com>2014-04-23 16:49:48 -0400
commita086f6a1ebc9d8d2d028b99e779ce0dbd9691dea (patch)
treede33d7b00d27226d7b775dd038875f12d55c6e0a /arch/x86/kvm
parent42bf549f3c672006ba18e97152cbc563315ba4e6 (diff)
Revert "KVM: Simplify kvm->tlbs_dirty handling"
This reverts commit 5befdc385ddb2d5ae8995ad89004529a3acf58fc. Since we will allow flush tlb out of mmu-lock in the later patch Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Diffstat (limited to 'arch/x86/kvm')
-rw-r--r--arch/x86/kvm/paging_tmpl.h7
1 files changed, 3 insertions, 4 deletions
diff --git a/arch/x86/kvm/paging_tmpl.h b/arch/x86/kvm/paging_tmpl.h
index 123efd3ec29f..410776528265 100644
--- a/arch/x86/kvm/paging_tmpl.h
+++ b/arch/x86/kvm/paging_tmpl.h
@@ -913,8 +913,7 @@ static gpa_t FNAME(gva_to_gpa_nested)(struct kvm_vcpu *vcpu, gva_t vaddr,
913 * and kvm_mmu_notifier_invalidate_range_start detect the mapping page isn't 913 * and kvm_mmu_notifier_invalidate_range_start detect the mapping page isn't
914 * used by guest then tlbs are not flushed, so guest is allowed to access the 914 * used by guest then tlbs are not flushed, so guest is allowed to access the
915 * freed pages. 915 * freed pages.
916 * We set tlbs_dirty to let the notifier know this change and delay the flush 916 * And we increase kvm->tlbs_dirty to delay tlbs flush in this case.
917 * until such a case actually happens.
918 */ 917 */
919static int FNAME(sync_page)(struct kvm_vcpu *vcpu, struct kvm_mmu_page *sp) 918static int FNAME(sync_page)(struct kvm_vcpu *vcpu, struct kvm_mmu_page *sp)
920{ 919{
@@ -943,7 +942,7 @@ static int FNAME(sync_page)(struct kvm_vcpu *vcpu, struct kvm_mmu_page *sp)
943 return -EINVAL; 942 return -EINVAL;
944 943
945 if (FNAME(prefetch_invalid_gpte)(vcpu, sp, &sp->spt[i], gpte)) { 944 if (FNAME(prefetch_invalid_gpte)(vcpu, sp, &sp->spt[i], gpte)) {
946 vcpu->kvm->tlbs_dirty = true; 945 vcpu->kvm->tlbs_dirty++;
947 continue; 946 continue;
948 } 947 }
949 948
@@ -958,7 +957,7 @@ static int FNAME(sync_page)(struct kvm_vcpu *vcpu, struct kvm_mmu_page *sp)
958 957
959 if (gfn != sp->gfns[i]) { 958 if (gfn != sp->gfns[i]) {
960 drop_spte(vcpu->kvm, &sp->spt[i]); 959 drop_spte(vcpu->kvm, &sp->spt[i]);
961 vcpu->kvm->tlbs_dirty = true; 960 vcpu->kvm->tlbs_dirty++;
962 continue; 961 continue;
963 } 962 }
964 963