diff options
author | Jan Blunck <jblunck@suse.de> | 2009-04-07 19:58:56 -0400 |
---|---|---|
committer | Avi Kivity <avi@redhat.com> | 2009-06-10 04:48:49 -0400 |
commit | 9b62e5b10ff0f98346bcbe4a4fe3a0ca8fa7be30 (patch) | |
tree | 9170f5bce95041bc65630814d026db377beb2e25 /arch/x86/kvm | |
parent | 14d0bc1f7c8226d5088e7182c3b53e0c7e91d1af (diff) |
KVM: Wake up waitqueue before calling get_cpu()
This moves the get_cpu() call down to be called after we wake up the
waiters. Therefore the waitqueue locks can safely be rt mutex.
Signed-off-by: Jan Blunck <jblunck@suse.de>
Signed-off-by: Sven-Thorsten Dietrich <sven@thebigcorporation.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
Diffstat (limited to 'arch/x86/kvm')
-rw-r--r-- | arch/x86/kvm/x86.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 0f3e04b74a66..e2713716e732 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c | |||
@@ -4569,7 +4569,7 @@ static void vcpu_kick_intr(void *info) | |||
4569 | void kvm_vcpu_kick(struct kvm_vcpu *vcpu) | 4569 | void kvm_vcpu_kick(struct kvm_vcpu *vcpu) |
4570 | { | 4570 | { |
4571 | int ipi_pcpu = vcpu->cpu; | 4571 | int ipi_pcpu = vcpu->cpu; |
4572 | int cpu = get_cpu(); | 4572 | int cpu; |
4573 | 4573 | ||
4574 | if (waitqueue_active(&vcpu->wq)) { | 4574 | if (waitqueue_active(&vcpu->wq)) { |
4575 | wake_up_interruptible(&vcpu->wq); | 4575 | wake_up_interruptible(&vcpu->wq); |
@@ -4579,6 +4579,7 @@ void kvm_vcpu_kick(struct kvm_vcpu *vcpu) | |||
4579 | * We may be called synchronously with irqs disabled in guest mode, | 4579 | * We may be called synchronously with irqs disabled in guest mode, |
4580 | * So need not to call smp_call_function_single() in that case. | 4580 | * So need not to call smp_call_function_single() in that case. |
4581 | */ | 4581 | */ |
4582 | cpu = get_cpu(); | ||
4582 | if (vcpu->guest_mode && vcpu->cpu != cpu) | 4583 | if (vcpu->guest_mode && vcpu->cpu != cpu) |
4583 | smp_call_function_single(ipi_pcpu, vcpu_kick_intr, vcpu, 0); | 4584 | smp_call_function_single(ipi_pcpu, vcpu_kick_intr, vcpu, 0); |
4584 | put_cpu(); | 4585 | put_cpu(); |