aboutsummaryrefslogtreecommitdiffstats
path: root/arch/x86/kvm/vmx.c
diff options
context:
space:
mode:
authorGleb Natapov <gleb@redhat.com>2010-04-15 14:03:50 -0400
committerAvi Kivity <avi@redhat.com>2010-05-17 05:17:55 -0400
commitacb5451789f21ad51215897bb8f9306a05e8acd4 (patch)
tree7ab1d73a9b4fbbc82a5a2a98dda701a81c4eaf33 /arch/x86/kvm/vmx.c
parent6b18493d60e7f54a0feb771fa141b5fcb72ce1e4 (diff)
KVM: prevent spurious exit to userspace during task switch emulation.
If kvm_task_switch() fails code exits to userspace without specifying exit reason, so the previous exit reason is reused by userspace. Fix this by specifying exit reason correctly. Signed-off-by: Gleb Natapov <gleb@redhat.com> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Diffstat (limited to 'arch/x86/kvm/vmx.c')
-rw-r--r--arch/x86/kvm/vmx.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 1b38d8a88cf7..6e5e75e0d7d3 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -3316,9 +3316,13 @@ static int handle_task_switch(struct kvm_vcpu *vcpu)
3316 type != INTR_TYPE_NMI_INTR)) 3316 type != INTR_TYPE_NMI_INTR))
3317 skip_emulated_instruction(vcpu); 3317 skip_emulated_instruction(vcpu);
3318 3318
3319 if (!kvm_task_switch(vcpu, tss_selector, reason, has_error_code, 3319 if (kvm_task_switch(vcpu, tss_selector, reason,
3320 error_code)) 3320 has_error_code, error_code) == EMULATE_FAIL) {
3321 vcpu->run->exit_reason = KVM_EXIT_INTERNAL_ERROR;
3322 vcpu->run->internal.suberror = KVM_INTERNAL_ERROR_EMULATION;
3323 vcpu->run->internal.ndata = 0;
3321 return 0; 3324 return 0;
3325 }
3322 3326
3323 /* clear all local breakpoint enable flags */ 3327 /* clear all local breakpoint enable flags */
3324 vmcs_writel(GUEST_DR7, vmcs_readl(GUEST_DR7) & ~55); 3328 vmcs_writel(GUEST_DR7, vmcs_readl(GUEST_DR7) & ~55);