diff options
author | Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> | 2011-12-08 04:14:08 -0500 |
---|---|---|
committer | Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> | 2012-03-13 14:06:55 -0400 |
commit | a1f37788a6d8c037e7d92fe4a0fe9ec0d713b21e (patch) | |
tree | ba35a1467511d8ef3d60499423558bbebd083bd8 /arch/x86/kernel/tboot.c | |
parent | 09f98a825a821f7a3f1b162f9ed023f37213a63b (diff) |
tboot: Add return values for tboot_sleep
.. as appropiately. As tboot_sleep now returns values.
remove tboot_sleep_wrapper.
Suggested-and-Acked-by: Rafael J. Wysocki <rjw@sisk.pl>
Acked-by: Joseph Cihula <joseph.cihula@intel.com>
[v1: Return -1/0/+1 instead of ACPI_xx values]
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Diffstat (limited to 'arch/x86/kernel/tboot.c')
-rw-r--r-- | arch/x86/kernel/tboot.c | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/arch/x86/kernel/tboot.c b/arch/x86/kernel/tboot.c index 1a4ab7df5b63..6410744ac5cb 100644 --- a/arch/x86/kernel/tboot.c +++ b/arch/x86/kernel/tboot.c | |||
@@ -272,7 +272,7 @@ static void tboot_copy_fadt(const struct acpi_table_fadt *fadt) | |||
272 | offsetof(struct acpi_table_facs, firmware_waking_vector); | 272 | offsetof(struct acpi_table_facs, firmware_waking_vector); |
273 | } | 273 | } |
274 | 274 | ||
275 | void tboot_sleep(u8 sleep_state, u32 pm1a_control, u32 pm1b_control) | 275 | static int tboot_sleep(u8 sleep_state, u32 pm1a_control, u32 pm1b_control) |
276 | { | 276 | { |
277 | static u32 acpi_shutdown_map[ACPI_S_STATE_COUNT] = { | 277 | static u32 acpi_shutdown_map[ACPI_S_STATE_COUNT] = { |
278 | /* S0,1,2: */ -1, -1, -1, | 278 | /* S0,1,2: */ -1, -1, -1, |
@@ -281,7 +281,7 @@ void tboot_sleep(u8 sleep_state, u32 pm1a_control, u32 pm1b_control) | |||
281 | /* S5: */ TB_SHUTDOWN_S5 }; | 281 | /* S5: */ TB_SHUTDOWN_S5 }; |
282 | 282 | ||
283 | if (!tboot_enabled()) | 283 | if (!tboot_enabled()) |
284 | return; | 284 | return 0; |
285 | 285 | ||
286 | tboot_copy_fadt(&acpi_gbl_FADT); | 286 | tboot_copy_fadt(&acpi_gbl_FADT); |
287 | tboot->acpi_sinfo.pm1a_cnt_val = pm1a_control; | 287 | tboot->acpi_sinfo.pm1a_cnt_val = pm1a_control; |
@@ -292,15 +292,10 @@ void tboot_sleep(u8 sleep_state, u32 pm1a_control, u32 pm1b_control) | |||
292 | if (sleep_state >= ACPI_S_STATE_COUNT || | 292 | if (sleep_state >= ACPI_S_STATE_COUNT || |
293 | acpi_shutdown_map[sleep_state] == -1) { | 293 | acpi_shutdown_map[sleep_state] == -1) { |
294 | pr_warning("unsupported sleep state 0x%x\n", sleep_state); | 294 | pr_warning("unsupported sleep state 0x%x\n", sleep_state); |
295 | return; | 295 | return -1; |
296 | } | 296 | } |
297 | 297 | ||
298 | tboot_shutdown(acpi_shutdown_map[sleep_state]); | 298 | tboot_shutdown(acpi_shutdown_map[sleep_state]); |
299 | } | ||
300 | static int tboot_sleep_wrapper(u8 sleep_state, u32 pm1a_control, | ||
301 | u32 pm1b_control) | ||
302 | { | ||
303 | tboot_sleep(sleep_state, pm1a_control, pm1b_control); | ||
304 | return 0; | 299 | return 0; |
305 | } | 300 | } |
306 | 301 | ||
@@ -352,7 +347,7 @@ static __init int tboot_late_init(void) | |||
352 | atomic_set(&ap_wfs_count, 0); | 347 | atomic_set(&ap_wfs_count, 0); |
353 | register_hotcpu_notifier(&tboot_cpu_notifier); | 348 | register_hotcpu_notifier(&tboot_cpu_notifier); |
354 | 349 | ||
355 | acpi_os_set_prepare_sleep(&tboot_sleep_wrapper); | 350 | acpi_os_set_prepare_sleep(&tboot_sleep); |
356 | return 0; | 351 | return 0; |
357 | } | 352 | } |
358 | 353 | ||