diff options
author | Cyrill Gorcunov <gorcunov@openvz.org> | 2009-09-15 03:12:30 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-09-20 14:18:07 -0400 |
commit | 8312136fa8b0a3ec7323bbb1a46be8c0c26e994e (patch) | |
tree | fc90b5de2e93522c505105f59c8ce6a0162bb6b9 /arch/x86/kernel/apic | |
parent | efc8f7419ea0a97c38d0b80785c8c3d9ab8a4872 (diff) |
x86, apic: Fix missed handling of discrete apics
In case of discrete (pretty old) apics we may have cpu_has_apic bit
not set but have to check if smp_found_config (MP spec) is there
and apic was not disabled.
Also don't forget to print apic/io-apic for such case as well.
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Yinghai Lu <yinghai@kernel.org>
LKML-Reference: <20090915071230.GA10604@lenovo>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86/kernel/apic')
-rw-r--r-- | arch/x86/kernel/apic/apic.c | 2 | ||||
-rw-r--r-- | arch/x86/kernel/apic/io_apic.c | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index 072aea6c630b..2d59dfa29785 100644 --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c | |||
@@ -978,7 +978,7 @@ void lapic_shutdown(void) | |||
978 | { | 978 | { |
979 | unsigned long flags; | 979 | unsigned long flags; |
980 | 980 | ||
981 | if (!cpu_has_apic) | 981 | if (!cpu_has_apic && !apic_from_smp_config()) |
982 | return; | 982 | return; |
983 | 983 | ||
984 | local_irq_save(flags); | 984 | local_irq_save(flags); |
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c index 3c8f9e75d038..593c4f8a8bb8 100644 --- a/arch/x86/kernel/apic/io_apic.c +++ b/arch/x86/kernel/apic/io_apic.c | |||
@@ -1863,7 +1863,7 @@ __apicdebuginit(int) print_all_ICs(void) | |||
1863 | print_PIC(); | 1863 | print_PIC(); |
1864 | 1864 | ||
1865 | /* don't print out if apic is not there */ | 1865 | /* don't print out if apic is not there */ |
1866 | if (!cpu_has_apic || disable_apic) | 1866 | if (!cpu_has_apic && !apic_from_smp_config()) |
1867 | return 0; | 1867 | return 0; |
1868 | 1868 | ||
1869 | print_all_local_APICs(); | 1869 | print_all_local_APICs(); |
@@ -1981,7 +1981,7 @@ void disable_IO_APIC(void) | |||
1981 | /* | 1981 | /* |
1982 | * Use virtual wire A mode when interrupt remapping is enabled. | 1982 | * Use virtual wire A mode when interrupt remapping is enabled. |
1983 | */ | 1983 | */ |
1984 | if (cpu_has_apic) | 1984 | if (cpu_has_apic || apic_from_smp_config()) |
1985 | disconnect_bsp_APIC(!intr_remapping_enabled && | 1985 | disconnect_bsp_APIC(!intr_remapping_enabled && |
1986 | ioapic_i8259.pin != -1); | 1986 | ioapic_i8259.pin != -1); |
1987 | } | 1987 | } |