arch/tile: Miscellaneous cleanup changes.

This commit is primarily changes caused by reviewing "sparse"
and "checkpatch" output on our sources, so is somewhat noisy, since
things like "printk() -> pr_err()" (or whatever) throughout the
codebase tend to get tedious to read.  Rather than trying to tease
apart precisely which things changed due to which type of code
review, this commit includes various cleanups in the code:

- sparse: Add declarations in headers for globals.
- sparse: Fix __user annotations.
- sparse: Using gfp_t consistently instead of int.
- sparse: removing functions not actually used.
- checkpatch: Clean up printk() warnings by using pr_info(), etc.;
  also avoid partial-line printks except in bootup code.
  - checkpatch: Use exposed structs rather than typedefs.
  - checkpatch: Change some C99 comments to C89 comments.

In addition, a couple of minor other changes are rolled in
to this commit:

- Add support for a "raise" instruction to cause SIGFPE, etc., to be raised.
- Remove some compat code that is unnecessary when we fully eliminate
  some of the deprecated syscalls from the generic syscall ABI.
- Update the tile_defconfig to reflect current config contents.

Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>

1 files changed, 3 insertions, 15 deletions

diff --git a/arch/tile/mm/homecache.c b/arch/tile/mm/homecache.c
index 52feb77133ce..97c478e7be27 100644
--- a/arch/tile/mm/homecache.c
+++ b/arch/tile/mm/homecache.c
@@ -46,7 +46,7 @@
  * locally from a remote home.  There's no point in using it if we
  * don't have coherent local caching, though.
  */
-int __write_once noallocl2;
+static int __write_once noallocl2;
 static int __init set_noallocl2(char *str)
 {
         noallocl2 = 1;
@@ -60,15 +60,11 @@ early_param("noallocl2", set_noallocl2);
 
 #endif
 
-
-
 /* Provide no-op versions of these routines to keep flush_remote() cleaner. */
 #define mark_caches_evicted_start() 0
 #define mark_caches_evicted_finish(mask, timestamp) do {} while (0)
 
 
-
-
 /*
  * Update the irq_stat for cpus that we are going to interrupt
  * with TLB or cache flushes.  Also handle removing dataplane cpus
@@ -171,20 +167,12 @@ void flush_remote(unsigned long cache_pfn, unsigned long cache_control,
         cpumask_scnprintf(cache_buf, sizeof(cache_buf), &cache_cpumask_copy);
         cpumask_scnprintf(tlb_buf, sizeof(tlb_buf), &tlb_cpumask_copy);
 
-        printk("hv_flush_remote(%#llx, %#lx, %p [%s],"
+        pr_err("hv_flush_remote(%#llx, %#lx, %p [%s],"
                " %#lx, %#lx, %#lx, %p [%s], %p, %d) = %d\n",
                cache_pa, cache_control, cache_cpumask, cache_buf,
                (unsigned long)tlb_va, tlb_length, tlb_pgsize,
                tlb_cpumask, tlb_buf,
                asids, asidcount, rc);
-        if (asidcount > 0) {
-                int i;
-                printk(" asids:");
-                for (i = 0; i < asidcount; ++i)
-                        printk(" %d,%d,%d",
-                               asids[i].x, asids[i].y, asids[i].asid);
-                printk("\n");
-        }
         panic("Unsafe to continue.");
 }
 
@@ -293,7 +281,7 @@ pte_t pte_set_home(pte_t pte, int home)
          */
         if (hv_pte_get_nc(pte) && home != PAGE_HOME_IMMUTABLE) {
                 pte = hv_pte_clear_nc(pte);
-                printk("non-immutable page incoherently referenced: %#llx\n",
+                pr_err("non-immutable page incoherently referenced: %#llx\n",
                        pte.val);
         }