aboutsummaryrefslogtreecommitdiffstats
path: root/arch/sparc
diff options
context:
space:
mode:
authorSam Ravnborg <sam@ravnborg.org>2014-05-16 17:25:45 -0400
committerDavid S. Miller <davem@davemloft.net>2014-05-18 22:01:28 -0400
commit958b7b0720f6f2463463e4f9000639c39a6f97f5 (patch)
tree79337b96ef7a5f3e16b3b64fa946b9ae9201d507 /arch/sparc
parentfcea8b27f985bc02fd7b040bbb5914227a0f49d7 (diff)
sparc32: fix sparse warnings in sys_sparc_32.c
Fix following warnings: sys_sparc_32.c:32:26: warning: symbol 'sys_getpagesize' was not declared. Should it be static? sys_sparc_32.c:71:16: warning: symbol 'sparc_pipe' was not declared. Should it be static? sys_sparc_32.c:96:26: warning: symbol 'sys_mmap2' was not declared. Should it be static? sys_sparc_32.c:106:26: warning: symbol 'sys_mmap' was not declared. Should it be static? sys_sparc_32.c:114:6: warning: symbol 'sparc_remap_file_pages' was not declared. Should it be static? sys_sparc_32.c:127:1: warning: symbol 'c_sys_nis_syscall' was not declared. Should it be static? sys_sparc_32.c:144:1: warning: symbol 'sparc_breakpoint' was not declared. Should it be static? sys_sparc_32.c:200:16: warning: symbol 'sys_getdomainname' was not declared. Should it be static? Adapt systbls.h for use by both sparc32 + sparc64. In the process modify the return type of a few functions. Change return type from unsigned long to long: sys_mmap2() sys_mmap() Change return type from int to long: sparc_pipe() sys_getdomainname() The changed return type was done to align with sparc64. Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'arch/sparc')
-rw-r--r--arch/sparc/kernel/sys_sparc_32.c10
-rw-r--r--arch/sparc/kernel/systbls.h71
2 files changed, 47 insertions, 34 deletions
diff --git a/arch/sparc/kernel/sys_sparc_32.c b/arch/sparc/kernel/sys_sparc_32.c
index 3a8d1844402e..646988d4c1a3 100644
--- a/arch/sparc/kernel/sys_sparc_32.c
+++ b/arch/sparc/kernel/sys_sparc_32.c
@@ -24,6 +24,8 @@
24#include <asm/uaccess.h> 24#include <asm/uaccess.h>
25#include <asm/unistd.h> 25#include <asm/unistd.h>
26 26
27#include "systbls.h"
28
27/* #define DEBUG_UNIMP_SYSCALL */ 29/* #define DEBUG_UNIMP_SYSCALL */
28 30
29/* XXX Make this per-binary type, this way we can detect the type of 31/* XXX Make this per-binary type, this way we can detect the type of
@@ -68,7 +70,7 @@ unsigned long arch_get_unmapped_area(struct file *filp, unsigned long addr, unsi
68 * sys_pipe() is the normal C calling standard for creating 70 * sys_pipe() is the normal C calling standard for creating
69 * a pipe. It's not the way unix traditionally does this, though. 71 * a pipe. It's not the way unix traditionally does this, though.
70 */ 72 */
71asmlinkage int sparc_pipe(struct pt_regs *regs) 73asmlinkage long sparc_pipe(struct pt_regs *regs)
72{ 74{
73 int fd[2]; 75 int fd[2];
74 int error; 76 int error;
@@ -93,7 +95,7 @@ int sparc_mmap_check(unsigned long addr, unsigned long len)
93 95
94/* Linux version of mmap */ 96/* Linux version of mmap */
95 97
96asmlinkage unsigned long sys_mmap2(unsigned long addr, unsigned long len, 98asmlinkage long sys_mmap2(unsigned long addr, unsigned long len,
97 unsigned long prot, unsigned long flags, unsigned long fd, 99 unsigned long prot, unsigned long flags, unsigned long fd,
98 unsigned long pgoff) 100 unsigned long pgoff)
99{ 101{
@@ -103,7 +105,7 @@ asmlinkage unsigned long sys_mmap2(unsigned long addr, unsigned long len,
103 pgoff >> (PAGE_SHIFT - 12)); 105 pgoff >> (PAGE_SHIFT - 12));
104} 106}
105 107
106asmlinkage unsigned long sys_mmap(unsigned long addr, unsigned long len, 108asmlinkage long sys_mmap(unsigned long addr, unsigned long len,
107 unsigned long prot, unsigned long flags, unsigned long fd, 109 unsigned long prot, unsigned long flags, unsigned long fd,
108 unsigned long off) 110 unsigned long off)
109{ 111{
@@ -197,7 +199,7 @@ SYSCALL_DEFINE5(rt_sigaction, int, sig,
197 return ret; 199 return ret;
198} 200}
199 201
200asmlinkage int sys_getdomainname(char __user *name, int len) 202asmlinkage long sys_getdomainname(char __user *name, int len)
201{ 203{
202 int nlen, err; 204 int nlen, err;
203 205
diff --git a/arch/sparc/kernel/systbls.h b/arch/sparc/kernel/systbls.h
index 26e6dd72e92a..a3ed7ae0cf94 100644
--- a/arch/sparc/kernel/systbls.h
+++ b/arch/sparc/kernel/systbls.h
@@ -6,36 +6,47 @@
6#include <linux/signal.h> 6#include <linux/signal.h>
7#include <asm/utrap.h> 7#include <asm/utrap.h>
8 8
9extern asmlinkage unsigned long sys_getpagesize(void); 9asmlinkage unsigned long sys_getpagesize(void);
10extern asmlinkage long sparc_pipe(struct pt_regs *regs); 10asmlinkage long sparc_pipe(struct pt_regs *regs);
11extern asmlinkage long sys_sparc_ipc(unsigned int call, int first, 11asmlinkage unsigned long c_sys_nis_syscall(struct pt_regs *regs);
12 unsigned long second, 12asmlinkage long sys_getdomainname(char __user *name, int len);
13 unsigned long third, 13void do_rt_sigreturn(struct pt_regs *regs);
14 void __user *ptr, long fifth); 14asmlinkage long sys_mmap(unsigned long addr, unsigned long len,
15extern asmlinkage long sparc64_personality(unsigned long personality); 15 unsigned long prot, unsigned long flags,
16extern asmlinkage long sys64_munmap(unsigned long addr, size_t len); 16 unsigned long fd, unsigned long off);
17extern asmlinkage unsigned long sys64_mremap(unsigned long addr, 17asmlinkage void sparc_breakpoint(struct pt_regs *regs);
18 unsigned long old_len,
19 unsigned long new_len,
20 unsigned long flags,
21 unsigned long new_addr);
22extern asmlinkage unsigned long c_sys_nis_syscall(struct pt_regs *regs);
23extern asmlinkage long sys_getdomainname(char __user *name, int len);
24extern asmlinkage long sys_utrap_install(utrap_entry_t type,
25 utrap_handler_t new_p,
26 utrap_handler_t new_d,
27 utrap_handler_t __user *old_p,
28 utrap_handler_t __user *old_d);
29extern asmlinkage long sparc_memory_ordering(unsigned long model,
30 struct pt_regs *regs);
31extern asmlinkage long sys_rt_sigaction(int sig,
32 const struct sigaction __user *act,
33 struct sigaction __user *oact,
34 void __user *restorer,
35 size_t sigsetsize);
36 18
37extern asmlinkage void sparc64_set_context(struct pt_regs *regs); 19#ifdef CONFIG_SPARC32
38extern asmlinkage void sparc64_get_context(struct pt_regs *regs); 20asmlinkage long sys_mmap2(unsigned long addr, unsigned long len,
39extern void do_rt_sigreturn(struct pt_regs *regs); 21 unsigned long prot, unsigned long flags,
22 unsigned long fd, unsigned long pgoff);
23long sparc_remap_file_pages(unsigned long start, unsigned long size,
24 unsigned long prot, unsigned long pgoff,
25 unsigned long flags);
40 26
27#endif /* CONFIG_SPARC32 */
28
29#ifdef CONFIG_SPARC64
30asmlinkage long sys_sparc_ipc(unsigned int call, int first,
31 unsigned long second,
32 unsigned long third,
33 void __user *ptr, long fifth);
34asmlinkage long sparc64_personality(unsigned long personality);
35asmlinkage long sys64_munmap(unsigned long addr, size_t len);
36asmlinkage unsigned long sys64_mremap(unsigned long addr,
37 unsigned long old_len,
38 unsigned long new_len,
39 unsigned long flags,
40 unsigned long new_addr);
41asmlinkage long sys_utrap_install(utrap_entry_t type,
42 utrap_handler_t new_p,
43 utrap_handler_t new_d,
44 utrap_handler_t __user *old_p,
45 utrap_handler_t __user *old_d);
46asmlinkage long sparc_memory_ordering(unsigned long model,
47 struct pt_regs *regs);
48asmlinkage void sparc64_set_context(struct pt_regs *regs);
49asmlinkage void sparc64_get_context(struct pt_regs *regs);
50
51#endif /* CONFIG_SPARC64 */
41#endif /* _SYSTBLS_H */ 52#endif /* _SYSTBLS_H */