diff options
author | Dominik Dingel <dingel@linux.vnet.ibm.com> | 2014-10-06 10:34:44 -0400 |
---|---|---|
committer | Martin Schwidefsky <schwidefsky@de.ibm.com> | 2014-10-15 10:56:27 -0400 |
commit | 66e9bbdb3dbb335b158bb88de2642966af816ffe (patch) | |
tree | 511fbc5d45b696ddda37cb3d217171963163f2c3 /arch/s390/mm/pgtable.c | |
parent | c9eeb7b813c9525cda34b61dcf4455c52fc58890 (diff) |
s390/mm: fixing calls of pte_unmap_unlock
pte_unmap works on page table entry pointers, derefencing should be avoided.
As on s390 pte_unmap is a NOP, this is more a cleanup if we want to supply
later such function.
Signed-off-by: Dominik Dingel <dingel@linux.vnet.ibm.com>
Reviewed-by: Thomas Huth <thuth@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Diffstat (limited to 'arch/s390/mm/pgtable.c')
-rw-r--r-- | arch/s390/mm/pgtable.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/arch/s390/mm/pgtable.c b/arch/s390/mm/pgtable.c index 296b61a4af59..1b79ca67392f 100644 --- a/arch/s390/mm/pgtable.c +++ b/arch/s390/mm/pgtable.c | |||
@@ -656,7 +656,7 @@ void __gmap_zap(struct gmap *gmap, unsigned long gaddr) | |||
656 | } | 656 | } |
657 | pgste_set_unlock(ptep, pgste); | 657 | pgste_set_unlock(ptep, pgste); |
658 | out_pte: | 658 | out_pte: |
659 | pte_unmap_unlock(*ptep, ptl); | 659 | pte_unmap_unlock(ptep, ptl); |
660 | } | 660 | } |
661 | EXPORT_SYMBOL_GPL(__gmap_zap); | 661 | EXPORT_SYMBOL_GPL(__gmap_zap); |
662 | 662 | ||
@@ -943,7 +943,7 @@ retry: | |||
943 | } | 943 | } |
944 | if (!(pte_val(*ptep) & _PAGE_INVALID) && | 944 | if (!(pte_val(*ptep) & _PAGE_INVALID) && |
945 | (pte_val(*ptep) & _PAGE_PROTECT)) { | 945 | (pte_val(*ptep) & _PAGE_PROTECT)) { |
946 | pte_unmap_unlock(*ptep, ptl); | 946 | pte_unmap_unlock(ptep, ptl); |
947 | if (fixup_user_fault(current, mm, addr, FAULT_FLAG_WRITE)) { | 947 | if (fixup_user_fault(current, mm, addr, FAULT_FLAG_WRITE)) { |
948 | up_read(&mm->mmap_sem); | 948 | up_read(&mm->mmap_sem); |
949 | return -EFAULT; | 949 | return -EFAULT; |
@@ -974,7 +974,7 @@ retry: | |||
974 | pgste_val(new) |= PGSTE_UC_BIT; | 974 | pgste_val(new) |= PGSTE_UC_BIT; |
975 | 975 | ||
976 | pgste_set_unlock(ptep, new); | 976 | pgste_set_unlock(ptep, new); |
977 | pte_unmap_unlock(*ptep, ptl); | 977 | pte_unmap_unlock(ptep, ptl); |
978 | up_read(&mm->mmap_sem); | 978 | up_read(&mm->mmap_sem); |
979 | return 0; | 979 | return 0; |
980 | } | 980 | } |