[PATCH] ppc32 8xx: use io accessor macros instead of direct memory reference

Convert core 8xx drivers to use in_xxxbe/in_xxx macros instead of direct
memory references.

Other than making IO accesses explicit (which is a plus for readability), a
common set of macros provides a unified place for the volatile flag to
constraint compiler code reordering.

There are several unlucky places at the moment which lack the volatile
flag.

Signed-off-by: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>

1 files changed, 7 insertions, 7 deletions

diff --git a/arch/ppc/syslib/m8xx_wdt.c b/arch/ppc/syslib/m8xx_wdt.c
index 2ddc857e7fc7..c5ac5ce5d7d2 100644
--- a/arch/ppc/syslib/m8xx_wdt.c
+++ b/arch/ppc/syslib/m8xx_wdt.c
@@ -29,8 +29,8 @@ void m8xx_wdt_reset(void)
 {
         volatile immap_t *imap = (volatile immap_t *)IMAP_ADDR;
 
-        imap->im_siu_conf.sc_swsr = 0x556c;     /* write magic1 */
-        imap->im_siu_conf.sc_swsr = 0xaa39;     /* write magic2 */
+        out_be16(imap->im_siu_conf.sc_swsr, 0x556c);    /* write magic1 */
+        out_be16(imap->im_siu_conf.sc_swsr, 0xaa39);    /* write magic2 */
 }
 
 static irqreturn_t m8xx_wdt_interrupt(int irq, void *dev, struct pt_regs *regs)
@@ -39,7 +39,7 @@ static irqreturn_t m8xx_wdt_interrupt(int irq, void *dev, struct pt_regs *regs)
 
         m8xx_wdt_reset();
 
-        imap->im_sit.sit_piscr |= PISCR_PS;     /* clear irq */
+        out_be16(imap->im_sit.sit_piscr, in_be16(imap->im_sit.sit_piscr | PISCR_PS));   /* clear irq */
 
         return IRQ_HANDLED;
 }
@@ -51,7 +51,7 @@ void __init m8xx_wdt_handler_install(bd_t * binfo)
         u32 sypcr;
         u32 pitrtclk;
 
-        sypcr = imap->im_siu_conf.sc_sypcr;
+        sypcr = in_be32(imap->im_siu_conf.sc_sypcr);
 
         if (!(sypcr & 0x04)) {
                 printk(KERN_NOTICE "m8xx_wdt: wdt disabled (SYPCR: 0x%08X)\n",
@@ -87,9 +87,9 @@ void __init m8xx_wdt_handler_install(bd_t * binfo)
         else
                 pitc = pitrtclk * wdt_timeout / binfo->bi_intfreq / 2;
 
-        imap->im_sit.sit_pitc = pitc << 16;
-        imap->im_sit.sit_piscr =
-            (mk_int_int_mask(PIT_INTERRUPT) << 8) | PISCR_PIE | PISCR_PTE;
+        out_be32(imap->im_sit.sit_pitc, pitc << 16);
+
+        out_be16(imap->im_sit.sit_piscr, (mk_int_int_mask(PIT_INTERRUPT) << 8) | PISCR_PIE | PISCR_PTE);
 
         if (setup_irq(PIT_INTERRUPT, &m8xx_wdt_irqaction))
                 panic("m8xx_wdt: error setting up the watchdog irq!");