diff options
author | Andrea Arcangeli <aarcange@redhat.com> | 2011-11-02 16:37:19 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2011-11-02 19:06:57 -0400 |
commit | cf592bf768c4fa40282b8fce58a80820065de2cb (patch) | |
tree | e1095e7c1f62666d5702be2e4fe569209a226798 /arch/powerpc | |
parent | 3526741f0964c88bc2ce511e1078359052bf225b (diff) |
powerpc: gup_huge_pmd() return 0 if pte changes
powerpc didn't return 0 in that case, if it's rolling back the *nr pointer
it should also return zero to avoid adding pages to the array at the wrong
offset.
Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Hugh Dickins <hughd@google.com>
Cc: Johannes Weiner <jweiner@redhat.com>
Cc: Rik van Riel <riel@redhat.com>
Cc: Mel Gorman <mgorman@suse.de>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: David Miller <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'arch/powerpc')
-rw-r--r-- | arch/powerpc/mm/hugetlbpage.c | 21 |
1 files changed, 11 insertions, 10 deletions
diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c index a618ef01bfad..1c59d94f5942 100644 --- a/arch/powerpc/mm/hugetlbpage.c +++ b/arch/powerpc/mm/hugetlbpage.c | |||
@@ -443,16 +443,17 @@ static noinline int gup_hugepte(pte_t *ptep, unsigned long sz, unsigned long add | |||
443 | *nr -= refs; | 443 | *nr -= refs; |
444 | while (refs--) | 444 | while (refs--) |
445 | put_page(head); | 445 | put_page(head); |
446 | } else { | 446 | return 0; |
447 | /* | 447 | } |
448 | * Any tail page need their mapcount reference taken | 448 | |
449 | * before we return. | 449 | /* |
450 | */ | 450 | * Any tail page need their mapcount reference taken before we |
451 | while (refs--) { | 451 | * return. |
452 | if (PageTail(tail)) | 452 | */ |
453 | get_huge_page_tail(tail); | 453 | while (refs--) { |
454 | tail++; | 454 | if (PageTail(tail)) |
455 | } | 455 | get_huge_page_tail(tail); |
456 | tail++; | ||
456 | } | 457 | } |
457 | 458 | ||
458 | return 1; | 459 | return 1; |