aboutsummaryrefslogtreecommitdiffstats
path: root/arch/powerpc
diff options
context:
space:
mode:
authorAlexander Graf <agraf@suse.de>2010-08-02 15:48:53 -0400
committerAvi Kivity <avi@redhat.com>2010-10-24 04:52:08 -0400
commitb9877ce2994cc812f00dbb2adb88c1749b6dac86 (patch)
treee922a4f2db2f8e226f1e9cf9ec1234fe7b56a41e /arch/powerpc
parent928d78be54014e65498e289fdc3f82acc4b804a9 (diff)
KVM: PPC: Revert "KVM: PPC: Use kernel hash function"
It turns out the in-kernel hash function is sub-optimal for our subtle hash inputs where every bit is significant. So let's revert to the original hash functions. This reverts commit 05340ab4f9a6626f7a2e8f9fe5397c61d494f445. Signed-off-by: Alexander Graf <agraf@suse.de>
Diffstat (limited to 'arch/powerpc')
-rw-r--r--arch/powerpc/kvm/book3s_32_mmu_host.c10
-rw-r--r--arch/powerpc/kvm/book3s_64_mmu_host.c11
2 files changed, 17 insertions, 4 deletions
diff --git a/arch/powerpc/kvm/book3s_32_mmu_host.c b/arch/powerpc/kvm/book3s_32_mmu_host.c
index 343452cff9b2..57dddeb23b9b 100644
--- a/arch/powerpc/kvm/book3s_32_mmu_host.c
+++ b/arch/powerpc/kvm/book3s_32_mmu_host.c
@@ -19,7 +19,6 @@
19 */ 19 */
20 20
21#include <linux/kvm_host.h> 21#include <linux/kvm_host.h>
22#include <linux/hash.h>
23 22
24#include <asm/kvm_ppc.h> 23#include <asm/kvm_ppc.h>
25#include <asm/kvm_book3s.h> 24#include <asm/kvm_book3s.h>
@@ -77,7 +76,14 @@ void kvmppc_mmu_invalidate_pte(struct kvm_vcpu *vcpu, struct hpte_cache *pte)
77 * a hash, so we don't waste cycles on looping */ 76 * a hash, so we don't waste cycles on looping */
78static u16 kvmppc_sid_hash(struct kvm_vcpu *vcpu, u64 gvsid) 77static u16 kvmppc_sid_hash(struct kvm_vcpu *vcpu, u64 gvsid)
79{ 78{
80 return hash_64(gvsid, SID_MAP_BITS); 79 return (u16)(((gvsid >> (SID_MAP_BITS * 7)) & SID_MAP_MASK) ^
80 ((gvsid >> (SID_MAP_BITS * 6)) & SID_MAP_MASK) ^
81 ((gvsid >> (SID_MAP_BITS * 5)) & SID_MAP_MASK) ^
82 ((gvsid >> (SID_MAP_BITS * 4)) & SID_MAP_MASK) ^
83 ((gvsid >> (SID_MAP_BITS * 3)) & SID_MAP_MASK) ^
84 ((gvsid >> (SID_MAP_BITS * 2)) & SID_MAP_MASK) ^
85 ((gvsid >> (SID_MAP_BITS * 1)) & SID_MAP_MASK) ^
86 ((gvsid >> (SID_MAP_BITS * 0)) & SID_MAP_MASK));
81} 87}
82 88
83 89
diff --git a/arch/powerpc/kvm/book3s_64_mmu_host.c b/arch/powerpc/kvm/book3s_64_mmu_host.c
index 321c931f691c..e7c4d00b99cf 100644
--- a/arch/powerpc/kvm/book3s_64_mmu_host.c
+++ b/arch/powerpc/kvm/book3s_64_mmu_host.c
@@ -20,7 +20,6 @@
20 */ 20 */
21 21
22#include <linux/kvm_host.h> 22#include <linux/kvm_host.h>
23#include <linux/hash.h>
24 23
25#include <asm/kvm_ppc.h> 24#include <asm/kvm_ppc.h>
26#include <asm/kvm_book3s.h> 25#include <asm/kvm_book3s.h>
@@ -44,9 +43,17 @@ void kvmppc_mmu_invalidate_pte(struct kvm_vcpu *vcpu, struct hpte_cache *pte)
44 * a hash, so we don't waste cycles on looping */ 43 * a hash, so we don't waste cycles on looping */
45static u16 kvmppc_sid_hash(struct kvm_vcpu *vcpu, u64 gvsid) 44static u16 kvmppc_sid_hash(struct kvm_vcpu *vcpu, u64 gvsid)
46{ 45{
47 return hash_64(gvsid, SID_MAP_BITS); 46 return (u16)(((gvsid >> (SID_MAP_BITS * 7)) & SID_MAP_MASK) ^
47 ((gvsid >> (SID_MAP_BITS * 6)) & SID_MAP_MASK) ^
48 ((gvsid >> (SID_MAP_BITS * 5)) & SID_MAP_MASK) ^
49 ((gvsid >> (SID_MAP_BITS * 4)) & SID_MAP_MASK) ^
50 ((gvsid >> (SID_MAP_BITS * 3)) & SID_MAP_MASK) ^
51 ((gvsid >> (SID_MAP_BITS * 2)) & SID_MAP_MASK) ^
52 ((gvsid >> (SID_MAP_BITS * 1)) & SID_MAP_MASK) ^
53 ((gvsid >> (SID_MAP_BITS * 0)) & SID_MAP_MASK));
48} 54}
49 55
56
50static struct kvmppc_sid_map *find_sid_vsid(struct kvm_vcpu *vcpu, u64 gvsid) 57static struct kvmppc_sid_map *find_sid_vsid(struct kvm_vcpu *vcpu, u64 gvsid)
51{ 58{
52 struct kvmppc_sid_map *map; 59 struct kvmppc_sid_map *map;