aboutsummaryrefslogtreecommitdiffstats
path: root/arch/powerpc
diff options
context:
space:
mode:
authorTiejun Chen <tiejun.chen@windriver.com>2014-01-20 03:39:34 -0500
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>2014-01-29 01:02:26 -0500
commit94b09d75546247ec7e0d441f352f548946619fe8 (patch)
tree70119625d7a0ccd906c1d0add2dbceed48086316 /arch/powerpc
parent91b973f90c1220d71923e7efe1e61f5329806380 (diff)
powerpc/hugetlb: Replace __get_cpu_var with get_cpu_var
Replace __get_cpu_var safely with get_cpu_var to avoid the following call trace: [ 7253.637591] BUG: using smp_processor_id() in preemptible [00000000 00000000] code: hugemmap01/9048 [ 7253.637601] caller is free_hugepd_range.constprop.25+0x88/0x1a8 [ 7253.637605] CPU: 1 PID: 9048 Comm: hugemmap01 Not tainted 3.10.20-rt14+ #114 [ 7253.637606] Call Trace: [ 7253.637617] [cb049d80] [c0007ea4] show_stack+0x4c/0x168 (unreliable) [ 7253.637624] [cb049dc0] [c031c674] debug_smp_processor_id+0x114/0x134 [ 7253.637628] [cb049de0] [c0016d28] free_hugepd_range.constprop.25+0x88/0x1a8 [ 7253.637632] [cb049e00] [c001711c] hugetlb_free_pgd_range+0x6c/0x168 [ 7253.637639] [cb049e40] [c0117408] free_pgtables+0x12c/0x150 [ 7253.637646] [cb049e70] [c011ce38] unmap_region+0xa0/0x11c [ 7253.637671] [cb049ef0] [c011f03c] do_munmap+0x224/0x3bc [ 7253.637676] [cb049f20] [c011f2e0] vm_munmap+0x38/0x5c [ 7253.637682] [cb049f40] [c000ef88] ret_from_syscall+0x0/0x3c [ 7253.637686] --- Exception: c01 at 0xff16004 Signed-off-by: Tiejun Chen<tiejun.chen@windriver.com> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Diffstat (limited to 'arch/powerpc')
-rw-r--r--arch/powerpc/mm/hugetlbpage.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c
index 90bb6d9409bf..eb923654ba80 100644
--- a/arch/powerpc/mm/hugetlbpage.c
+++ b/arch/powerpc/mm/hugetlbpage.c
@@ -472,12 +472,13 @@ static void hugepd_free(struct mmu_gather *tlb, void *hugepte)
472{ 472{
473 struct hugepd_freelist **batchp; 473 struct hugepd_freelist **batchp;
474 474
475 batchp = &__get_cpu_var(hugepd_freelist_cur); 475 batchp = &get_cpu_var(hugepd_freelist_cur);
476 476
477 if (atomic_read(&tlb->mm->mm_users) < 2 || 477 if (atomic_read(&tlb->mm->mm_users) < 2 ||
478 cpumask_equal(mm_cpumask(tlb->mm), 478 cpumask_equal(mm_cpumask(tlb->mm),
479 cpumask_of(smp_processor_id()))) { 479 cpumask_of(smp_processor_id()))) {
480 kmem_cache_free(hugepte_cache, hugepte); 480 kmem_cache_free(hugepte_cache, hugepte);
481 put_cpu_var(hugepd_freelist_cur);
481 return; 482 return;
482 } 483 }
483 484
@@ -491,6 +492,7 @@ static void hugepd_free(struct mmu_gather *tlb, void *hugepte)
491 call_rcu_sched(&(*batchp)->rcu, hugepd_free_rcu_callback); 492 call_rcu_sched(&(*batchp)->rcu, hugepd_free_rcu_callback);
492 *batchp = NULL; 493 *batchp = NULL;
493 } 494 }
495 put_cpu_var(hugepd_freelist_cur);
494} 496}
495#endif 497#endif
496 498