diff options
author | Gavin Shan <gwshan@linux.vnet.ibm.com> | 2014-10-01 03:07:50 -0400 |
---|---|---|
committer | Michael Ellerman <mpe@ellerman.id.au> | 2014-10-14 20:27:18 -0400 |
commit | 8a6b3710ccc33da1fd5c85144ad3db01c4457552 (patch) | |
tree | 6f83b1e44cce83ecad58d8901c7073976e0abfec /arch/powerpc | |
parent | 8315070c07e7ef5f58ce9e317dc91fd727ecd419 (diff) |
powerpc/eeh: Rename flag EEH_PE_RESET to EEH_PE_CFG_BLOCKED
The flag EEH_PE_RESET indicates blocking config space of the PE
during reset time. We potentially need block PE's config space
other than reset time. So it's reasonable to replace it with
EEH_PE_CFG_BLOCKED to indicate its usage.
There are no substantial code or logic changes in this patch.
Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Diffstat (limited to 'arch/powerpc')
-rw-r--r-- | arch/powerpc/include/asm/eeh.h | 2 | ||||
-rw-r--r-- | arch/powerpc/kernel/eeh.c | 12 | ||||
-rw-r--r-- | arch/powerpc/kernel/eeh_driver.c | 12 | ||||
-rw-r--r-- | arch/powerpc/kernel/rtas_pci.c | 4 | ||||
-rw-r--r-- | arch/powerpc/platforms/powernv/eeh-ioda.c | 2 | ||||
-rw-r--r-- | arch/powerpc/platforms/powernv/pci.c | 2 |
6 files changed, 17 insertions, 17 deletions
diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h index 3b260efbfbf9..6a2ad90e6d8c 100644 --- a/arch/powerpc/include/asm/eeh.h +++ b/arch/powerpc/include/asm/eeh.h | |||
@@ -71,7 +71,7 @@ struct device_node; | |||
71 | 71 | ||
72 | #define EEH_PE_ISOLATED (1 << 0) /* Isolated PE */ | 72 | #define EEH_PE_ISOLATED (1 << 0) /* Isolated PE */ |
73 | #define EEH_PE_RECOVERING (1 << 1) /* Recovering PE */ | 73 | #define EEH_PE_RECOVERING (1 << 1) /* Recovering PE */ |
74 | #define EEH_PE_RESET (1 << 2) /* PE reset in progress */ | 74 | #define EEH_PE_CFG_BLOCKED (1 << 2) /* Block config access */ |
75 | 75 | ||
76 | #define EEH_PE_KEEP (1 << 8) /* Keep PE on hotplug */ | 76 | #define EEH_PE_KEEP (1 << 8) /* Keep PE on hotplug */ |
77 | 77 | ||
diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c index d543e4179c18..4d83f50cc614 100644 --- a/arch/powerpc/kernel/eeh.c +++ b/arch/powerpc/kernel/eeh.c | |||
@@ -673,18 +673,18 @@ int pcibios_set_pcie_reset_state(struct pci_dev *dev, enum pcie_reset_state stat | |||
673 | switch (state) { | 673 | switch (state) { |
674 | case pcie_deassert_reset: | 674 | case pcie_deassert_reset: |
675 | eeh_ops->reset(pe, EEH_RESET_DEACTIVATE); | 675 | eeh_ops->reset(pe, EEH_RESET_DEACTIVATE); |
676 | eeh_pe_state_clear(pe, EEH_PE_RESET); | 676 | eeh_pe_state_clear(pe, EEH_PE_CFG_BLOCKED); |
677 | break; | 677 | break; |
678 | case pcie_hot_reset: | 678 | case pcie_hot_reset: |
679 | eeh_pe_state_mark(pe, EEH_PE_RESET); | 679 | eeh_pe_state_mark(pe, EEH_PE_CFG_BLOCKED); |
680 | eeh_ops->reset(pe, EEH_RESET_HOT); | 680 | eeh_ops->reset(pe, EEH_RESET_HOT); |
681 | break; | 681 | break; |
682 | case pcie_warm_reset: | 682 | case pcie_warm_reset: |
683 | eeh_pe_state_mark(pe, EEH_PE_RESET); | 683 | eeh_pe_state_mark(pe, EEH_PE_CFG_BLOCKED); |
684 | eeh_ops->reset(pe, EEH_RESET_FUNDAMENTAL); | 684 | eeh_ops->reset(pe, EEH_RESET_FUNDAMENTAL); |
685 | break; | 685 | break; |
686 | default: | 686 | default: |
687 | eeh_pe_state_clear(pe, EEH_PE_RESET); | 687 | eeh_pe_state_clear(pe, EEH_PE_CFG_BLOCKED); |
688 | return -EINVAL; | 688 | return -EINVAL; |
689 | }; | 689 | }; |
690 | 690 | ||
@@ -1523,7 +1523,7 @@ int eeh_pe_reset(struct eeh_pe *pe, int option) | |||
1523 | switch (option) { | 1523 | switch (option) { |
1524 | case EEH_RESET_DEACTIVATE: | 1524 | case EEH_RESET_DEACTIVATE: |
1525 | ret = eeh_ops->reset(pe, option); | 1525 | ret = eeh_ops->reset(pe, option); |
1526 | eeh_pe_state_clear(pe, EEH_PE_RESET); | 1526 | eeh_pe_state_clear(pe, EEH_PE_CFG_BLOCKED); |
1527 | if (ret) | 1527 | if (ret) |
1528 | break; | 1528 | break; |
1529 | 1529 | ||
@@ -1538,7 +1538,7 @@ int eeh_pe_reset(struct eeh_pe *pe, int option) | |||
1538 | */ | 1538 | */ |
1539 | eeh_ops->set_option(pe, EEH_OPT_FREEZE_PE); | 1539 | eeh_ops->set_option(pe, EEH_OPT_FREEZE_PE); |
1540 | 1540 | ||
1541 | eeh_pe_state_mark(pe, EEH_PE_RESET); | 1541 | eeh_pe_state_mark(pe, EEH_PE_CFG_BLOCKED); |
1542 | ret = eeh_ops->reset(pe, option); | 1542 | ret = eeh_ops->reset(pe, option); |
1543 | break; | 1543 | break; |
1544 | default: | 1544 | default: |
diff --git a/arch/powerpc/kernel/eeh_driver.c b/arch/powerpc/kernel/eeh_driver.c index 3fd514f8e4b2..6535936bdf27 100644 --- a/arch/powerpc/kernel/eeh_driver.c +++ b/arch/powerpc/kernel/eeh_driver.c | |||
@@ -528,13 +528,13 @@ int eeh_pe_reset_and_recover(struct eeh_pe *pe) | |||
528 | eeh_pe_dev_traverse(pe, eeh_report_error, &result); | 528 | eeh_pe_dev_traverse(pe, eeh_report_error, &result); |
529 | 529 | ||
530 | /* Issue reset */ | 530 | /* Issue reset */ |
531 | eeh_pe_state_mark(pe, EEH_PE_RESET); | 531 | eeh_pe_state_mark(pe, EEH_PE_CFG_BLOCKED); |
532 | ret = eeh_reset_pe(pe); | 532 | ret = eeh_reset_pe(pe); |
533 | if (ret) { | 533 | if (ret) { |
534 | eeh_pe_state_clear(pe, EEH_PE_RECOVERING | EEH_PE_RESET); | 534 | eeh_pe_state_clear(pe, EEH_PE_RECOVERING | EEH_PE_CFG_BLOCKED); |
535 | return ret; | 535 | return ret; |
536 | } | 536 | } |
537 | eeh_pe_state_clear(pe, EEH_PE_RESET); | 537 | eeh_pe_state_clear(pe, EEH_PE_CFG_BLOCKED); |
538 | 538 | ||
539 | /* Unfreeze the PE */ | 539 | /* Unfreeze the PE */ |
540 | ret = eeh_clear_pe_frozen_state(pe, true); | 540 | ret = eeh_clear_pe_frozen_state(pe, true); |
@@ -601,10 +601,10 @@ static int eeh_reset_device(struct eeh_pe *pe, struct pci_bus *bus) | |||
601 | * config accesses. So we prefer to block them. However, controlled | 601 | * config accesses. So we prefer to block them. However, controlled |
602 | * PCI config accesses initiated from EEH itself are allowed. | 602 | * PCI config accesses initiated from EEH itself are allowed. |
603 | */ | 603 | */ |
604 | eeh_pe_state_mark(pe, EEH_PE_RESET); | 604 | eeh_pe_state_mark(pe, EEH_PE_CFG_BLOCKED); |
605 | rc = eeh_reset_pe(pe); | 605 | rc = eeh_reset_pe(pe); |
606 | if (rc) { | 606 | if (rc) { |
607 | eeh_pe_state_clear(pe, EEH_PE_RESET); | 607 | eeh_pe_state_clear(pe, EEH_PE_CFG_BLOCKED); |
608 | return rc; | 608 | return rc; |
609 | } | 609 | } |
610 | 610 | ||
@@ -613,7 +613,7 @@ static int eeh_reset_device(struct eeh_pe *pe, struct pci_bus *bus) | |||
613 | /* Restore PE */ | 613 | /* Restore PE */ |
614 | eeh_ops->configure_bridge(pe); | 614 | eeh_ops->configure_bridge(pe); |
615 | eeh_pe_restore_bars(pe); | 615 | eeh_pe_restore_bars(pe); |
616 | eeh_pe_state_clear(pe, EEH_PE_RESET); | 616 | eeh_pe_state_clear(pe, EEH_PE_CFG_BLOCKED); |
617 | 617 | ||
618 | /* Clear frozen state */ | 618 | /* Clear frozen state */ |
619 | rc = eeh_clear_pe_frozen_state(pe, false); | 619 | rc = eeh_clear_pe_frozen_state(pe, false); |
diff --git a/arch/powerpc/kernel/rtas_pci.c b/arch/powerpc/kernel/rtas_pci.c index c168337aef9d..ce7c8b6a8602 100644 --- a/arch/powerpc/kernel/rtas_pci.c +++ b/arch/powerpc/kernel/rtas_pci.c | |||
@@ -111,7 +111,7 @@ static int rtas_pci_read_config(struct pci_bus *bus, | |||
111 | return PCIBIOS_DEVICE_NOT_FOUND; | 111 | return PCIBIOS_DEVICE_NOT_FOUND; |
112 | #ifdef CONFIG_EEH | 112 | #ifdef CONFIG_EEH |
113 | edev = of_node_to_eeh_dev(dn); | 113 | edev = of_node_to_eeh_dev(dn); |
114 | if (edev && edev->pe && edev->pe->state & EEH_PE_RESET) | 114 | if (edev && edev->pe && edev->pe->state & EEH_PE_CFG_BLOCKED) |
115 | return PCIBIOS_DEVICE_NOT_FOUND; | 115 | return PCIBIOS_DEVICE_NOT_FOUND; |
116 | #endif | 116 | #endif |
117 | 117 | ||
@@ -175,7 +175,7 @@ static int rtas_pci_write_config(struct pci_bus *bus, | |||
175 | return PCIBIOS_DEVICE_NOT_FOUND; | 175 | return PCIBIOS_DEVICE_NOT_FOUND; |
176 | #ifdef CONFIG_EEH | 176 | #ifdef CONFIG_EEH |
177 | edev = of_node_to_eeh_dev(dn); | 177 | edev = of_node_to_eeh_dev(dn); |
178 | if (edev && edev->pe && (edev->pe->state & EEH_PE_RESET)) | 178 | if (edev && edev->pe && (edev->pe->state & EEH_PE_CFG_BLOCKED)) |
179 | return PCIBIOS_DEVICE_NOT_FOUND; | 179 | return PCIBIOS_DEVICE_NOT_FOUND; |
180 | #endif | 180 | #endif |
181 | ret = rtas_write_config(pdn, where, size, val); | 181 | ret = rtas_write_config(pdn, where, size, val); |
diff --git a/arch/powerpc/platforms/powernv/eeh-ioda.c b/arch/powerpc/platforms/powernv/eeh-ioda.c index 426814a2ede3..eba9cb10619c 100644 --- a/arch/powerpc/platforms/powernv/eeh-ioda.c +++ b/arch/powerpc/platforms/powernv/eeh-ioda.c | |||
@@ -373,7 +373,7 @@ static int ioda_eeh_get_pe_state(struct eeh_pe *pe) | |||
373 | * moving forward, we have to return operational | 373 | * moving forward, we have to return operational |
374 | * state during PE reset. | 374 | * state during PE reset. |
375 | */ | 375 | */ |
376 | if (pe->state & EEH_PE_RESET) { | 376 | if (pe->state & EEH_PE_CFG_BLOCKED) { |
377 | result = (EEH_STATE_MMIO_ACTIVE | | 377 | result = (EEH_STATE_MMIO_ACTIVE | |
378 | EEH_STATE_DMA_ACTIVE | | 378 | EEH_STATE_DMA_ACTIVE | |
379 | EEH_STATE_MMIO_ENABLED | | 379 | EEH_STATE_MMIO_ENABLED | |
diff --git a/arch/powerpc/platforms/powernv/pci.c b/arch/powerpc/platforms/powernv/pci.c index e9f509bbc078..b1b7ac2d494f 100644 --- a/arch/powerpc/platforms/powernv/pci.c +++ b/arch/powerpc/platforms/powernv/pci.c | |||
@@ -513,7 +513,7 @@ static bool pnv_pci_cfg_check(struct pci_controller *hose, | |||
513 | edev = of_node_to_eeh_dev(dn); | 513 | edev = of_node_to_eeh_dev(dn); |
514 | if (edev) { | 514 | if (edev) { |
515 | if (edev->pe && | 515 | if (edev->pe && |
516 | (edev->pe->state & EEH_PE_RESET)) | 516 | (edev->pe->state & EEH_PE_CFG_BLOCKED)) |
517 | return false; | 517 | return false; |
518 | 518 | ||
519 | if (edev->mode & EEH_DEV_REMOVED) | 519 | if (edev->mode & EEH_DEV_REMOVED) |