diff options
author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2014-07-20 03:20:59 -0400 |
---|---|---|
committer | Michael Ellerman <mpe@ellerman.id.au> | 2014-12-28 23:45:43 -0500 |
commit | e144d4edbce67ea269d181f81b9c5ef631743430 (patch) | |
tree | 12d8068adf71a164a9e999c5420d2cfe66d60ccc /arch/powerpc/sysdev | |
parent | 05b981f493e07856371ecd4a9294f187f5b50cf6 (diff) |
powerpc/4xx: Fix return value check in hsta_msi_probe()
In case of error, the function ioremap() returns NULL
not ERR_PTR(). The IS_ERR() test in the return value
check should be replaced with NULL test.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Diffstat (limited to 'arch/powerpc/sysdev')
-rw-r--r-- | arch/powerpc/sysdev/ppc4xx_hsta_msi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/powerpc/sysdev/ppc4xx_hsta_msi.c b/arch/powerpc/sysdev/ppc4xx_hsta_msi.c index ed9970ff8d94..f366d2d4c079 100644 --- a/arch/powerpc/sysdev/ppc4xx_hsta_msi.c +++ b/arch/powerpc/sysdev/ppc4xx_hsta_msi.c | |||
@@ -145,7 +145,7 @@ static int hsta_msi_probe(struct platform_device *pdev) | |||
145 | ppc4xx_hsta_msi.address = mem->start; | 145 | ppc4xx_hsta_msi.address = mem->start; |
146 | ppc4xx_hsta_msi.data = ioremap(mem->start, resource_size(mem)); | 146 | ppc4xx_hsta_msi.data = ioremap(mem->start, resource_size(mem)); |
147 | ppc4xx_hsta_msi.irq_count = irq_count; | 147 | ppc4xx_hsta_msi.irq_count = irq_count; |
148 | if (IS_ERR(ppc4xx_hsta_msi.data)) { | 148 | if (!ppc4xx_hsta_msi.data) { |
149 | dev_err(dev, "Unable to map memory\n"); | 149 | dev_err(dev, "Unable to map memory\n"); |
150 | return -ENOMEM; | 150 | return -ENOMEM; |
151 | } | 151 | } |