Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux into next

Freescale updates from Scott:

"Highlights include BMan device tree nodes, an MSI erratum workaround, a
couple minor performance improvements, config updates, and misc
fixes/cleanup."

4 files changed, 38 insertions, 29 deletions

diff --git a/arch/powerpc/sysdev/fsl_msi.c b/arch/powerpc/sysdev/fsl_msi.c
index 4bbb4b8dfd09..f086c6f22dc9 100644
--- a/arch/powerpc/sysdev/fsl_msi.c
+++ b/arch/powerpc/sysdev/fsl_msi.c
@@ -162,7 +162,17 @@ static void fsl_compose_msi_msg(struct pci_dev *pdev, int hwirq,
         msg->address_lo = lower_32_bits(address);
         msg->address_hi = upper_32_bits(address);
 
-        msg->data = hwirq;
+        /*
+         * MPIC version 2.0 has erratum PIC1. It causes
+         * that neither MSI nor MSI-X can work fine.
+         * This is a workaround to allow MSI-X to function
+         * properly. It only works for MSI-X, we prevent
+         * MSI on buggy chips in fsl_setup_msi_irqs().
+         */
+        if (msi_data->feature & MSI_HW_ERRATA_ENDIAN)
+                msg->data = __swab32(hwirq);
+        else
+                msg->data = hwirq;
 
         pr_debug("%s: allocated srs: %d, ibs: %d\n", __func__,
                  (hwirq >> msi_data->srs_shift) & MSI_SRS_MASK,
@@ -180,8 +190,16 @@ static int fsl_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type)
         struct msi_msg msg;
         struct fsl_msi *msi_data;
 
-        if (type == PCI_CAP_ID_MSIX)
-                pr_debug("fslmsi: MSI-X untested, trying anyway.\n");
+        if (type == PCI_CAP_ID_MSI) {
+                /*
+                 * MPIC version 2.0 has erratum PIC1. For now MSI
+                 * could not work. So check to prevent MSI from
+                 * being used on the board with this erratum.
+                 */
+                list_for_each_entry(msi_data, &msi_head, list)
+                        if (msi_data->feature & MSI_HW_ERRATA_ENDIAN)
+                                return -EINVAL;
+        }
 
         /*
          * If the PCI node has an fsl,msi property, then we need to use it
@@ -446,6 +464,11 @@ static int fsl_of_msi_probe(struct platform_device *dev)
 
         msi->feature = features->fsl_pic_ip;
 
+        /* For erratum PIC1 on MPIC version 2.0*/
+        if ((features->fsl_pic_ip & FSL_PIC_IP_MASK) == FSL_PIC_IP_MPIC
+                        && (fsl_mpic_primary_get_version() == 0x0200))
+                msi->feature |= MSI_HW_ERRATA_ENDIAN;
+
         /*
          * Remember the phandle, so that we can match with any PCI nodes
          * that have an "fsl,msi" property.
diff --git a/arch/powerpc/sysdev/fsl_msi.h b/arch/powerpc/sysdev/fsl_msi.h
index 420cfcbdac01..a67359d993e5 100644
--- a/arch/powerpc/sysdev/fsl_msi.h
+++ b/arch/powerpc/sysdev/fsl_msi.h
@@ -27,6 +27,8 @@
 #define FSL_PIC_IP_IPIC   0x00000002
 #define FSL_PIC_IP_VMPIC  0x00000003
 
+#define MSI_HW_ERRATA_ENDIAN 0x00000010
+
 struct fsl_msi_cascade_data;
 
 struct fsl_msi {
diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c
index f72b592d60cc..fb19084c5860 100644
--- a/arch/powerpc/sysdev/mpic.c
+++ b/arch/powerpc/sysdev/mpic.c
@@ -655,7 +655,6 @@ static inline struct mpic * mpic_from_irq_data(struct irq_data *d)
 static inline void mpic_eoi(struct mpic *mpic)
 {
         mpic_cpu_write(MPIC_INFO(CPU_EOI), 0);
-        (void)mpic_cpu_read(MPIC_INFO(CPU_WHOAMI));
 }
 
 /*
@@ -1219,6 +1218,16 @@ static u32 fsl_mpic_get_version(struct mpic *mpic)
  * Exported functions
  */
 
+u32 fsl_mpic_primary_get_version(void)
+{
+        struct mpic *mpic = mpic_primary;
+
+        if (mpic)
+                return fsl_mpic_get_version(mpic);
+
+        return 0;
+}
+
 struct mpic * __init mpic_alloc(struct device_node *node,
                                 phys_addr_t phys_addr,
                                 unsigned int flags,
diff --git a/arch/powerpc/sysdev/qe_lib/qe_io.c b/arch/powerpc/sysdev/qe_lib/qe_io.c
index d09994164daf..7ea0174f6d3d 100644
--- a/arch/powerpc/sysdev/qe_lib/qe_io.c
+++ b/arch/powerpc/sysdev/qe_lib/qe_io.c
@@ -190,28 +190,3 @@ int par_io_of_config(struct device_node *np)
         return 0;
 }
 EXPORT_SYMBOL(par_io_of_config);
-
-#ifdef DEBUG
-static void dump_par_io(void)
-{
-        unsigned int i;
-
-        printk(KERN_INFO "%s: par_io=%p\n", __func__, par_io);
-        for (i = 0; i < num_par_io_ports; i++) {
-                printk(KERN_INFO "      cpodr[%u]=%08x\n", i,
-                        in_be32(&par_io[i].cpodr));
-                printk(KERN_INFO "      cpdata[%u]=%08x\n", i,
-                        in_be32(&par_io[i].cpdata));
-                printk(KERN_INFO "      cpdir1[%u]=%08x\n", i,
-                        in_be32(&par_io[i].cpdir1));
-                printk(KERN_INFO "      cpdir2[%u]=%08x\n", i,
-                        in_be32(&par_io[i].cpdir2));
-                printk(KERN_INFO "      cppar1[%u]=%08x\n", i,
-                        in_be32(&par_io[i].cppar1));
-                printk(KERN_INFO "      cppar2[%u]=%08x\n", i,
-                        in_be32(&par_io[i].cppar2));
-        }
-
-}
-EXPORT_SYMBOL(dump_par_io);
-#endif /* DEBUG */