diff options
author | Arnd Bergmann <arnd@arndb.de> | 2009-02-10 00:55:16 -0500 |
---|---|---|
committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2009-02-22 23:53:02 -0500 |
commit | 6ed8d12849d651c646c108807754a544d2e506f1 (patch) | |
tree | d0dd1acbe601486f5cc035125ba9b763b1cec25f /arch/powerpc/platforms | |
parent | 74254647e06452faff3675f9cd347ef2a5d63d90 (diff) |
powerpc/cell: Fix dependency in cpufreq
cbe_cpufreq has a partial dependency on cbe_cpufreq_pmi, which cannot
be easily expressed in Kconfig. This fixes it by introducing an
extra Kconfig symbol CBE_CPUFREQ_PMI_ENABLE. To make the dependency
clearer, turn PPC_PMI into an automatic symbol.
Reported-by: Michael Neuling <mikey@neuling.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Michael Neuling <mikey@neuling.org>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Diffstat (limited to 'arch/powerpc/platforms')
-rw-r--r-- | arch/powerpc/platforms/Kconfig | 9 | ||||
-rw-r--r-- | arch/powerpc/platforms/cell/Kconfig | 22 |
2 files changed, 18 insertions, 13 deletions
diff --git a/arch/powerpc/platforms/Kconfig b/arch/powerpc/platforms/Kconfig index b25404ca2216..b4ab3728653e 100644 --- a/arch/powerpc/platforms/Kconfig +++ b/arch/powerpc/platforms/Kconfig | |||
@@ -92,15 +92,6 @@ config RTAS_FLASH | |||
92 | tristate "Firmware flash interface" | 92 | tristate "Firmware flash interface" |
93 | depends on PPC64 && RTAS_PROC | 93 | depends on PPC64 && RTAS_PROC |
94 | 94 | ||
95 | config PPC_PMI | ||
96 | tristate "Support for PMI" | ||
97 | depends on PPC_IBM_CELL_BLADE | ||
98 | help | ||
99 | PMI (Platform Management Interrupt) is a way to | ||
100 | communicate with the BMC (Baseboard Management Controller). | ||
101 | It is used in some IBM Cell blades. | ||
102 | default m | ||
103 | |||
104 | config MMIO_NVRAM | 95 | config MMIO_NVRAM |
105 | bool | 96 | bool |
106 | default n | 97 | default n |
diff --git a/arch/powerpc/platforms/cell/Kconfig b/arch/powerpc/platforms/cell/Kconfig index 5cc3279559a4..037f59a4bfe7 100644 --- a/arch/powerpc/platforms/cell/Kconfig +++ b/arch/powerpc/platforms/cell/Kconfig | |||
@@ -98,7 +98,7 @@ config PPC_IBM_CELL_RESETBUTTON | |||
98 | 98 | ||
99 | config PPC_IBM_CELL_POWERBUTTON | 99 | config PPC_IBM_CELL_POWERBUTTON |
100 | tristate "IBM Cell Blade power button" | 100 | tristate "IBM Cell Blade power button" |
101 | depends on PPC_IBM_CELL_BLADE && PPC_PMI && INPUT_EVDEV | 101 | depends on PPC_IBM_CELL_BLADE && INPUT_EVDEV |
102 | default y | 102 | default y |
103 | help | 103 | help |
104 | Support Powerbutton on IBM Cell blades. | 104 | Support Powerbutton on IBM Cell blades. |
@@ -118,9 +118,9 @@ config CBE_CPUFREQ | |||
118 | For details, take a look at <file:Documentation/cpu-freq/>. | 118 | For details, take a look at <file:Documentation/cpu-freq/>. |
119 | If you don't have such processor, say N | 119 | If you don't have such processor, say N |
120 | 120 | ||
121 | config CBE_CPUFREQ_PMI | 121 | config CBE_CPUFREQ_PMI_ENABLE |
122 | tristate "CBE frequency scaling using PMI interface" | 122 | bool "CBE frequency scaling using PMI interface" |
123 | depends on CBE_CPUFREQ && PPC_PMI && EXPERIMENTAL | 123 | depends on CBE_CPUFREQ && EXPERIMENTAL |
124 | default n | 124 | default n |
125 | help | 125 | help |
126 | Select this, if you want to use the PMI interface | 126 | Select this, if you want to use the PMI interface |
@@ -128,6 +128,20 @@ config CBE_CPUFREQ_PMI | |||
128 | processor will not only be able to run at lower speed, | 128 | processor will not only be able to run at lower speed, |
129 | but also at lower core voltage. | 129 | but also at lower core voltage. |
130 | 130 | ||
131 | config CBE_CPUFREQ_PMI | ||
132 | tristate | ||
133 | depends on CBE_CPUFREQ_PMI_ENABLE | ||
134 | default CBE_CPUFREQ | ||
135 | |||
136 | config PPC_PMI | ||
137 | tristate | ||
138 | default y | ||
139 | depends on CBE_CPUFREQ_PMI || PPC_IBM_CELL_POWERBUTTON | ||
140 | help | ||
141 | PMI (Platform Management Interrupt) is a way to | ||
142 | communicate with the BMC (Baseboard Management Controller). | ||
143 | It is used in some IBM Cell blades. | ||
144 | |||
131 | config CBE_CPUFREQ_SPU_GOVERNOR | 145 | config CBE_CPUFREQ_SPU_GOVERNOR |
132 | tristate "CBE frequency scaling based on SPU usage" | 146 | tristate "CBE frequency scaling based on SPU usage" |
133 | depends on SPU_FS && CPU_FREQ | 147 | depends on SPU_FS && CPU_FREQ |