of/reconfig: Always use the same structure for notifiers

The OF_RECONFIG notifier callback uses a different structure depending
on whether it is a node change or a property change. This is silly, and
not very safe. Rework the code to use the same data structure regardless
of the type of notifier.

Signed-off-by: Grant Likely <grant.likely@linaro.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Cc: <linuxppc-dev@lists.ozlabs.org>

1 files changed, 7 insertions, 8 deletions

diff --git a/arch/powerpc/platforms/pseries/hotplug-memory.c b/arch/powerpc/platforms/pseries/hotplug-memory.c
index 3c4c0dcd90d3..1bbb78fab530 100644
--- a/arch/powerpc/platforms/pseries/hotplug-memory.c
+++ b/arch/powerpc/platforms/pseries/hotplug-memory.c
@@ -183,7 +183,7 @@ static int pseries_add_mem_node(struct device_node *np)
         return (ret < 0) ? -EINVAL : 0;
 }
 
-static int pseries_update_drconf_memory(struct of_prop_reconfig *pr)
+static int pseries_update_drconf_memory(struct of_reconfig_data *pr)
 {
         struct of_drconf_cell *new_drmem, *old_drmem;
         unsigned long memblock_size;
@@ -232,22 +232,21 @@ static int pseries_update_drconf_memory(struct of_prop_reconfig *pr)
 }
 
 static int pseries_memory_notifier(struct notifier_block *nb,
-                                   unsigned long action, void *node)
+                                   unsigned long action, void *data)
 {
-        struct of_prop_reconfig *pr;
+        struct of_reconfig_data *rd = data;
         int err = 0;
 
         switch (action) {
         case OF_RECONFIG_ATTACH_NODE:
-                err = pseries_add_mem_node(node);
+                err = pseries_add_mem_node(rd->dn);
                 break;
         case OF_RECONFIG_DETACH_NODE:
-                err = pseries_remove_mem_node(node);
+                err = pseries_remove_mem_node(rd->dn);
                 break;
         case OF_RECONFIG_UPDATE_PROPERTY:
-                pr = (struct of_prop_reconfig *)node;
-                if (!strcmp(pr->prop->name, "ibm,dynamic-memory"))
-                        err = pseries_update_drconf_memory(pr);
+                if (!strcmp(rd->prop->name, "ibm,dynamic-memory"))
+                        err = pseries_update_drconf_memory(rd);
                 break;
         }
         return notifier_from_errno(err);